gerrit.onap Code Review - policy/apex-pdp.git/commit

Code Review / policy / apex-pdp.git / commit

author	liamfallon <liam.fallon@est.tech>
	Wed, 10 Jul 2019 19:44:39 +0000 (19:44 +0000)
committer	liamfallon <liam.fallon@est.tech>
	Wed, 10 Jul 2019 19:44:39 +0000 (19:44 +0000)
commit	adf67497761295115dc75b525500d687518fc4fd
tree	c5c5b5e737ac08256e9f782b5dccbd3ddc08d3c3	tree \| snapshot
parent	5c384fb2888029c2babb859c30318749e1ce828c	commit \| diff

Add integration tests for executor properties

Added integration test that sets properties in a dummy plugin and amends
them in tasks in a policy. Variosu tests added to check combinations of
where properties are set in plugins or in tasks or both.

Implementaiton changed to:
- Always pass in a Properies object, the properties object coming into
the policy cannot be null because the task/TSL/SFL may wish to set it
- Fix a bug where the properties were not passed from the ApexEvent to
the engine event in the ApexEventUnmarshaller class

Issue-ID: POLICY-1743
Change-Id: I6aa152b28d46cf3cc6fa56a1a95b76a8e55f5a49
Signed-off-by: liamfallon <liam.fallon@est.tech>

69 files changed:

core/core-engine/src/main/java/org/onap/policy/apex/core/engine/event/EnEvent.java		diff \| blob \| history
core/core-engine/src/main/java/org/onap/policy/apex/core/engine/executor/StateFinalizerExecutor.java		diff \| blob \| history
core/core-engine/src/main/java/org/onap/policy/apex/core/engine/executor/TaskExecutor.java		diff \| blob \| history
core/core-engine/src/main/java/org/onap/policy/apex/core/engine/executor/TaskSelectExecutor.java		diff \| blob \| history
core/core-engine/src/main/java/org/onap/policy/apex/core/engine/executor/context/StateFinalizerExecutionContext.java		diff \| blob \| history
core/core-engine/src/main/java/org/onap/policy/apex/core/engine/executor/context/TaskExecutionContext.java		diff \| blob \| history
core/core-engine/src/main/java/org/onap/policy/apex/core/engine/executor/context/TaskSelectionExecutionContext.java		diff \| blob \| history
core/core-engine/src/test/java/org/onap/policy/apex/core/engine/executor/StateFinalizerExecutorTest.java		diff \| blob \| history
core/core-engine/src/test/java/org/onap/policy/apex/core/engine/executor/TaskExecutorTest.java		diff \| blob \| history
core/core-engine/src/test/java/org/onap/policy/apex/core/engine/executor/TaskSelectExecutorTest.java		diff \| blob \| history
examples/examples-myfirstpolicy/src/test/java/org/onap/policy/apex/examples/myfirstpolicy/MfpUseCaseTest.java		diff \| blob \| history
plugins/plugins-event/plugins-event-carrier/plugins-event-carrier-jms/src/main/java/org/onap/policy/apex/plugins/event/carrier/jms/ApexJmsConsumer.java		diff \| blob \| history
plugins/plugins-event/plugins-event-carrier/plugins-event-carrier-kafka/src/main/java/org/onap/policy/apex/plugins/event/carrier/kafka/ApexKafkaConsumer.java		diff \| blob \| history
plugins/plugins-event/plugins-event-carrier/plugins-event-carrier-restclient/src/main/java/org/onap/policy/apex/plugins/event/carrier/restclient/ApexRestClientConsumer.java		diff \| blob \| history
plugins/plugins-event/plugins-event-carrier/plugins-event-carrier-restrequestor/src/main/java/org/onap/policy/apex/plugins/event/carrier/restrequestor/ApexRestRequestorConsumer.java		diff \| blob \| history
plugins/plugins-event/plugins-event-carrier/plugins-event-carrier-restserver/src/main/java/org/onap/policy/apex/plugins/event/carrier/restserver/ApexRestServerConsumer.java		diff \| blob \| history
plugins/plugins-event/plugins-event-carrier/plugins-event-carrier-websocket/src/main/java/org/onap/policy/apex/plugins/event/carrier/websocket/ApexWebSocketConsumer.java		diff \| blob \| history
plugins/plugins-executor/plugins-executor-java/src/test/java/org/onap/policy/apex/plugins/executor/java/JavaStateFinalizerExecutorTest.java		diff \| blob \| history
plugins/plugins-executor/plugins-executor-java/src/test/java/org/onap/policy/apex/plugins/executor/java/JavaTaskExecutorTest.java		diff \| blob \| history
plugins/plugins-executor/plugins-executor-java/src/test/java/org/onap/policy/apex/plugins/executor/java/JavaTaskSelectExecutorTest.java		diff \| blob \| history
plugins/plugins-executor/plugins-executor-javascript/src/test/java/org/onap/policy/apex/plugins/executor/javascript/JavascriptStateFinalizerExecutorTest.java		diff \| blob \| history
plugins/plugins-executor/plugins-executor-javascript/src/test/java/org/onap/policy/apex/plugins/executor/javascript/JavascriptTaskExecutorTest.java		diff \| blob \| history
plugins/plugins-executor/plugins-executor-javascript/src/test/java/org/onap/policy/apex/plugins/executor/javascript/JavascriptTaskSelectExecutorTest.java		diff \| blob \| history
plugins/plugins-executor/plugins-executor-jruby/src/test/java/org/onap/policy/apex/plugins/executor/jruby/JrubyStateFinalizerExecutorTest.java		diff \| blob \| history
plugins/plugins-executor/plugins-executor-jruby/src/test/java/org/onap/policy/apex/plugins/executor/jruby/JrubyTaskExecutorTest.java		diff \| blob \| history
plugins/plugins-executor/plugins-executor-jruby/src/test/java/org/onap/policy/apex/plugins/executor/jruby/JrubyTaskSelectExecutorTest.java		diff \| blob \| history
plugins/plugins-executor/plugins-executor-jython/src/test/java/org/onap/policy/apex/plugins/executor/jython/JythonStateFinalizerExecutorTest.java		diff \| blob \| history
plugins/plugins-executor/plugins-executor-jython/src/test/java/org/onap/policy/apex/plugins/executor/jython/JythonTaskExecutorTest.java		diff \| blob \| history
plugins/plugins-executor/plugins-executor-jython/src/test/java/org/onap/policy/apex/plugins/executor/jython/JythonTaskSelectExecutorTest.java		diff \| blob \| history
plugins/plugins-executor/plugins-executor-mvel/src/test/java/org/onap/policy/apex/plugins/executor/mvel/MvelStateFinalizerExecutorTest.java		diff \| blob \| history
plugins/plugins-executor/plugins-executor-mvel/src/test/java/org/onap/policy/apex/plugins/executor/mvel/MvelTaskExecutorTest.java		diff \| blob \| history
plugins/plugins-executor/plugins-executor-mvel/src/test/java/org/onap/policy/apex/plugins/executor/mvel/MvelTaskSelectExecutorTest.java		diff \| blob \| history
services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/ApexEvent.java		diff \| blob \| history
services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/impl/enevent/ApexEvent2EnEventConverter.java		diff \| blob \| history
services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/impl/eventrequestor/EventRequestorConsumer.java		diff \| blob \| history
services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/impl/filecarrierplugin/consumer/ApexFileEventConsumer.java		diff \| blob \| history
services/services-engine/src/main/java/org/onap/policy/apex/service/engine/main/ApexEventUnmarshaller.java		diff \| blob \| history
testsuites/integration/integration-uservice-test/pom.xml		diff \| blob \| history
testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/executionproperties/DummyApexEventConsumer.java	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/executionproperties/DummyApexEventProducer.java	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/executionproperties/DummyCarrierTechnologyParameters.java	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/executionproperties/RunTestEvent.java	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/java/org/onap/policy/apex/testsuites/integration/uservice/executionproperties/TestExecutionProperties.java	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/policies/executionproperties/logic/AddPropertyTask.js	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/policies/executionproperties/logic/DefinedToEmptyTask.js	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/policies/executionproperties/logic/EmptyToDefinedTask.js	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/policies/executionproperties/logic/EmptyToEmptyTask.js	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/policies/executionproperties/logic/ReadOnlyTask.js	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/policies/executionproperties/logic/RemovePropertyTask.js	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/policies/executionproperties/logic/RunTestStateTSL.js	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/policies/executionproperties/policy/ExecutionPropertiesTestPolicyModel.apex	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/addProperty_conf.json	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/addProperty_in.properties	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/addProperty_out_expected.properties	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/definedToEmpty_conf.json	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/definedToEmpty_in.properties	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/definedToEmpty_out_expected.properties	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/emptyToDefined_conf.json	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/emptyToDefined_in.properties	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/emptyToDefined_out_expected.properties	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/emptyToEmpty_conf.json	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/emptyToEmpty_in.properties	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/emptyToEmpty_out_expected.properties	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/readOnly_conf.json	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/readOnly_in.properties	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/readOnly_out_expected.properties	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/removeProperty_conf.json	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/removeProperty_in.properties	[new file with mode: 0644]	blob
testsuites/integration/integration-uservice-test/src/test/resources/testdata/executionproperties/removeProperty_out_expected.properties	[new file with mode: 0644]	blob

This repo will hold the next generation Apex PDP engine (Casablanca)

RSS Atom