Code Review / policy / gui.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: e13710d) | patch
Fix sonarqube code smells 43/119843/2
authormkidd <michael.kidd@est.tech>
Wed, 24 Mar 2021 12:26:31 +0000 (12:26 +0000)
committermkidd <michael.kidd@est.tech>
Thu, 25 Mar 2021 16:14:07 +0000 (16:14 +0000)
commitaabae2a75c606a8f44fd5e0b38d840bf8cd767dc
treed9a4a1f0c6addb20cde96bb5edd6c60259bda868tree | snapshot
parente13710d3bd6c6aa1c02ccc3ee9e1ecf8b77581c0commit | diff
Fix sonarqube code smells

Making changed regarding code smells. Some variables being declared twice while in scope.
renaming some modelFileName in ApexFiles.js that is being declared while there is a constant with the same name.
renamed some of the for loop control variables so that sonarqube doesnt see it as an issue
Made changes based on reviews

Issue-ID: POLICY-3095
Change-Id: If38934247a4e4ff9c48043feb3adde5505c46993
Signed-off-by: mkidd <michael.kidd@est.tech>
18 files changed:
gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexAjax.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexContextAlbumTab.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexContextSchemaEditForm.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexContextSchemaTab.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexEventEditForm.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexEventTab.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexFiles.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexKeyInformationTab.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexNewModelForm.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexPolicyEditForm.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexPolicyEditForm_State.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexPolicyTab.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexTaskEditForm.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexTaskTab.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/dropdownList.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/fileMenu.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/showhideElement.js diff | blob | history
gui-editors/gui-editor-apex/src/main/resources/webapp/js/showhideTextarea.js diff | blob | history
Policy Administration GUI (Frontend). Archived as per RT69287