Fix eclipse warnings in clamp 16/123816/2
authorJim Hahn <jrh3@att.com>
Thu, 2 Sep 2021 13:57:16 +0000 (09:57 -0400)
committerJim Hahn <jrh3@att.com>
Thu, 2 Sep 2021 15:26:11 +0000 (11:26 -0400)
commita84ef3cb2133fde745c50d7a23290505e4f4659a
tree9edcaf76ba26edbcf5c3be67b1e06518d1a5d344
parent5af35328dd1cab498c1d361126fd123dd859eb07
Fix eclipse warnings in clamp

Fixed some of these warnings, just in policy-clamp-runtime:
- equals() with wrong argument type in junit
- remove unneeded "SuppressWarning"
- unused fields
- deprecated classes/methods

Fixed some sonars, too:
- use isEqualByComparingTo()
- method complexity: used eclipse to auto-extract methods

Fixed checkstyle issues:
- indentation level

Did not address all deprecation issues (e.g., SSLSocketFactory).

Issue-ID: POLICY-3200
Change-Id: Ibd92e5326854002dc0ca2d7b3b777699cafb5e98
Signed-off-by: Jim Hahn <jrh3@att.com>
14 files changed:
participant/participant-intermediary/src/main/java/org/onap/policy/clamp/controlloop/participant/intermediary/handler/IntermediaryActivator.java
runtime-controlloop/src/main/java/org/onap/policy/clamp/controlloop/runtime/config/messaging/MessageDispatcherActivator.java
runtime-controlloop/src/test/java/org/onap/policy/clamp/controlloop/runtime/instantiation/ControlLoopInstantiationProviderTest.java
runtime/src/main/java/org/onap/policy/clamp/clds/client/DcaeInventoryServices.java
runtime/src/main/java/org/onap/policy/clamp/clds/config/CamelConfiguration.java
runtime/src/main/java/org/onap/policy/clamp/clds/config/sdc/SdcControllersConfiguration.java
runtime/src/main/java/org/onap/policy/clamp/clds/tosca/update/execution/ToscaMetadataExecutor.java
runtime/src/main/java/org/onap/policy/clamp/clds/tosca/update/parser/ToscaConverterToJsonSchema.java
runtime/src/main/java/org/onap/policy/clamp/clds/tosca/update/templates/JsonTemplateManager.java
runtime/src/main/java/org/onap/policy/clamp/loop/CsarInstaller.java
runtime/src/main/java/org/onap/policy/clamp/policy/pdpgroup/PdpGroupPayload.java
runtime/src/test/java/org/onap/policy/clamp/clds/tosca/update/ToscaConverterWithDictionarySupportItTestCase.java
runtime/src/test/java/org/onap/policy/clamp/clds/util/LoggingUtilsTest.java
runtime/src/test/java/org/onap/policy/clamp/loop/ExternalComponentStateTest.java