Code Review / policy / models.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 9f0fbd0) | patch
Fix sonars from removal of duplicate code 58/117958/3
authorJim Hahn <jrh3@att.com>
Wed, 17 Feb 2021 15:10:39 +0000 (10:10 -0500)
committerJim Hahn <jrh3@att.com>
Wed, 17 Feb 2021 15:48:40 +0000 (10:48 -0500)
commit9fb6de04f2402c29a4a792cc118f5bbb53906f81
tree08f09ec4128c1bca05307f26815b0296e1f8bbe3tree | snapshot
parent9f0fbd02f184071c2de30c944bec311741e6180ecommit | diff
Fix sonars from removal of duplicate code

The work to remove duplicate code from models introduced as many new
sonars as it eliminated. :-(  Addressed the following new issues:
- visibility of constructor
- use of more specific assertThat() calls

Also added two junit test file that were somehow previously left out.

Issue-ID: POLICY-2905
Change-Id: I7a0206bd157412d3c6d98bfe21797f106b37ac65
Signed-off-by: Jim Hahn <jrh3@att.com>
models-tosca/src/main/java/org/onap/policy/models/tosca/simple/concepts/JpaToscaWithStringProperties.java diff | blob | history
models-tosca/src/main/java/org/onap/policy/models/tosca/simple/concepts/JpaToscaWithToscaProperties.java diff | blob | history
models-tosca/src/test/java/org/onap/policy/models/tosca/authorative/concepts/ToscaWithToscaPropertiesTest.java [new file with mode: 0644] blob
models-tosca/src/test/java/org/onap/policy/models/tosca/simple/concepts/JpaToscaWithStringPropertiesTest.java diff | blob | history
models-tosca/src/test/java/org/onap/policy/models/tosca/simple/concepts/JpaToscaWithToscaPropertiesTest.java [new file with mode: 0644] blob
This repo will hold model code agnostic to PDP engines (Casablanca)