Fix sonars in server-pool 55/111855/1
authorJim Hahn <jrh3@att.com>
Fri, 28 Aug 2020 21:19:25 +0000 (17:19 -0400)
committerJim Hahn <jrh3@att.com>
Fri, 28 Aug 2020 22:36:54 +0000 (18:36 -0400)
commit8fe27a3bf0e13d0188bc209991c07a9bcfab44d3
tree0b37b8d045eb3995b31593ad6b1cc8985352b001
parent3fb61743113683b2be271429263a96fb0a7dd90a
Fix sonars in server-pool

Addressed the following sonars in feature-server-pool:
- re-interrupt after catching an InterruptException
- reduce cognitive complexity
- cognitive complexity
- not enough arguments for logger message
- use UnaryOperator instead of Function
- update static fields via static methods
- too many break/continue in for-loop

Also fixed some Eclipse warnings:
- add parameter to generic types
- useless assignments
- newInstance() has been deprecated
- close streams

Issue-ID: POLICY-2616
Change-Id: Ibf6c20e6c2a7eb8c60e1b38f388d86a0f9b8804b
Signed-off-by: Jim Hahn <jrh3@att.com>
feature-server-pool/pom.xml
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/Bucket.java
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/Discovery.java
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/FeatureServerPool.java
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/Keyword.java
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/Leader.java
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/Server.java
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/TargetLock.java
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/persistence/Persistence.java
feature-server-pool/src/test/java/org/onap/policy/drools/serverpooltest/Adapter.java