Code Review / sdc.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 79ec043) | patch
Remove csvReportFilePath from ValidationConfigManager 00/106300/6
authorFrancis Toth <francis.toth@yoppworks.com>
Mon, 20 Apr 2020 00:16:33 +0000 (20:16 -0400)
committerOfir Sonsino <ofir.sonsino@intl.att.com>
Tue, 28 Apr 2020 08:21:37 +0000 (08:21 +0000)
commit83df155640dd015d68f01f784dfab24d4c252af1
treea9c629542dcac3f92e54b8f1321e4d6a0fd26372tree | snapshot
parent79ec04301a726e8c48f1275877cb852d2d74adc0commit | diff
Remove csvReportFilePath from ValidationConfigManager

This commit aims to extract the csvReportFilePath field from ValidationConfigManager in order to improve testability. This commit contains multiple minor modifications resulting from bubbling up the csvReportFilePath static field to where it is actually set. Put differently, most of the modifications result from changing the signature of the functions which formerly relied on ValidationConfigManager.getCSVReportFilePath.

Change-Id: I82c3b0fca8a0f407319e40ecfff45e89ec1d4323
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Issue-ID: SDC-2499
asdctool/src/main/java/org/openecomp/sdc/asdctool/impl/validator/config/ValidationConfigManager.java diff | blob | history
asdctool/src/main/java/org/openecomp/sdc/asdctool/impl/validator/config/ValidationToolConfiguration.java diff | blob | history
asdctool/src/main/java/org/openecomp/sdc/asdctool/impl/validator/utils/ReportManager.java diff | blob | history
asdctool/src/main/java/org/openecomp/sdc/asdctool/main/ArtifactValidatorTool.java diff | blob | history
asdctool/src/main/java/org/openecomp/sdc/asdctool/main/ValidationTool.java diff | blob | history
asdctool/src/test/java/org/openecomp/sdc/asdctool/impl/validator/config/ValidationConfigManagerTest.java diff | blob | history
asdctool/src/test/java/org/openecomp/sdc/asdctool/impl/validator/tasks/artifacts/ArtifactValidationUtilsTest.java diff | blob | history
asdctool/src/test/java/org/openecomp/sdc/asdctool/impl/validator/utils/ReportManagerHelper.java diff | blob | history
asdctool/src/test/java/org/openecomp/sdc/asdctool/impl/validator/utils/ReportManagerTest.java diff | blob | history
SDC Parent Project Catalog FE and BE