Code Review / policy / pap.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: a240d7a) | patch
Fix sonar issues in PAP 05/89905/2
authorjrh3 <jrh3@att.com>
Fri, 14 Jun 2019 14:31:40 +0000 (10:31 -0400)
committerjrh3 <jrh3@att.com>
Fri, 14 Jun 2019 14:36:34 +0000 (10:36 -0400)
commit82cc7e0ccf799e0ea5d9afd033a3cff88468b6bf
treeeb10d3d9278656866b1323d7a50d650ce0e98b33tree | snapshot
parenta240d7a4020d0346040fe4d86682a6ab8fcd757acommit | diff
Fix sonar issues in PAP

Replace string concatenation with "{}" place-holders in logging
statements.
Refactored PdpStatusMessageHandler and PdpGroupStateChangeProvider
to extract common/duplicate code block into PdpMessageGenerator.
Refactored selectPdpGroupsForRegistration() to reduce "cyclomatic complexity";
extracted selectPdpSubGroupsForRegistration from it.

Issue-ID: POLICY-1791
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: Ia0ebc1cf41cd2fa288130b4a58614a4983f47f8b
Signed-off-by: jrh3 <jrh3@att.com>
main/src/main/java/org/onap/policy/pap/main/comm/PdpMessageGenerator.java [new file with mode: 0644] blob
main/src/main/java/org/onap/policy/pap/main/comm/PdpStatusMessageHandler.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/comm/TimerManager.java diff | blob | history
main/src/main/java/org/onap/policy/pap/main/rest/PdpGroupStateChangeProvider.java diff | blob | history
Policy Administration (Backend)