gerrit.onap Code Review - policy/drools-applications.git/commit

Code Review / policy / drools-applications.git / commit

author	Pamela Dragosh <pdragosh@research.att.com>
	Wed, 29 Aug 2018 11:58:53 +0000 (07:58 -0400)
committer	Pamela Dragosh <pdragosh@research.att.com>
	Wed, 29 Aug 2018 16:34:55 +0000 (12:34 -0400)
commit	8279af376b435e1d7dd118a1955c5681edf3b847
tree	f0e9f24028b8e96908184192f9e2813a2981938a	tree \| snapshot
parent	17435998307f9f86ec5ebe55d6d36eceee1f1943	commit \| diff

Fix remaining checkstyle

Lots of formatting, missing javadoc, distance from use,
imports must be explicit, ordering of methods.

Fixed some abbreviation problems in classes and renamed
JUnit tests to fix this.

Issue-ID: POLICY-883
Change-Id: I8494f63d88d63c0232aca97f7bcc848816228fb1
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

116 files changed:

controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java		diff \| blob \| history
controlloop/common/actors/actor.so/src/test/java/org/onap/policy/controlloop/actor/so/SoActorServiceProviderTest.java	[moved from controlloop/common/actors/actor.so/src/test/java/org/onap/policy/controlloop/actor/so/TestSOActorServiceProvider.java with 98% similarity]	diff \| blob \| history
controlloop/common/actors/actor.vfc/src/test/java/org/onap/policy/controlloop/actor/vfc/VfcActorServiceProviderTest.java	[moved from controlloop/common/actors/actor.vfc/src/test/java/org/onap/policy/controlloop/actor/vfc/TestVFCActorServiceProvider.java with 97% similarity]	diff \| blob \| history
controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopEventManager.java		diff \| blob \| history
controlloop/common/eventmanager/src/test/java/org/onap/policy/controlloop/eventmanager/ControlLoopEventManagerTest.java		diff \| blob \| history
controlloop/common/eventmanager/src/test/java/org/onap/policy/controlloop/eventmanager/ControlLoopOperationManagerTest.java		diff \| blob \| history
controlloop/common/feature-controlloop-trans/src/main/java/org/onap/policy/drools/apps/controlloop/feature/trans/ControlLoopMetricsFeature.java		diff \| blob \| history
controlloop/common/guard/src/main/java/org/onap/policy/guard/PolicyGuardXacmlRequestAttributes.java		diff \| blob \| history
controlloop/common/guard/src/main/java/org/onap/policy/guard/impl/PNFTargetLock.java		diff \| blob \| history
controlloop/common/guard/src/test/java/org/onap/policy/guard/PipEngineGetHistoryTest.java	[moved from controlloop/common/guard/src/test/java/org/onap/policy/guard/PIPEngineGetHistoryTest.java with 99% similarity]	diff \| blob \| history
controlloop/common/guard/src/test/java/org/onap/policy/guard/PolicyGuardTest.java		diff \| blob \| history
controlloop/common/guard/src/test/resources/META-INF/persistence.xml		diff \| blob \| history
controlloop/common/guard/src/test/resources/blacklist_template.xml		diff \| blob \| history
controlloop/common/guard/src/test/resources/frequency_limiter_template.xml		diff \| blob \| history
controlloop/common/model-impl/aai/src/test/java/org/onap/policy/aai/AaiNqGenericVnfTest.java		diff \| blob \| history
controlloop/common/model-impl/aai/src/test/java/org/onap/policy/aai/AaiNqVfModuleTest.java		diff \| blob \| history
controlloop/common/model-impl/appc/pom.xml		diff \| blob \| history
controlloop/common/model-impl/appclcm/pom.xml		diff \| blob \| history
controlloop/common/model-impl/events/pom.xml		diff \| blob \| history
controlloop/common/model-impl/rest/src/main/java/org/onap/policy/rest/RESTManager.java		diff \| blob \| history
controlloop/common/model-impl/sdc/src/main/java/org/onap/policy/sdc/Resource.java		diff \| blob \| history
controlloop/common/model-impl/sdc/src/main/java/org/onap/policy/sdc/ResourceInstance.java		diff \| blob \| history
controlloop/common/model-impl/sdc/src/main/java/org/onap/policy/sdc/ResourceType.java		diff \| blob \| history
controlloop/common/model-impl/sdc/src/main/java/org/onap/policy/sdc/Service.java		diff \| blob \| history
controlloop/common/model-impl/sdc/src/main/java/org/onap/policy/sdc/ServiceInstance.java		diff \| blob \| history
controlloop/common/model-impl/sdc/src/test/java/org/onap/policy/sdc/TestResource.java		diff \| blob \| history
controlloop/common/model-impl/sdc/src/test/java/org/onap/policy/sdc/TestResourceInstance.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOAsyncRequestStatus.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOCloudConfiguration.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOInstanceReferences.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOManager.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOModelInfo.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOPolicyExceptionHolder.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORelatedInstance.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORelatedInstanceListElement.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORequest.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORequestDetails.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORequestError.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORequestInfo.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORequestParameters.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORequestReferences.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORequestStatus.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOResponse.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOResponseWrapper.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOServiceExceptionHolder.java		diff \| blob \| history
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOSubscriberInfo.java		diff \| blob \| history
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/DummyWorkingMemory.java		diff \| blob \| history
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoDummyServer.java		diff \| blob \| history
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoManager.java	[moved from controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSOManager.java with 99% similarity]	diff \| blob \| history
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoRequestDetails.java		diff \| blob \| history
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoResponseWrapper.java		diff \| blob \| history
controlloop/common/model-impl/trafficgenerator/src/main/java/org/onap/policy/vnf/trafficgenerator/PGRequest.java		diff \| blob \| history
controlloop/common/model-impl/trafficgenerator/src/main/java/org/onap/policy/vnf/trafficgenerator/PGStream.java		diff \| blob \| history
controlloop/common/model-impl/trafficgenerator/src/main/java/org/onap/policy/vnf/trafficgenerator/PGStreams.java		diff \| blob \| history
controlloop/common/model-impl/trafficgenerator/src/test/java/org/onap/policy/vnf/trafficgenerator/TestDemo.java		diff \| blob \| history
controlloop/common/model-impl/vfc/src/main/java/org/onap/policy/vfc/VFCHealActionVmInfo.java		diff \| blob \| history
controlloop/common/model-impl/vfc/src/main/java/org/onap/policy/vfc/VFCHealAdditionalParams.java		diff \| blob \| history
controlloop/common/model-impl/vfc/src/main/java/org/onap/policy/vfc/VFCHealRequest.java		diff \| blob \| history
controlloop/common/model-impl/vfc/src/main/java/org/onap/policy/vfc/VFCManager.java		diff \| blob \| history
controlloop/common/model-impl/vfc/src/main/java/org/onap/policy/vfc/VFCRequest.java		diff \| blob \| history
controlloop/common/model-impl/vfc/src/main/java/org/onap/policy/vfc/VFCResponse.java		diff \| blob \| history
controlloop/common/model-impl/vfc/src/main/java/org/onap/policy/vfc/VFCResponseDescriptor.java		diff \| blob \| history
controlloop/common/model-impl/vfc/src/main/java/org/onap/policy/vfc/util/Serialization.java		diff \| blob \| history
controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestDemo.java		diff \| blob \| history
controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCHealActionVmInfo.java	[deleted file]	blob \| history
controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCManager.java	[deleted file]	blob \| history
controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCResponseDescriptor.java	[deleted file]	blob \| history
controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVfcHealActionVmInfo.java	[moved from controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCResponse.java with 57% similarity]	diff \| blob \| history
controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVfcHealAdditionalParams.java	[moved from controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCHealRequest.java with 53% similarity]	diff \| blob \| history
controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVfcHealRequest.java	[new file with mode: 0644]	blob
controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVfcManager.java	[new file with mode: 0644]	blob
controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVfcRequest.java	[moved from controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCRequest.java with 52% similarity]	diff \| blob \| history
controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVfcResponse.java	[moved from controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVFCHealAdditionalParams.java with 51% similarity]	diff \| blob \| history
controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/TestVfcResponseDescriptor.java	[new file with mode: 0644]	blob
controlloop/common/model-impl/vfc/src/test/java/org/onap/policy/vfc/util/TestSerialization.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/compiler/ControlLoopCompiler.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/guard/compiler/ControlLoopGuardCompiler.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/ControlLoop.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/ControlLoopPolicy.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/FinalResult.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/OperationsAccumulateParams.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/Policy.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/PolicyResult.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/Target.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/builder/ControlLoopPolicyBuilder.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/builder/MessageLevel.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/builder/impl/ControlLoopPolicyBuilderImpl.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/guard/Constraint.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/guard/ControlLoopGuard.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/guard/Guard.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/guard/GuardPolicy.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/guard/MatchParameters.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/guard/builder/ControlLoopGuardBuilder.java		diff \| blob \| history
controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/guard/builder/impl/ControlLoopGuardBuilderImpl.java		diff \| blob \| history
controlloop/common/policy-yaml/src/test/java/org/onap/policy/controlloop/compiler/ControlLoopCompilerTest.java		diff \| blob \| history
controlloop/common/policy-yaml/src/test/java/org/onap/policy/controlloop/compiler/ControlLoopGuardCompilerTest.java		diff \| blob \| history
controlloop/common/policy-yaml/src/test/java/org/onap/policy/controlloop/policy/ControlLoopPolicyBuilderTest.java		diff \| blob \| history
controlloop/common/policy-yaml/src/test/java/org/onap/policy/controlloop/policy/ControlLoopPolicyTest.java		diff \| blob \| history
controlloop/common/policy-yaml/src/test/java/org/onap/policy/controlloop/policy/ControlLoopTest.java		diff \| blob \| history
controlloop/common/policy-yaml/src/test/java/org/onap/policy/controlloop/policy/OperationsAccumulateParamsTest.java		diff \| blob \| history
controlloop/common/policy-yaml/src/test/java/org/onap/policy/controlloop/policy/guard/ConstraintTest.java		diff \| blob \| history
controlloop/common/policy-yaml/src/test/java/org/onap/policy/controlloop/policy/guard/ControlLoopGuardBuilderTest.java		diff \| blob \| history
controlloop/common/policy-yaml/src/test/java/org/onap/policy/controlloop/policy/guard/ControlLoopGuardTest.java		diff \| blob \| history
controlloop/common/policy-yaml/src/test/java/org/onap/policy/controlloop/policy/guard/GuardPolicyTest.java		diff \| blob \| history
controlloop/common/simulators/src/test/java/org/onap/policy/simulators/SoSimulatorTest.java		diff \| blob \| history
controlloop/templates/template.demo/src/main/resources/blacklist_template.xml		diff \| blob \| history
controlloop/templates/template.demo/src/main/resources/frequency_limiter_template.xml		diff \| blob \| history
controlloop/templates/template.demo/src/main/resources/frequency_limiter_template_old.xml		diff \| blob \| history
controlloop/templates/template.demo/src/test/java/org/onap/policy/template/demo/ControlLoopFailureTest.java		diff \| blob \| history
controlloop/templates/template.demo/src/test/java/org/onap/policy/template/demo/Util.java		diff \| blob \| history
controlloop/templates/template.demo/src/test/java/org/onap/policy/template/demo/VcpeControlLoopTest.java	[moved from controlloop/templates/template.demo/src/test/java/org/onap/policy/template/demo/VCPEControlLoopTest.java with 92% similarity]	diff \| blob \| history
controlloop/templates/template.demo/src/test/java/org/onap/policy/template/demo/VdnsControlLoopTest.java	[moved from controlloop/templates/template.demo/src/test/java/org/onap/policy/template/demo/VDNSControlLoopTest.java with 91% similarity]	diff \| blob \| history
controlloop/templates/template.demo/src/test/java/org/onap/policy/template/demo/VfcControlLoopTest.java	[moved from controlloop/templates/template.demo/src/test/java/org/onap/policy/template/demo/VFCControlLoopTest.java with 91% similarity]	diff \| blob \| history
controlloop/templates/template.demo/src/test/java/org/onap/policy/template/demo/VfwControlLoopTest.java	[moved from controlloop/templates/template.demo/src/test/java/org/onap/policy/template/demo/VFWControlLoopTest.java with 92% similarity]	diff \| blob \| history
controlloop/templates/template.demo/src/test/resources/META-INF/persistence.xml		diff \| blob \| history
pom.xml		diff \| blob \| history

Code for building policies/rules for the Drools PDP engine.

RSS Atom