clamp sonar fix on runtime dir 63/123363/9
authorTaka Cho <takamune.cho@att.com>
Wed, 18 Aug 2021 19:30:52 +0000 (15:30 -0400)
committerTaka Cho <takamune.cho@att.com>
Mon, 23 Aug 2021 19:48:18 +0000 (15:48 -0400)
commit770410bd0e5a21576c2a31ee733d9b7d2dec4c7e
treea28406cb5b2ee698e20bfd28511cb49df19fd04a
parentbf06e83f40cdbfcfc1428040bf8fa58a518cdea4
clamp sonar fix on runtime dir

- most of fixes are changed to "var"
- Exceptions should be either logged or rethrown but not both
- Ternary operators should not be nested
- "String#replace" should be preferred to "String#replaceAll"
- Annotation repetitions should not be wrapped
- "throws" declarations should not be superfluous

Issue-ID: POLICY-3452
Change-Id: I8894539aa25a8271410fe79c8d898a45a7a4db31
Signed-off-by: Taka Cho <takamune.cho@att.com>
55 files changed:
runtime/src/main/java/org/onap/policy/clamp/authorization/AuthorizationController.java
runtime/src/main/java/org/onap/policy/clamp/clds/Application.java
runtime/src/main/java/org/onap/policy/clamp/clds/ClampServlet.java
runtime/src/main/java/org/onap/policy/clamp/clds/TomcatEmbeddedServletContainerFactoryRedirection.java
runtime/src/main/java/org/onap/policy/clamp/clds/client/CdsServices.java
runtime/src/main/java/org/onap/policy/clamp/clds/client/DcaeInventoryServices.java
runtime/src/main/java/org/onap/policy/clamp/clds/config/ClampProperties.java
runtime/src/main/java/org/onap/policy/clamp/clds/config/DefaultDictionaryElements.java
runtime/src/main/java/org/onap/policy/clamp/clds/config/DefaultUserConfiguration.java
runtime/src/main/java/org/onap/policy/clamp/clds/config/SslConfig.java
runtime/src/main/java/org/onap/policy/clamp/clds/config/sdc/SdcControllersConfiguration.java
runtime/src/main/java/org/onap/policy/clamp/clds/config/sdc/SdcSingleControllerConfiguration.java
runtime/src/main/java/org/onap/policy/clamp/clds/config/spring/CldsConfiguration.java
runtime/src/main/java/org/onap/policy/clamp/clds/config/spring/SdcControllerConfiguration.java
runtime/src/main/java/org/onap/policy/clamp/clds/filter/ClampCadiFilter.java
runtime/src/main/java/org/onap/policy/clamp/clds/model/cds/CdsBpWorkFlowListResponse.java
runtime/src/main/java/org/onap/policy/clamp/clds/model/dcae/DcaeInventoryResponse.java
runtime/src/main/java/org/onap/policy/clamp/clds/sdc/controller/SdcSingleController.java
runtime/src/main/java/org/onap/policy/clamp/clds/sdc/controller/installer/BlueprintParser.java
runtime/src/main/java/org/onap/policy/clamp/clds/sdc/controller/installer/ChainGenerator.java
runtime/src/main/java/org/onap/policy/clamp/clds/sdc/controller/installer/CsarHandler.java
runtime/src/main/java/org/onap/policy/clamp/clds/service/CldsHealthcheckService.java
runtime/src/main/java/org/onap/policy/clamp/clds/tosca/JsonEditorSchemaConstants.java
runtime/src/main/java/org/onap/policy/clamp/clds/tosca/ToscaSchemaConstants.java
runtime/src/main/java/org/onap/policy/clamp/clds/tosca/update/elements/ArrayField.java
runtime/src/main/java/org/onap/policy/clamp/clds/tosca/update/execution/ToscaMetadataExecutor.java
runtime/src/main/java/org/onap/policy/clamp/clds/tosca/update/execution/cds/ToscaMetadataCdsProcess.java
runtime/src/main/java/org/onap/policy/clamp/clds/tosca/update/templates/JsonTemplateField.java
runtime/src/main/java/org/onap/policy/clamp/clds/util/ClampVersioning.java
runtime/src/main/java/org/onap/policy/clamp/clds/util/OnapLogConstants.java
runtime/src/main/java/org/onap/policy/clamp/loop/LoopService.java
runtime/src/main/java/org/onap/policy/clamp/loop/cds/CdsDataInstaller.java
runtime/src/main/java/org/onap/policy/clamp/loop/common/AuditEntity.java
runtime/src/main/java/org/onap/policy/clamp/loop/components/external/ExternalComponentState.java
runtime/src/main/java/org/onap/policy/clamp/loop/components/external/PolicyComponent.java
runtime/src/main/java/org/onap/policy/clamp/loop/log/LoopLog.java
runtime/src/main/java/org/onap/policy/clamp/loop/service/CsarServiceInstaller.java
runtime/src/main/java/org/onap/policy/clamp/loop/service/Service.java
runtime/src/main/java/org/onap/policy/clamp/loop/template/LoopElementModel.java
runtime/src/main/java/org/onap/policy/clamp/loop/template/LoopTemplate.java
runtime/src/main/java/org/onap/policy/clamp/loop/template/LoopTemplateLoopElementModel.java
runtime/src/main/java/org/onap/policy/clamp/loop/template/PolicyModel.java
runtime/src/main/java/org/onap/policy/clamp/loop/template/PolicyModelsService.java
runtime/src/main/java/org/onap/policy/clamp/policy/Policy.java
runtime/src/main/java/org/onap/policy/clamp/policy/PolicyEngineServices.java
runtime/src/main/java/org/onap/policy/clamp/policy/PolicyPayload.java
runtime/src/main/java/org/onap/policy/clamp/policy/microservice/MicroServicePolicy.java
runtime/src/main/java/org/onap/policy/clamp/policy/operational/OperationalPolicy.java
runtime/src/main/java/org/onap/policy/clamp/policy/operational/OperationalPolicyRepresentationBuilder.java
runtime/src/main/java/org/onap/policy/clamp/policy/operational/OperationalPolicyService.java
runtime/src/main/java/org/onap/policy/clamp/policy/pdpgroup/PdpGroupPayload.java
runtime/src/main/java/org/onap/policy/clamp/policy/pdpgroup/PoliciesPdpMerger.java
runtime/src/main/java/org/onap/policy/clamp/tosca/DictionaryElement.java
runtime/src/main/java/org/onap/policy/clamp/tosca/DictionaryService.java
runtime/src/main/java/org/onap/policy/clamp/util/SemanticVersioning.java