Code Review / policy / drools-pdp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 5c71b5a) | patch
Address more sonars in drools-pdp 20/111720/1
authorJim Hahn <jrh3@att.com>
Tue, 25 Aug 2020 21:05:37 +0000 (17:05 -0400)
committerJim Hahn <jrh3@att.com>
Tue, 25 Aug 2020 22:47:23 +0000 (18:47 -0400)
commit72cf248dced4e272e69a8c48f5ee24c9d345f41d
treeb09ed0f9b7ee7aac6493119d950d78d50ae08da1tree | snapshot
parent5c71b5a62f4208030b3c3cd18b3f42398a0a86e5commit | diff
Address more sonars in drools-pdp

Addressed the following sonars:
- either log or rethrow
- call "remove()" for thread-local-storage
- use assertEquals
- only one method call in exception test
- swap arguments in assertEquals
- add assertion to assertThatThrownBy()
- explain @Ignore

Also addressed eclipse warnings:
- unused fields and methods

Issue-ID: POLICY-2616
Change-Id: I6590c0d2b103885bc933014d48bf5fd92401cd80
Signed-off-by: Jim Hahn <jrh3@att.com>
17 files changed:
feature-lifecycle/src/test/java/org/onap/policy/drools/lifecycle/LifecycleStateUnsupportedTest.java diff | blob | history
feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/DmaapManagerTest.java diff | blob | history
feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/EndToEndFeatureTest.java diff | blob | history
feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/SerializerTest.java diff | blob | history
feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/state/ProcessingStateTest.java diff | blob | history
feature-session-persistence/src/main/java/org/onap/policy/drools/persistence/PersistenceFeature.java diff | blob | history
feature-session-persistence/src/test/java/org/onap/policy/drools/persistence/PersistenceFeatureTest.java diff | blob | history
feature-state-management/src/test/java/org/onap/policy/drools/statemanagement/test/StateManagementTest.java diff | blob | history
policy-core/src/main/java/org/onap/policy/drools/core/PolicySession.java diff | blob | history
policy-core/src/test/java/org/onap/policy/drools/core/PolicySessionTest.java diff | blob | history
policy-domains/src/test/java/org/onap/policy/drools/domain/models/DomainPolicyTypesTest.java diff | blob | history
policy-management/src/main/java/org/onap/policy/drools/system/Main.java diff | blob | history
policy-management/src/test/java/org/onap/policy/drools/protocol/configuration/ControllerConfigurationTest.java diff | blob | history
policy-management/src/test/java/org/onap/policy/drools/protocol/configuration/DroolsConfigurationTest.java diff | blob | history
policy-management/src/test/java/org/onap/policy/drools/protocol/configuration/PdpdConfigurationTest.java diff | blob | history
policy-utils/src/test/java/org/onap/policy/drools/policies/DomainMakerTest.java diff | blob | history
policy-utils/src/test/java/org/onap/policy/drools/utils/logging/MdcTransactionTest.java diff | blob | history
The Drools PDP engine.