Code Review / policy / models.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: f59ec39) | patch
Fix more sonar issues in models: yaml to dao 36/89936/6
authorJim Hahn <jrh3@att.com>
Thu, 13 Jun 2019 22:18:39 +0000 (18:18 -0400)
committerJim Hahn <jrh3@att.com>
Mon, 17 Jun 2019 18:53:51 +0000 (14:53 -0400)
commit6347aed1148a9fab8f7f45e46be71b8bdfc52924
tree36b02ba338e7a17160347360a2dee03596bfb21dtree | snapshot
parentf59ec395bf1e41df894f884e70ff3185280668c0commit | diff
Fix more sonar issues in models: yaml to dao

Extracted common Strings into constants.
Reduced "cyclomatic complexity" in some return statements.
Used assertj to eliminate "log or rethrow" messages in junit tests.

models-yaml
models-base
models-dao

Change-Id: I20548d4cf5e67d085245e0d54df8ba0116ec86ec
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
37 files changed:
models-base/src/test/java/org/onap/policy/models/base/ExceptionsTest.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/ModelServiceTest.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/PfConceptContainerTest.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/PfConceptGetterImplTest.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/PfKeyTest.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/PfKeyUseTest.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/PfModelTest.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/PfObjectFilterTest.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/PfReferenceKeyTest.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/PfUtilsTest.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/ValidatedTest.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/ValidationTest.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/testconcepts/DummyPfConcept.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/testconcepts/DummyPfKey.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/testconcepts/DummyPfModel.java diff | blob | history
models-base/src/test/java/org/onap/policy/models/base/testconcepts/DummyPfNameVersion.java diff | blob | history
models-dao/src/test/java/org/onap/policy/models/dao/DaoMiscTest.java diff | blob | history
models-dao/src/test/java/org/onap/policy/models/dao/DummyReferenceEntity.java diff | blob | history
models-dao/src/test/java/org/onap/policy/models/dao/EntityTest.java diff | blob | history
models-interactions/model-yaml/src/main/java/org/onap/policy/controlloop/compiler/ControlLoopCompiler.java diff | blob | history
models-interactions/model-yaml/src/main/java/org/onap/policy/controlloop/policy/ControlLoop.java diff | blob | history
models-interactions/model-yaml/src/main/java/org/onap/policy/controlloop/policy/Policy.java diff | blob | history
models-interactions/model-yaml/src/main/java/org/onap/policy/controlloop/policy/Target.java diff | blob | history
models-interactions/model-yaml/src/main/java/org/onap/policy/controlloop/policy/guard/ControlLoopGuard.java diff | blob | history
models-interactions/model-yaml/src/main/java/org/onap/policy/controlloop/policy/guard/GuardPolicy.java diff | blob | history
models-interactions/model-yaml/src/main/java/org/onap/policy/controlloop/policy/guard/builder/impl/ControlLoopGuardBuilderImpl.java diff | blob | history
models-interactions/model-yaml/src/test/java/org/onap/policy/controlloop/compiler/CompilerExceptionTest.java diff | blob | history
models-interactions/model-yaml/src/test/java/org/onap/policy/controlloop/compiler/ControlLoopCompilerTest.java diff | blob | history
models-interactions/model-yaml/src/test/java/org/onap/policy/controlloop/compiler/ControlLoopGuardCompilerTest.java diff | blob | history
models-interactions/model-yaml/src/test/java/org/onap/policy/controlloop/policy/ControlLoopPolicyBuilderTest.java diff | blob | history
models-interactions/model-yaml/src/test/java/org/onap/policy/controlloop/policy/ControlLoopPolicyTest.java diff | blob | history
models-interactions/model-yaml/src/test/java/org/onap/policy/controlloop/policy/ControlLoopTest.java diff | blob | history
models-interactions/model-yaml/src/test/java/org/onap/policy/controlloop/policy/guard/ConstraintTest.java diff | blob | history
models-interactions/model-yaml/src/test/java/org/onap/policy/controlloop/policy/guard/ControlLoopGuardBuilderTest.java diff | blob | history
models-interactions/model-yaml/src/test/java/org/onap/policy/controlloop/policy/guard/ControlLoopGuardTest.java diff | blob | history
models-interactions/model-yaml/src/test/java/org/onap/policy/controlloop/policy/guard/GuardPolicyTest.java diff | blob | history
models-interactions/model-yaml/src/test/resources/v1.0.0/test_evil.yaml diff | blob | history
This repo will hold model code agnostic to PDP engines (Casablanca)