gerrit.onap Code Review - policy/common.git/commit

Code Review / policy / common.git / commit

author	Jim Hahn <jrh3@att.com>
	Wed, 17 Jun 2020 12:37:15 +0000 (08:37 -0400)
committer	Jim Hahn <jrh3@att.com>
	Wed, 17 Jun 2020 15:45:16 +0000 (11:45 -0400)
commit	611f63a4bb71d677cf2665b1794e91148ba42a51
tree	c6f82e5ffcd10712e0279c40bf8e59ed49f2332e	tree \| snapshot
parent	3bd6679bd7d8f67b4827a610c25ed9671b74d89c	commit \| diff

Cleanup various sonar issues in policy-common

Addressed the following issues:
- unused imports
- unused method parameters
- use assertEquals, assertSame instead of assertTrue
- provide the parametrized type for this generic

Also fixed some checkstyle issues:
- removed blank lines between "import" groups

Issue-ID: POLICY-2650
Change-Id: I004bb650ac10c49ccd0fc405f6959896fec39f9b
Signed-off-by: Jim Hahn <jrh3@att.com>

60 files changed:

common-logging/src/main/java/org/onap/policy/common/logging/OnapLoggingContext.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/eelf/PolicyLogger.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/EelfLogger.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/FlexLogger.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/Logger.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/SystemOutLogger.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/nsa/impl/SharedContext.java		diff \| blob \| history
common-logging/src/test/java/org/onap/policy/common/logging/eelf/EventDataTest.java		diff \| blob \| history
common-logging/src/test/java/org/onap/policy/common/logging/eelf/EventTrackInfoHandlerTest.java		diff \| blob \| history
common-logging/src/test/java/org/onap/policy/common/logging/eelf/EventTrackInfoTest.java		diff \| blob \| history
common-logging/src/test/java/org/onap/policy/common/logging/eelf/PolicyLoggerTest.java		diff \| blob \| history
common-logging/src/test/java/org/onap/policy/common/logging/flexlogger/FlexLoggerTest.java		diff \| blob \| history
common-logging/src/test/java/org/onap/policy/common/logging/flexlogger/SystemOutLoggerTest.java		diff \| blob \| history
common-parameters/src/test/java/org/onap/policy/common/parameters/ExceptionTest.java		diff \| blob \| history
gson/src/main/java/org/onap/policy/common/gson/internal/Adapter.java		diff \| blob \| history
integrity-audit/src/main/java/org/onap/policy/common/ia/DbDao.java		diff \| blob \| history
integrity-audit/src/main/java/org/onap/policy/common/ia/jpa/IntegrityAuditEntity.java		diff \| blob \| history
integrity-audit/src/test/java/org/onap/policy/common/ia/DbAuditCompareEntriesTest.java		diff \| blob \| history
integrity-audit/src/test/java/org/onap/policy/common/ia/DbAuditTest.java		diff \| blob \| history
integrity-audit/src/test/java/org/onap/policy/common/ia/DbDaoTest.java		diff \| blob \| history
integrity-audit/src/test/java/org/onap/policy/common/ia/DefaultLoggingPatternTest.java		diff \| blob \| history
integrity-audit/src/test/java/org/onap/policy/common/ia/IntegrityAuditTest.java		diff \| blob \| history
integrity-audit/src/test/java/org/onap/policy/common/ia/jpa/IaTestEntity.java		diff \| blob \| history
integrity-monitor/src/main/java/org/onap/policy/common/im/IntegrityMonitor.java		diff \| blob \| history
integrity-monitor/src/main/java/org/onap/policy/common/im/jmx/ComponentAdmin.java		diff \| blob \| history
integrity-monitor/src/main/java/org/onap/policy/common/im/jpa/ForwardProgressEntity.java		diff \| blob \| history
integrity-monitor/src/main/java/org/onap/policy/common/im/jpa/ImTestEntity.java		diff \| blob \| history
integrity-monitor/src/main/java/org/onap/policy/common/im/jpa/ResourceRegistrationEntity.java		diff \| blob \| history
integrity-monitor/src/main/java/org/onap/policy/common/im/jpa/StateManagementEntity.java		diff \| blob \| history
integrity-monitor/src/test/java/org/onap/policy/common/im/StateManagementEntityTest.java		diff \| blob \| history
integrity-monitor/src/test/java/org/onap/policy/common/im/StateManagementTest.java		diff \| blob \| history
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/Topic.java		diff \| blob \| history
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineBusTopicSink.java		diff \| blob \| history
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineDmaapTopicSink.java		diff \| blob \| history
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/SingleThreadedBusTopicSource.java		diff \| blob \| history
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/SingleThreadedDmaapTopicSource.java		diff \| blob \| history
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/TopicBase.java		diff \| blob \| history
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/http/client/HttpClient.java		diff \| blob \| history
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/parameters/RestServerParameters.java		diff \| blob \| history
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/TopicEndpointProxyTest.java		diff \| blob \| history
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/BusTopicFactoryTestBase.java		diff \| blob \| history
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/NoopTopicEndpointTest.java		diff \| blob \| history
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/TopicFactoryTestBase.java		diff \| blob \| history
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/http/server/test/HttpServerTest.java		diff \| blob \| history
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/http/server/test/MyJacksonProvider.java		diff \| blob \| history
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/http/server/test/RestEndpoints.java		diff \| blob \| history
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/report/TestHealthCheckReport.java		diff \| blob \| history
utils-test/src/main/java/org/onap/policy/common/utils/test/ThrowablesTester.java		diff \| blob \| history
utils-test/src/main/java/org/onap/policy/common/utils/test/ToStringTester.java		diff \| blob \| history
utils-test/src/test/java/org/onap/policy/common/utils/test/log/logback/ExtractAppenderTest.java		diff \| blob \| history
utils/src/main/java/org/onap/policy/common/utils/resources/ResourceUtils.java		diff \| blob \| history
utils/src/main/java/org/onap/policy/common/utils/services/OrderedServiceImpl.java		diff \| blob \| history
utils/src/test/java/org/onap/policy/common/utils/coder/PropertyCoderTest.java		diff \| blob \| history
utils/src/test/java/org/onap/policy/common/utils/jpa/EntityMgrCloserTest.java		diff \| blob \| history
utils/src/test/java/org/onap/policy/common/utils/jpa/EntityMgrFactoryCloserTest.java		diff \| blob \| history
utils/src/test/java/org/onap/policy/common/utils/jpa/EntityTransCloserTest.java		diff \| blob \| history
utils/src/test/java/org/onap/policy/common/utils/network/NetworkUtilTest.java		diff \| blob \| history
utils/src/test/java/org/onap/policy/common/utils/resources/ResourceUtilsTest.java		diff \| blob \| history
utils/src/test/java/org/onap/policy/common/utils/resources/TextFileUtilsTest.java		diff \| blob \| history
utils/src/test/java/org/onap/policy/common/utils/validation/VersionTest.java		diff \| blob \| history

Policy common shared modules

RSS Atom