Fix more sonars in feature-server-pool 97/112897/1
authorJim Hahn <jrh3@att.com>
Fri, 18 Sep 2020 15:48:06 +0000 (11:48 -0400)
committerJim Hahn <jrh3@att.com>
Fri, 18 Sep 2020 16:44:21 +0000 (12:44 -0400)
commit5c2ca039b4e57adcb0b6bf784aa0acbabf434682
tree3beae8ba52b9f3427d1a47f86b6c3d949aa925b7
parent1060c43fdb310bc380ff424a273aa882765517b5
Fix more sonars in feature-server-pool

Addressed the following sonars:
- move fields from "interface" to "class"
- don't always return the same value
- remove commented-out code
- make constants "final"
- don't synchronize on parameters

Issue-ID: POLICY-2546
Change-Id: If2d410664d956a7efabf3a4dbef96bbf7d24de5e
Signed-off-by: Jim Hahn <jrh3@att.com>
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/Bucket.java
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/Events.java
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/FeatureServerPool.java
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/Leader.java
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/Server.java
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/ServerPoolApi.java
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/TargetLock.java
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/persistence/Persistence.java