Resolve critical sonarqube issues 70/141670/2
authorFiete Ostkamp <Fiete.Ostkamp@telekom.de>
Mon, 11 Aug 2025 07:18:41 +0000 (09:18 +0200)
committerFiete Ostkamp <Fiete.Ostkamp@telekom.de>
Mon, 11 Aug 2025 08:07:08 +0000 (10:07 +0200)
commit585c305ee63556db5ba03187cf27274d3a2e8a54
treeeed125724ce437e10804f0caad0cbe85ebedd664
parent9861cd78ebbd0a9bfbc935c9318a7ccf9cb5bb41
Resolve critical sonarqube issues

- add path validation for test-only controller
  (was not a real vulnerability)
- prevent resource leaks in ZipParser and Onap3gppServiceInstances classes
- add tests for ZipParser
- align packages of test classes to match the classes they are testing
  (move org.onap.asdc.activity test classes to org.onap.so.asdc.activity)

Issue-ID: SO-4222
Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
Change-Id: I89dc950ee158989d867d4b2a0ccb813767b0d51b
adapters/mso-adapter-utils/src/main/java/org/onap/so/openstack/utils/MsoMulticloudUtils.java
adapters/mso-catalog-db-adapter/src/main/java/org/onap/so/adapters/catalogdb/catalogrest/QueryServiceInfo.java
asdc-controller/src/main/java/org/onap/so/asdc/client/test/rest/ASDCRestInterface.java
asdc-controller/src/main/java/org/onap/so/asdc/util/ZipParser.java
asdc-controller/src/test/java/org/onap/so/asdc/activity/ActivitySpecsActionsTest.java [moved from asdc-controller/src/test/java/org/onap/asdc/activity/ActivitySpecsActionsTest.java with 98% similarity]
asdc-controller/src/test/java/org/onap/so/asdc/activity/DeployActivitySpecsITTest.java [moved from asdc-controller/src/test/java/org/onap/asdc/activity/DeployActivitySpecsITTest.java with 98% similarity]
asdc-controller/src/test/java/org/onap/so/asdc/activity/DeployActivitySpecsTest.java [moved from asdc-controller/src/test/java/org/onap/asdc/activity/DeployActivitySpecsTest.java with 96% similarity]
asdc-controller/src/test/java/org/onap/so/asdc/client/test/rest/ASDCRestInterfaceTest.java
asdc-controller/src/test/java/org/onap/so/asdc/util/ZipParserTest.java [new file with mode: 0644]
mso-api-handlers/mso-api-handler-infra/src/main/java/org/onap/so/apihandlerinfra/Onap3gppServiceInstances.java