fix new sonar issues with prov-status check 63/60963/3
authorJim Hahn <jrh3@att.com>
Thu, 16 Aug 2018 18:57:15 +0000 (14:57 -0400)
committerJim Hahn <jrh3@att.com>
Fri, 17 Aug 2018 14:23:28 +0000 (10:23 -0400)
commit48eb8e2bd1674592ddfadfbbc01a611b6a263393
tree76a8e093afee41e5623aac7a490d3ebe05664176
parenta9b2b1d16797fefa4c7be8ba0bf01f0fdab22b7b
fix new sonar issues with prov-status check

Changes made while adding the prov-status check triggered some sonar
thresholds in ControlLoopEventManager.  Updated the code to resolve
them.  One of the changes that had been introduced was to check for
the existence of both the is-closed-loop-disabled AND the prov-status
fields.  However, if one is there then the other should be there, thus
the second check is redundant and was removed, which should reduce the
cyclomatic complexity back under the threshold.
Re-ordered the code a little, to make it less ambiguous.
Removed trailing white space.

Change-Id: If0ce74cedbf947c32cae3df3374cda6ba1305cd2
Issue-ID: POLICY-964
Signed-off-by: Jim Hahn <jrh3@att.com>
controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopEventManager.java