Handle stream error early 40/72040/6
authorFilip Krzywka <filip.krzywka@nokia.com>
Wed, 7 Nov 2018 07:16:09 +0000 (08:16 +0100)
committerFilip Krzywka <filip.krzywka@nokia.com>
Tue, 13 Nov 2018 12:14:16 +0000 (13:14 +0100)
commit3fdd2fe2b4f35e18998d050c632fc6de24a7e3b1
tree5b75879d2b1c5bfdd6b2c923ffa570f965bc0e70
parentd1abb8c3e7c20495ca8a953b175a9810a5b73671
Handle stream error early

Should fix inconsistent logging due to Reactor Signal sometimes
propagating from WireChunkDecoder stream to VesHvCollector stream as
Signal.CANCEL instead of Signal.ERROR and thus not being handled
correctly.
As a drawback however we will log error twice in case it comes from
WireChunkDecoder as we want to terminate connection in such case and
so we need to propagate error.

In WireChunkDecoder `doOnTerminate` was changed to
`doFinally` as this method handles also cancellation
signals and not only terminal signals.

Also fixed minor checkstyle reported issues.

Change-Id: I6e91d96c5a1a3ecf30603db9a71e032c770d507f
Issue-ID: DCAEGEN2-955
Signed-off-by: Filip Krzywka <filip.krzywka@nokia.com>
hv-collector-core/src/main/kotlin/org/onap/dcae/collectors/veshv/impl/VesHvCollector.kt
hv-collector-core/src/main/kotlin/org/onap/dcae/collectors/veshv/impl/socket/NettyTcpServer.kt
hv-collector-core/src/main/kotlin/org/onap/dcae/collectors/veshv/impl/wire/WireChunkDecoder.kt
hv-collector-utils/src/main/kotlin/org/onap/dcae/collectors/veshv/utils/commandline/extensions.kt
hv-collector-utils/src/main/kotlin/org/onap/dcae/collectors/veshv/utils/logging/reactive_logging.kt [new file with mode: 0644]