Remove GroupValidationResult 15/120915/5
authorJim Hahn <jrh3@att.com>
Mon, 26 Apr 2021 21:41:25 +0000 (17:41 -0400)
committerJim Hahn <jrh3@att.com>
Thu, 29 Apr 2021 15:30:24 +0000 (11:30 -0400)
commit3b00f1c32b89282dcbb74d3d3645e263f005319e
treea760975aaf1975905db7069d6d733e7e77b0f797
parent322b149685bb2f9405999f5a299130694d1b8fe3
Remove GroupValidationResult

Removed GroupValidationResult, replacing it with BeanValidationResult.
Modified the ParameterGroup subclasses to use BeanValidator, adding
annotations where needed to trigger the validations that had been
automatically performed by GroupValidationResult.
Added Size annotation, used to verify minimum lengths of maps and
collections.
Added ClassName annotation, used to verify that a property contains the
name of a class that is actually in the classpath.
Added another addResult() method to make it easier when replacing calls
to GroupValidationResult setResult() method with BeanValidationResult.

Issue-ID: POLICY-2059
Change-Id: Id4da24886908723006624c5d53edeb034102299d
Signed-off-by: Jim Hahn <jrh3@att.com>
46 files changed:
common-parameters/src/main/java/org/onap/policy/common/parameters/BeanValidationResult.java
common-parameters/src/main/java/org/onap/policy/common/parameters/BeanValidator.java
common-parameters/src/main/java/org/onap/policy/common/parameters/CommonGroupValidationResult.java [deleted file]
common-parameters/src/main/java/org/onap/policy/common/parameters/GroupMapValidationResult.java [deleted file]
common-parameters/src/main/java/org/onap/policy/common/parameters/GroupValidationResult.java [deleted file]
common-parameters/src/main/java/org/onap/policy/common/parameters/ObjectValidationResult.java
common-parameters/src/main/java/org/onap/policy/common/parameters/ParameterGroup.java
common-parameters/src/main/java/org/onap/policy/common/parameters/ParameterGroupImpl.java
common-parameters/src/main/java/org/onap/policy/common/parameters/annotations/ClassName.java [moved from common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupMissingGetter.java with 56% similarity]
common-parameters/src/main/java/org/onap/policy/common/parameters/annotations/Size.java [moved from common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithNullCollection.java with 54% similarity]
common-parameters/src/test/java/org/onap/policy/common/parameters/TestAbstractParameters.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/TestBeanValidationResult.java
common-parameters/src/test/java/org/onap/policy/common/parameters/TestBeanValidator.java
common-parameters/src/test/java/org/onap/policy/common/parameters/TestJsonInput.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/TestParameterService.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/TestValidation.java
common-parameters/src/test/java/org/onap/policy/common/parameters/TestValidationErrors.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/TestValidationResults.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/TestYamlInput.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/EmptyParameterGroup.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupPrivateGetter.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithArray.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithCollection.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithIllegalMapKey.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithIllegalMapValue.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithNullMapValue.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithNullSubGroup.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithParameterGroupCollection.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersL00.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersL10.java [deleted file]
common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersLGeneric.java [deleted file]
common-parameters/src/test/resources/expectedValidationResults/TestJsonYamlValidationResult.txt [deleted file]
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_0_OK.txt [deleted file]
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_1_Invalid.txt [deleted file]
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_1_Observation.txt [deleted file]
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_1_Warning.txt [deleted file]
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_2_Invalid.txt [deleted file]
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_2_Observation.txt [deleted file]
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_2_Warning.txt [deleted file]
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_3_Invalid.txt [deleted file]
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_3_Observation.txt [deleted file]
common-parameters/src/test/resources/expectedValidationResults/TestParametersL0_3_Warning.txt [deleted file]
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/parameters/RestServerParameters.java
policy-endpoints/src/main/java/org/onap/policy/common/endpoints/parameters/TopicParameterGroup.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/parameters/RestServerParametersTest.java
policy-endpoints/src/test/java/org/onap/policy/common/endpoints/parameters/TopicParameterGroupTest.java