Code Review / policy / models.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 9f0fbd0) | patch
Remove more duplicate code from models 94/117994/1
authorJim Hahn <jrh3@att.com>
Wed, 17 Feb 2021 19:27:03 +0000 (14:27 -0500)
committerJim Hahn <jrh3@att.com>
Wed, 17 Feb 2021 19:29:29 +0000 (14:29 -0500)
commit1f7ddcb95f4de6fc7a05d7a74d95a5f6bd41f9c5
tree6b698b16df2e5617d5e0e52ecdf0077e7919d3e5tree | snapshot
parent9f0fbd02f184071c2de30c944bec311741e6180ecommit | diff
Remove more duplicate code from models

Addressed sonar "duplicate code" issue by extracting a common
ToscaNameVersion class from the XxxIdentifier classes.
Also removed junit test for class that no longer exists and renamed
another junit to match the renaming of the class being tested.

Issue-ID: POLICY-2905
Change-Id: I4a28cd7de2478f2771a864439c0b440ad8310299
Signed-off-by: Jim Hahn <jrh3@att.com>
models-tosca/src/main/java/org/onap/policy/models/tosca/authorative/concepts/ToscaConceptIdentifier.java diff | blob | history
models-tosca/src/main/java/org/onap/policy/models/tosca/authorative/concepts/ToscaConceptIdentifierOptVersion.java diff | blob | history
models-tosca/src/main/java/org/onap/policy/models/tosca/authorative/concepts/ToscaNameVersion.java [new file with mode: 0644] blob
models-tosca/src/test/java/org/onap/policy/models/tosca/authorative/concepts/ToscaConceptIdentifierTest.java [moved from models-tosca/src/test/java/org/onap/policy/models/tosca/authorative/concepts/ToscaPolicyConceptIdentifierTest.java with 94% similarity] diff | blob | history
models-tosca/src/test/java/org/onap/policy/models/tosca/authorative/concepts/ToscaNameVersionTest.java [new file with mode: 0644] blob
models-tosca/src/test/java/org/onap/policy/models/tosca/authorative/concepts/ToscaPolicyTypeConceptIdentifierTest.java [deleted file] blob | history
This repo will hold model code agnostic to PDP engines (Casablanca)