gerrit.onap Code Review - so.git/commit

author	Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
	Mon, 11 Aug 2025 12:07:49 +0000 (14:07 +0200)
committer	Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
	Mon, 11 Aug 2025 12:07:49 +0000 (14:07 +0200)
commit	16f2655b2d202624f4e3482dbe971e55cd34d048
tree	c8860120c9f1d2d333d5081bcc2377ecd14f24b6	tree \| snapshot
parent	585c305ee63556db5ba03187cf27274d3a2e8a54	commit \| diff

Make sure all tests have assertions

- sonarqube requires all tests to have assertions
- use assertDoesNotThrow for void methods and openpojo
validations
- fix some hamcrest assertions
- delete some getter and setter tests

Issue-ID: SO-4223
Signed-off-by: Fiete Ostkamp <Fiete.Ostkamp@telekom.de>
Change-Id: Ib6acbbf71401e7a8565ddeb5ea6d61668b9c6cbf

42 files changed:

adapters/mso-openstack-adapters/src/test/java/org/onap/so/adapters/network/MSONetworkAdapterImplTest.java		diff \| blob \| history
adapters/so-appc-orchestrator/src/test/java/org/onap/so/adapters/appc/orchestrator/service/ApplicationControllerTaskImplTest.java		diff \| blob \| history
asdc-controller/src/test/java/org/onap/so/asdc/client/ASDCStatusCallBackTest.java		diff \| blob \| history
asdc-controller/src/test/java/org/onap/so/asdc/installer/bpmn/BpmnInstallerTest.java		diff \| blob \| history
asdc-controller/src/test/java/org/onap/so/asdc/installer/heat/ToscaResourceInstallerTest.java		diff \| blob \| history
bpmn/MSOCommonBPMN/src/test/java/org/onap/so/bpmn/common/recipe/BpmnParamTest.java		diff \| blob \| history
bpmn/MSOCommonBPMN/src/test/java/org/onap/so/bpmn/common/recipe/ResourceInputTest.java		diff \| blob \| history
bpmn/MSOCommonBPMN/src/test/java/org/onap/so/bpmn/common/recipe/ResourceRecipeRequestTest.java		diff \| blob \| history
bpmn/MSOCommonBPMN/src/test/java/org/onap/so/client/ResponseExceptionMapperImplTest.java		diff \| blob \| history
bpmn/MSOCommonBPMN/src/test/java/org/onap/so/client/cds/GeneratePayloadForCdsTest.java		diff \| blob \| history
bpmn/MSOCommonBPMN/src/test/java/org/onap/so/client/cds/PnfCDSRequestProviderTest.java		diff \| blob \| history
bpmn/so-bpmn-infrastructure-common/src/test/java/org/onap/so/bpmn/infrastructure/aai/AAIServiceInstanceTest.java	[deleted file]	blob \| history
bpmn/so-bpmn-infrastructure-common/src/test/java/org/onap/so/bpmn/infrastructure/workflow/serviceTask/client/builder/AbstractBuilderTest.java		diff \| blob \| history
bpmn/so-bpmn-infrastructure-common/src/test/java/org/onap/so/bpmn/infrastructure/workflow/serviceTask/client/builder/NetworkRpcInputEntityBuilderTest.java		diff \| blob \| history
bpmn/so-bpmn-infrastructure-common/src/test/java/org/onap/so/bpmn/infrastructure/workflow/serviceTask/client/builder/ServiceRpcInputEntityBuilderTest.java		diff \| blob \| history
bpmn/so-bpmn-infrastructure-flows/src/test/java/org/onap/so/bpmn/infrastructure/process/CreateVcpeResCustServiceSimplifiedTest.java		diff \| blob \| history
bpmn/so-bpmn-moi/src/test/java/org/onap/so/bpmn/moi/tasks/EnrichGBBTaskTest.java	[deleted file]	blob \| history
bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/aai/tasks/AAIUpdateTasksTest.java		diff \| blob \| history
bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/appc/tasks/AppcOrchestratorPreProcessorTest.java		diff \| blob \| history
bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/audit/AuditTasksTest.java		diff \| blob \| history
bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/flowspecific/tasks/SniroHomingV2IT.java		diff \| blob \| history
bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/service/composition/CreateChildServiceBBTest.java		diff \| blob \| history
bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/workflow/tasks/WorkflowActionUnitTest.java		diff \| blob \| history
bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/workflow/tasks/ebb/loader/VrfValidationTest.java		diff \| blob \| history
common/clients/src/test/java/org/onap/so/client/cds/CDSProcessingClientTest.java		diff \| blob \| history
common/common/src/test/java/org/onap/so/openpojo/rules/EqualsAndHashCodeTesterTest.java		diff \| blob \| history
common/common/src/test/java/org/onap/so/openpojo/rules/HasEqualsAndHashCodeRuleTest.java		diff \| blob \| history
graph-inventory/aai-client/src/test/java/org/onap/aaiclient/client/aai/AAIResourcesClientTest.java		diff \| blob \| history
graph-inventory/aai-client/src/test/java/org/onap/aaiclient/client/aai/AAIUpdatorImplTest.java		diff \| blob \| history
graph-inventory/aai-client/src/test/java/org/onap/aaiclient/client/graphinventory/exceptions/GraphInventoryPayloadExceptionTest.java		diff \| blob \| history
mso-api-handlers/mso-api-handler-common/src/test/java/org/onap/so/apihandler/camundabeans/BpmnRequestTest.java	[deleted file]	blob \| history
mso-api-handlers/mso-api-handler-infra/src/test/java/org/onap/so/apihandlerinfra/MsoRequestTest.java		diff \| blob \| history
mso-api-handlers/mso-api-handler-infra/src/test/java/org/onap/so/apihandlerinfra/OrchestrationRequestsTest.java		diff \| blob \| history
mso-api-handlers/mso-api-handler-infra/src/test/java/org/onap/so/apihandlerinfra/RequestActionMapTest.java		diff \| blob \| history
mso-api-handlers/mso-api-handler-infra/src/test/java/org/onap/so/apihandlerinfra/tenantisolation/process/ActivateVnfOperationalEnvironmentTest.java		diff \| blob \| history
mso-api-handlers/mso-api-handler-infra/src/test/java/org/onap/so/apihandlerinfra/tenantisolation/process/ActivateVnfStatusOperationalEnvironmentTest.java		diff \| blob \| history
mso-api-handlers/mso-api-handler-infra/src/test/java/org/onap/so/apihandlerinfra/tenantisolation/process/CreateEcompOperationalEnvironmentTest.java		diff \| blob \| history
mso-api-handlers/mso-api-handler-infra/src/test/java/org/onap/so/apihandlerinfra/tenantisolation/process/CreateVnfOperationalEnvironmentTest.java		diff \| blob \| history
mso-api-handlers/mso-api-handler-infra/src/test/java/org/onap/so/apihandlerinfra/tenantisolation/process/DeactivateVnfOperationalEnvironmentTest.java		diff \| blob \| history
mso-api-handlers/mso-api-handler-infra/src/test/java/org/onap/so/apihandlerinfra/tenantisolationbeans/TenantIsolationBeansTest.java		diff \| blob \| history
mso-catalog-db/src/test/java/org/onap/so/db/catalog/BaseTest.java		diff \| blob \| history
so-optimization-clients/src/test/java/org/onap/so/client/oof/OofClientTestIT.java		diff \| blob \| history

Service Orchestrator

RSS Atom