Fix sonar generic Exceptions in policy/common 95/29895/3
authorJim Hahn <jrh3@att.com>
Wed, 31 Jan 2018 23:10:34 +0000 (18:10 -0500)
committerJim Hahn <jrh3@att.com>
Thu, 1 Feb 2018 15:50:48 +0000 (10:50 -0500)
commit0f51fa4e072aeb29f4e323cb6013fb4a873aae5c
tree1f0b28eea283e367725980e3e22acfaf89e628e2
parent9c978cea0a5af3d4a9d587a5f09b88d660bd498b
Fix sonar generic Exceptions in policy/common

IntegrityMonitor.java:
Renamed variables, Ex: dep_groups => depGroups.
Renamed enum constants, Ex: pdp_xacml => PDP_XACML.
Merged "if" tests.
Cast values to "long" before multiplying.
Re-throw interrupt().
Write exception via logger instead of e.printStackTrace().
Moved constructor to top of the file.
Removed most logger.isDebugEnabled() checks.
Returned generic List instead of ArrayList.
Used entrySet() instead of keySet().
Removed useless parentheses.
Removed superfluous exceptions from "throws" declaration.

DbAudit.java:
Modified DbAudit to throw DbAuditException.
Replaced references to HashSet and HashMap with generic Set and Map.
Modified DbAudit to iterate over entrySet() instead of keySet().

ComponentAdminException:
Created ComponentAdminException class.
Modified ComponentAdmin methods to throw new exception class.
Extracted "stateManager" String constant.
Eliminated logger.isDebugEnabled() calls.
Updated the license data.

Eliminated double-checked locking problem from PropertyUtil:
Modified code to use Initialization On Demand Holder idiom.

Change-Id: Ic01288542041da26df483ce85ecaf292ac138f85
Issue-ID: POLICY-246
Signed-off-by: Jim Hahn <jrh3@att.com>
integrity-audit/src/main/java/org/onap/policy/common/ia/DbAudit.java
integrity-audit/src/main/java/org/onap/policy/common/ia/DbDAO.java
integrity-audit/src/test/java/org/onap/policy/common/ia/test/DbAuditCompareEntriesTest.java
integrity-audit/src/test/java/org/onap/policy/common/ia/test/DbDAOTest.java
integrity-monitor/src/main/java/org/onap/policy/common/im/IntegrityMonitor.java
integrity-monitor/src/main/java/org/onap/policy/common/im/jmx/ComponentAdmin.java
integrity-monitor/src/main/java/org/onap/policy/common/im/jmx/ComponentAdminException.java [new file with mode: 0644]
integrity-monitor/src/test/java/org/onap/policy/common/im/test/IntegrityMonitorTest.java