Code Review / policy / engine.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 4e66155) | patch
Sonar cleanup in controllers etc 68/97068/3
authorPamela Dragosh <pdragosh@research.att.com>
Mon, 14 Oct 2019 15:39:45 +0000 (11:39 -0400)
committerPamela Dragosh <pdragosh@research.att.com>
Tue, 15 Oct 2019 01:14:27 +0000 (21:14 -0400)
commit0950d79047d3404c15b4dd30cffeb81346565f64
treee5c9534b7f3349684dad00cab74c4b14b9dfe733tree | snapshot
parent4e6615528e03f1a6f7808e28481bd55fe39ed572commit | diff
Sonar cleanup in controllers etc

Variable renaming of consecutive capital letters.
Adding Javadoc
Missing curly braces
Re-writing some methods to reduce cyclomatic complexity
Combining while's into a simple for statement.
Addressing previous review comments

No real effort on code coverage in this one.

Issue-ID: POLICY-2133
Change-Id: I4afb3030203e1dbc743507e037ca3d57faf41f1d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
23 files changed:
POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyManagerServlet.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/components/HumanPolicyComponent.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/ActionPolicyController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/AutoPushController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateBRMSParamController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateBRMSRawController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateClosedLoopFaultController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateClosedLoopPMController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateDcaeMicroServiceController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateFirewallController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateOptimizationController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreatePolicyController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DecisionPolicyController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/ExportAndImportDecisionBlackListEntries.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PDPController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyExportAndImportController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyRolesController.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/daoImp/CommonClassDaoImpl.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/model/PDPGroupContainer.java diff | blob | history
POLICY-SDK-APP/src/main/java/org/onap/policy/utils/UserUtils.java diff | blob | history
POLICY-SDK-APP/src/test/java/org/onap/policy/conf/HibernateSessionTest.java diff | blob | history
POLICY-SDK-APP/src/test/java/org/onap/policy/daoImp/CommonClassDaoImplTest.java diff | blob | history
-- Archived 06/09/2021