Code Review / dcaegen2 / collectors / hv-ves.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: cf1465f) | patch
Use Either instead of exceptions in frame decoder 33/58633/1
authorPiotr Jaszczyk <piotr.jaszczyk@nokia.com>
Thu, 28 Jun 2018 12:42:05 +0000 (14:42 +0200)
committerPiotr Jaszczyk <piotr.jaszczyk@nokia.com>
Thu, 2 Aug 2018 09:04:01 +0000 (11:04 +0200)
commit03702b48989174dc8afa855e663a28e34b4da67b
treee89a4930aab1a53014b81e76be493dda41d9e007tree | snapshot
parentcf1465f37d20391a921df449d5dd01454f64910ccommit | diff
Use Either instead of exceptions in frame decoder

Goals:
* Make code cleaner (in a FP way)
* Avoid costly exception throw each time we wait for the rest of the
frame (collecting stack traces is costly and we do not need them
anyway)

Closes ONAP-437
Change-Id: I40341d3c2cb85f3ff581d89167245cb009dbb070
Signed-off-by: Piotr Jaszczyk <piotr.jaszczyk@nokia.com>
Issue-ID: DCAEGEN2-601
12 files changed:
hv-collector-core/src/main/kotlin/org/onap/dcae/collectors/veshv/impl/wire/WireChunkDecoder.kt diff | blob | history
hv-collector-core/src/main/kotlin/org/onap/dcae/collectors/veshv/impl/wire/WireFrameException.kt [moved from hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/exceptions/WireFrameDecodingException.kt with 81% similarity] diff | blob | history
hv-collector-core/src/test/kotlin/org/onap/dcae/collectors/veshv/impl/wire/WireChunkDecoderTest.kt diff | blob | history
hv-collector-ct/src/test/kotlin/org/onap/dcae/collectors/veshv/tests/component/PerformanceSpecification.kt diff | blob | history
hv-collector-ct/src/test/kotlin/org/onap/dcae/collectors/veshv/tests/component/VesHvSpecification.kt diff | blob | history
hv-collector-ct/src/test/kotlin/org/onap/dcae/collectors/veshv/tests/component/messages.kt [moved from hv-collector-ct/src/test/kotlin/org/onap/dcae/collectors/veshv/tests/component/utils.kt with 100% similarity] blob | history
hv-collector-ct/src/test/kotlin/org/onap/dcae/collectors/veshv/tests/component/spekUtils.kt [moved from hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/exceptions/InvalidWireFrameMarkerException.kt with 66% similarity] diff | blob | history
hv-collector-domain/pom.xml diff | blob | history
hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/codec.kt diff | blob | history
hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/errors.kt [moved from hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/exceptions/EmptyWireFrameException.kt with 58% similarity] diff | blob | history
hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/exceptions/MissingWireFrameBytesException.kt [deleted file] blob | history
hv-collector-domain/src/test/kotlin/org/onap/dcae/collectors/veshv/domain/WireFrameCodecsTest.kt diff | blob | history
High Volume VES Collector