gerrit.onap Code Review - policy/common.git/commit

Code Review / policy / common.git / commit

author	Jim Hahn <jrh3@att.com>
	Fri, 5 Jul 2019 17:03:06 +0000 (13:03 -0400)
committer	Jim Hahn <jrh3@att.com>
	Fri, 5 Jul 2019 21:36:12 +0000 (17:36 -0400)
commit	02ba37e23bebc5fc8831feaa4ce073295c3c93d8
tree	4b4b99ec0d2d429fe2d857e3992d5e893615f6b1	tree \| snapshot
parent	53f9550501ca1854318c1f552b0aba2e255b6748	commit \| diff

Fix sonar issues in policy ONAP logging

Sonar fixes, other than code coverage. These changes are disruptive
and will likely cause breakage in a number of policy repos.
Renamed constants.
Moved constants/factories from interfaces to classes.
Also fixed remaining checkstyle issues, which was equally disruptive,
as it required renaming of methods and classes.
Split out Onap config properties from EELF config properties, in
case changes are made in the future such that Onap properties can
no longer subclass from EELF properties (e.g., if EELF properties are
converted from a interface to a utility class with a private constructor).
Attempted to eliminate some duplicate blocks of code by refactoring
out common methods.

Change-Id: Ie038d2d4ed553037a9af3f0ddf31baf2b3628fa3
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>

28 files changed:

common-logging/checkstyle-suppressions.xml	[deleted file]	blob \| history
common-logging/pom.xml		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/OnapLoggingContext.java	[moved from common-logging/src/main/java/org/onap/policy/common/logging/ONAPLoggingContext.java with 94% similarity]	diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/OnapLoggingUtils.java	[moved from common-logging/src/main/java/org/onap/policy/common/logging/ONAPLoggingUtils.java with 79% similarity]	diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/eelf/DroolsPdpMdcInfo.java	[moved from common-logging/src/main/java/org/onap/policy/common/logging/eelf/DroolsPDPMDCInfo.java with 76% similarity]	diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/eelf/EventData.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/eelf/EventTrackInfo.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/eelf/EventTrackInfoHandler.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/eelf/MdcInfo.java	[moved from common-logging/src/main/java/org/onap/policy/common/logging/eelf/MDCInfo.java with 88% similarity]	diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/eelf/OnapConfigProperties.java	[moved from common-logging/src/main/java/org/onap/policy/common/logging/eelf/Configuration.java with 61% similarity]	diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/eelf/PolicyLogger.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/DisplayUtils.java	[new file with mode: 0644]	blob
common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/EelfLogger.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/FlexLogger.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/Logger.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/Logger4J.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/PropertyUtil.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/SystemOutLogger.java		diff \| blob \| history
common-logging/src/main/java/org/onap/policy/common/logging/nsa/LoggingContextFactory.java		diff \| blob \| history
common-logging/src/test/java/org/onap/policy/common/logging/eelf/DroolsPdpMdcInfoTest.java	[moved from common-logging/src/test/java/org/onap/policy/common/logging/eelf/DroolsPDPMDCInfoTest.java with 75% similarity]	diff \| blob \| history
common-logging/src/test/java/org/onap/policy/common/logging/eelf/EventDataTest.java		diff \| blob \| history
common-logging/src/test/java/org/onap/policy/common/logging/eelf/EventTrackInfoTest.java		diff \| blob \| history
common-logging/src/test/java/org/onap/policy/common/logging/eelf/PolicyLoggerTest.java		diff \| blob \| history
common-logging/src/test/java/org/onap/policy/common/logging/flexlogger/EelfLoggerTest.java		diff \| blob \| history
common-logging/src/test/java/org/onap/policy/common/logging/flexlogger/FlexLoggerTest.java		diff \| blob \| history
common-logging/src/test/java/org/onap/policy/common/logging/flexlogger/Logger4JTest.java		diff \| blob \| history
common-logging/src/test/java/org/onap/policy/common/logging/flexlogger/SystemOutLoggerTest.java		diff \| blob \| history
common-logging/src/test/java/org/onap/policy/common/logging/util/TestUtils.java	[deleted file]	blob \| history

Policy common shared modules

RSS Atom