Fix simple sonar issues in models: errors to sim-pdp 23/90023/6
authorJim Hahn <jrh3@att.com>
Fri, 14 Jun 2019 19:02:00 +0000 (15:02 -0400)
committerJim Hahn <jrh3@att.com>
Mon, 17 Jun 2019 21:39:54 +0000 (17:39 -0400)
commit77df45928640808633af05908c680955848e4cd2
tree799e3b9de30f65007c6965baf3e35200610e7de2
parent3deee00dcccb21efa194be439915ae06e878fd44
Fix simple sonar issues in models: errors to sim-pdp

models-errors
models-pdp
models-provider
models-sim-pdp

Also had to work around this checkstyle issue:

src/test/java/org/onap/policy/models/sim/pdp/comm/
TestPdpStateChangeListener.java:[77,32] (javadoc) JavadocMethod:
Unable to get class information for @throws tag
'PdpSimulatorException'.

The error appears to be bogus, as PdpSimulatorException is on the
"throws" line thus indicating that the class IS accessible to the
above java file.

Change-Id: Iaca58457a32b00121000fc0bab12a8be4cb19bac
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
23 files changed:
models-errors/src/test/java/org/onap/policy/models/errors/concepts/ErrorResponseUtilsTest.java
models-pdp/src/test/java/org/onap/policy/models/pdp/concepts/PdpMessageTest.java
models-pdp/src/test/java/org/onap/policy/models/pdp/concepts/PdpSubGroupTest.java
models-pdp/src/test/java/org/onap/policy/models/pdp/persistence/provider/PdpProviderTest.java
models-provider/src/test/java/org/onap/policy/models/provider/PolicyModelsProviderFactoryTest.java
models-provider/src/test/java/org/onap/policy/models/provider/impl/DatabasePolicyModelsProviderTest.java
models-provider/src/test/java/org/onap/policy/models/provider/impl/DummyBadProviderImpl.java
models-provider/src/test/java/org/onap/policy/models/provider/impl/DummyPolicyModelsProviderTest.java
models-provider/src/test/java/org/onap/policy/models/provider/impl/PolicyLegacyGuardPersistenceTest.java
models-provider/src/test/java/org/onap/policy/models/provider/impl/PolicyLegacyOperationalPersistenceTest.java
models-provider/src/test/java/org/onap/policy/models/provider/impl/PolicyPersistenceTest.java
models-provider/src/test/java/org/onap/policy/models/provider/impl/PolicyToscaPersistenceTest.java
models-sim/policy-models-sim-pdp/src/main/java/org/onap/policy/models/sim/pdp/PdpSimulatorActivator.java
models-sim/policy-models-sim-pdp/src/main/java/org/onap/policy/models/sim/pdp/PdpSimulatorMain.java
models-sim/policy-models-sim-pdp/src/main/java/org/onap/policy/models/sim/pdp/handler/PdpMessageHandler.java
models-sim/policy-models-sim-pdp/src/main/java/org/onap/policy/models/sim/pdp/handler/PdpStateChangeMessageHandler.java
models-sim/policy-models-sim-pdp/src/main/java/org/onap/policy/models/sim/pdp/handler/PdpUpdateMessageHandler.java
models-sim/policy-models-sim-pdp/src/main/java/org/onap/policy/models/sim/pdp/parameters/PdpSimulatorParameterHandler.java
models-sim/policy-models-sim-pdp/src/test/java/org/onap/policy/models/sim/pdp/comm/TestPdpStateChangeListener.java
models-sim/policy-models-sim-pdp/src/test/java/org/onap/policy/models/sim/pdp/comm/TestPdpUpdateListener.java
models-sim/policy-models-sim-pdp/src/test/java/org/onap/policy/models/sim/pdp/parameters/CommonTestData.java
models-sim/policy-models-sim-pdp/src/test/java/org/onap/policy/models/sim/pdp/parameters/TestPdpSimulatorParameterHandler.java
models-sim/policy-models-sim-pdp/src/test/java/org/onap/policy/models/sim/pdp/parameters/TestPdpStatusParameters.java