Code Review / policy / drools-pdp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 7dc71c3) | patch
Fix more sonars in drools-pdp 89/111889/3
authorJim Hahn <jrh3@att.com>
Mon, 31 Aug 2020 12:22:13 +0000 (08:22 -0400)
committerJim Hahn <jrh3@att.com>
Mon, 31 Aug 2020 14:15:07 +0000 (10:15 -0400)
commitd5c365f60e492e37a361654974eba1719146bdc2
treef717c2198c1aebe0cc03a5d3e9aec653d0d73807tree | snapshot
parent7dc71c3d0aedb322aff0cdaaa84340354c41b089commit | diff
Fix more sonars in drools-pdp

Fixed more sonars in drools-pdp:
- remove commented code
- don't throw generic Exception
- unused field (made it protected instead of private)
- log conditionally
- cognitive complexity
- too many break/continue
- return empty list instead of null
- Random() is not secure

Fixed more eclipse warnings:
- parameterize generic types

Issue-ID: POLICY-2616-sonars3
Change-Id: Ia5ad769b2ea763568cfae3d81807926d89153b09
Signed-off-by: Jim Hahn <jrh3@att.com>
13 files changed:
api-state-management/src/main/java/org/onap/policy/drools/statemanagement/StateManagementFeatureApi.java diff | blob | history
feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/DroolsPdpsElectionHandler.java diff | blob | history
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/Bucket.java diff | blob | history
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/Server.java diff | blob | history
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/ServerPoolApi.java diff | blob | history
feature-server-pool/src/main/java/org/onap/policy/drools/serverpool/persistence/Persistence.java diff | blob | history
feature-server-pool/src/test/java/org/onap/policy/drools/serverpool/AdapterImpl.java diff | blob | history
feature-state-management/src/main/java/org/onap/policy/drools/statemanagement/DroolsPdpIntegrityMonitor.java diff | blob | history
feature-state-management/src/main/java/org/onap/policy/drools/statemanagement/RepositoryAudit.java diff | blob | history
feature-state-management/src/main/java/org/onap/policy/drools/statemanagement/StateManagementFeature.java diff | blob | history
feature-state-management/src/test/java/org/onap/policy/drools/statemanagement/test/StateManagementTest.java diff | blob | history
policy-management/src/main/java/org/onap/policy/drools/controller/IndexedDroolsControllerFactory.java diff | blob | history
policy-management/src/main/java/org/onap/policy/drools/system/Main.java diff | blob | history
The Drools PDP engine.