Improved code coverage for CpsDataServiceImpl 80/135480/2
authorToineSiebelink <toine.siebelink@est.tech>
Mon, 17 Jul 2023 08:22:05 +0000 (09:22 +0100)
committerToineSiebelink <toine.siebelink@est.tech>
Mon, 17 Jul 2023 10:22:06 +0000 (11:22 +0100)
commitdcf84ad73f0301ef41049e692b9963f6dcac3661
treec7384f6abcc35da86475c222e7f6c16186d374fb
parentefd255d61b0414d9cd44267779d144b78d1eb294
Improved code coverage for CpsDataServiceImpl

- Added (extended) test to cover missed scenarios
- Removed unnecesarry null check from Production code
- Improved error messages in production code
- Removed duplicate test
- Cleaned up existign test somewhat (labels and aligment)

Issue-ID: CPS-475
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I9761ad6d4777a6bcfee4cbe1b876dd39fa218fc8
cps-service/src/main/java/org/onap/cps/api/impl/CpsDataServiceImpl.java
cps-service/src/test/groovy/org/onap/cps/api/impl/CpsDataServiceImplSpec.groovy
cps-service/src/test/groovy/org/onap/cps/utils/YangUtilsSpec.groovy