Fix Technical Debt, add Unit tests for SO 19/28519/2
authorvdmeer <sven.van.der.meer@ericsson.com>
Thu, 18 Jan 2018 12:50:32 +0000 (12:50 +0000)
committervdmeer <sven.van.der.meer@ericsson.com>
Thu, 18 Jan 2018 13:44:16 +0000 (13:44 +0000)
commitcef733a2902a600c1b4a95ef11b2f4ffc0fcbf99
tree5eaaa6e26b3649d74fb8966cd303b8e8d9898271
parentbdf5640a2c68a0899363503dafa0f7cb1557e4a6
Fix Technical Debt, add Unit tests for SO

Converted to POJOs, fixed sona lint errors, added JUnit tests
POJOs now have only private members and getters/setters
This implicated actors, simulators, and existing tests

Issue-ID: POLICY-455
Change-Id: I4b80f729565e8675822a890892b15676908f73b4
Signed-off-by: vdmeer.sven <sven.van.der.meer@ericsson.com>
42 files changed:
controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java
controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopOperationManager.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOAsyncRequestStatus.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOCloudConfiguration.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOInstanceReferences.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOManager.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOModelInfo.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOPolicyException.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORelatedInstance.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORelatedInstanceListElement.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORequest.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORequestDetails.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORequestError.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORequestInfo.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORequestParameters.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORequestReferences.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SORequestStatus.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOResponse.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOResponseWrapper.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOServiceException.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/SOSubscriberInfo.java
controlloop/common/model-impl/so/src/main/java/org/onap/policy/so/util/Serialization.java
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestDemo.java
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoAsyncRequestStatus.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoCloudConfiguration.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoInstanceReferences.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoModelInfo.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoPolicyException.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoRelatedInstance.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoRelatedInstanceListElement.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoRequest.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoRequestDetails.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoRequestError.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoRequestInfo.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoRequestParameters.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoRequestReferences.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoRequestStatus.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoResponse.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoResponseWrapper.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoServiceException.java [new file with mode: 0755]
controlloop/common/model-impl/so/src/test/java/org/onap/policy/so/TestSoSubscriberInfo.java [new file with mode: 0755]
controlloop/common/simulators/src/test/java/org/onap/policy/simulators/SoSimulatorTest.java