Code Review / policy / xacml-pdp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: fc07c32) | patch
Consolidate common translatable code some sonar 31/97431/4
authorPamela Dragosh <pdragosh@research.att.com>
Tue, 22 Oct 2019 17:06:56 +0000 (13:06 -0400)
committerPamela Dragosh <pdragosh@research.att.com>
Wed, 23 Oct 2019 13:19:24 +0000 (09:19 -0400)
commit5bc83b197ad010bbdf5916493d078818c2c10bcb
treec4cc4bcf283047ebb71e2f338048a1f1760be11ctree | snapshot
parentfc07c32a4c01a2541c8061a37c3c6589c720e2b3commit | diff
Consolidate common translatable code some sonar

There is duplicate code for some common translation of policy
decision responses and for scanning obligations.

Removed some TODO items (left others because I want to look
at them more closely).

Stored System.lineSeparator into a static var so that I can
remove some unnecessary ifs. There's still one left that I
am not worried about.

Gson as a static variable.

Issue-ID: POLICY-2066
Change-Id: I9c8162d5ad1c5f884be347dd94631fa74ca76f85
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
14 files changed:
applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/XacmlPolicyUtils.java diff | blob | history
applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdBaseTranslator.java [new file with mode: 0644] blob
applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdCombinedPolicyResultsTranslator.java diff | blob | history
applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdMatchableTranslator.java diff | blob | history
applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdXacmlApplicationServiceProvider.java diff | blob | history
applications/common/src/test/java/org/onap/policy/pdp/xacml/application/common/XacmlPolicyUtilsTest.java diff | blob | history
applications/common/src/test/java/org/onap/policy/pdp/xacml/application/common/std/StdMatchableTranslatorTest.java diff | blob | history
applications/guard/src/main/java/org/onap/policy/xacml/pdp/application/guard/CoordinationGuardTranslator.java diff | blob | history
applications/guard/src/main/java/org/onap/policy/xacml/pdp/application/guard/LegacyGuardTranslator.java diff | blob | history
applications/guard/src/test/java/org/onap/policy/xacml/pdp/application/guard/CoordinationTest.java diff | blob | history
applications/guard/src/test/java/org/onap/policy/xacml/pdp/application/guard/GuardPdpApplicationTest.java diff | blob | history
applications/monitoring/src/test/java/org/onap/policy/xacml/pdp/application/monitoring/MonitoringPdpApplicationTest.java diff | blob | history
applications/optimization/src/test/java/org/onap/policy/xacml/pdp/application/optimization/OptimizationPdpApplicationTest.java diff | blob | history
main/src/test/java/org/onap/policy/pdpx/main/rest/TestAbbreviateDecisionResults.java diff | blob | history
This repo will hold the next generation XACML PDP engine (Casablanca)