X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=tox.ini;h=efe3b380352716b97a4995a987c03c05fd907e2e;hb=24a9d489fc776daaf3e1c37c66a3339cd9ba60bd;hp=01e99536175d645ce0c8a7f41abdcdc1f99927e3;hpb=f4527b94897c02c763f11e4013dbbe9b3a821061;p=oom.git

diff --git a/tox.ini b/tox.ini
index 01e9953617..efe3b38035 100644
--- a/tox.ini
+++ b/tox.ini
@@ -4,6 +4,8 @@ envlist =
  docs,
  docs-linkcheck,
  gitlint,
+ checkbashisms,
+ pre-commit,
 skipsdist=true
 
 [doc8]
@@ -11,8 +13,9 @@ ignore-path-errors=docs/helm-search.txt;D001
 
 [testenv:doc8]
 deps = -rdocs/requirements-docs.txt
+       doc8
 commands =
- doc8 docs/
+ - doc8 docs/
 
 [testenv:docs]
 deps = -rdocs/requirements-docs.txt
@@ -52,7 +55,7 @@ commands =
     sh -c 'which checkbashisms>/dev/null  || sudo yum install devscripts-minimal || sudo apt-get install devscripts \
         || (echo "checkbashisms command not found - please install it (e.g. sudo apt-get install devscripts | \
         yum install devscripts-minimal )" >&2 && exit 1)'
-    find . -not -path '*/\.*' -name *.sh -exec checkbashisms -f  \{\} +
+    find . -not -path '*/\.*' -name *.sh -exec checkbashisms \{\} +
 
 [testenv:autopep8]
 deps = autopep8
@@ -65,3 +68,29 @@ whitelist_externals = find
 commands =
     find kubernetes/ TOSCA/ docs/ -name *.py -exec pylint --max-line-length=120 --disable=missing-docstring --method-rgx="(([a-z_][a-zA-Z0-9_]{2,})|(_[a-z0-9_]*)|(__[a-zA-Z][a-zA-Z0-9_]+__))$" --variable-rgx="[a-zA-Z_][a-zA-Z0-9_]{1,30}$" --reports=y --score=y  --output-format=colorized  \{\} +
 
+[testenv:pre-commit-install]
+basepython = python3
+deps = pre-commit
+commands =
+    pre-commit install
+    pre-commit install --hook-type commit-msg
+
+[testenv:pre-commit-uninstall]
+basepython = python3
+deps = pre-commit
+commands =
+    pre-commit uninstall
+    pre-commit uninstall --hook-type commit-msg
+
+[testenv:pre-commit]
+basepython = python3
+deps = pre-commit
+passenv = HOME
+commands =
+    pre-commit run --all-files --show-diff-on-failure
+    pre-commit run gitlint --hook-stage commit-msg --commit-msg-filename .git/COMMIT_EDITMSG
+    # Gitlint only proposes a pre-commit configuration for the commit-msg stage but none for the commit stage.
+    # Its default arguments --passed and --msg-filename are different from CI recommandations.
+    # As a result, the line above is always skipped in jenkins CI since there cannot be a .git/COMMIT_EDITMSG file.
+    # A dedicated gitlint profile for CI is proposed above. Also to behave fine locally, this profile must have access
+    # to the HOME variable so that Gitlint can retrieve Git user settings.