X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=src%2Ftest%2Fjava%2Forg%2Fonap%2Faai%2Fbabel%2Fparser%2FTestArtifactGeneratorToscaParser.java;h=acc4a352ec6a59d67e0d8fee38717551ca202ba7;hb=5a6fd49a6aca3a567464527335b107746e28f3bd;hp=4451a28b47e3ab153eb3944542571ff01dd7313d;hpb=f5dae47e293ae63a7a2f18230b772a699a52566f;p=aai%2Fbabel.git diff --git a/src/test/java/org/onap/aai/babel/parser/TestArtifactGeneratorToscaParser.java b/src/test/java/org/onap/aai/babel/parser/TestArtifactGeneratorToscaParser.java index 4451a28..acc4a35 100644 --- a/src/test/java/org/onap/aai/babel/parser/TestArtifactGeneratorToscaParser.java +++ b/src/test/java/org/onap/aai/babel/parser/TestArtifactGeneratorToscaParser.java @@ -57,6 +57,7 @@ public class TestArtifactGeneratorToscaParser { * Initialize the Generator with an invalid artifact generator properties file path. * * @throws IOException + * if an error occurs reading the configuration properties */ @Test(expected = IllegalArgumentException.class) public void testMissingPropertiesFile() throws IOException { @@ -68,6 +69,7 @@ public class TestArtifactGeneratorToscaParser { * Initialize the Generator with an invalid mappings file path. * * @throws IOException + * if the file content could not be read successfully */ @Test(expected = IllegalArgumentException.class) public void testMissingMappingsFile() throws IOException { @@ -78,6 +80,7 @@ public class TestArtifactGeneratorToscaParser { * Initialize the Generator with no Widget Mappings content. * * @throws IOException + * if the file content could not be read successfully */ @Test(expected = IOException.class) public void testMissingMappingsContent() throws IOException { @@ -89,6 +92,7 @@ public class TestArtifactGeneratorToscaParser { * Initialize the Generator with invalid Widget Mappings content. * * @throws IOException + * if the file content could not be read successfully */ @Test(expected = IOException.class) public void testInvalidMappingsContent() throws IOException { @@ -118,29 +122,46 @@ public class TestArtifactGeneratorToscaParser { } /** - * Initialise the Artifact Generator Widget Mapping config with incomplete data. + * Initialize the Artifact Generator Widget Mapping config with incomplete data (no type). + * + * @throws IOException */ - @Test(expected = IllegalArgumentException.class) - public void testToscaMappingWithoutType() { + @Test(expected = IOException.class) + public void testToscaMappingWithoutType() throws IOException { WidgetMapping invalidMapping = new WidgetMapping(); invalidMapping.setType(null); WidgetConfigurationUtil.setWidgetMappings(Collections.singletonList(invalidMapping)); } /** - * Initialise the Artifact Generator Widget Mapping config with incomplete data. + * Initialize the Artifact Generator Widget Mapping config with invalid data (type value). + * + * @throws IOException */ - @Test(expected = IllegalArgumentException.class) - public void testToscaMappingWithoutWidget() { + @Test(expected = IOException.class) + public void testToscaMappingWithInvalidType() throws IOException { + WidgetMapping invalidMapping = new WidgetMapping(); + invalidMapping.setType("invalid"); + WidgetConfigurationUtil.setWidgetMappings(Collections.singletonList(invalidMapping)); + } + + /** + * Initialize the Artifact Generator Widget Mapping config with incomplete data (no widget name). + * + * @throws IOException + */ + @Test(expected = IOException.class) + public void testToscaMappingWithoutWidget() throws IOException { WidgetMapping invalidMapping = new WidgetMapping(); invalidMapping.setWidget(null); WidgetConfigurationUtil.setWidgetMappings(Collections.singletonList(invalidMapping)); } - + /** * Process a dummy Group object for a Service Resource. * * @throws XmlArtifactGenerationException + * if there is no configuration defined for a member Widget of an instance group */ @Test public void testInstanceGroups() throws XmlArtifactGenerationException {