X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=src%2Fmain%2Fjava%2Forg%2Fonap%2Fdmaap%2Fdbcapi%2Faaf%2FAafServiceImpl.java;h=4848a69ed9522c0573290977893c66b7d0fc2b7a;hb=27a9a302a7d7e1894732535a8eb61f3460637b24;hp=49810f3b63d23bcd6f3cd0b291814646bb912345;hpb=c52d9c91d54f7e8b0500cebba00255b3e6b08c13;p=dmaap%2Fdbcapi.git diff --git a/src/main/java/org/onap/dmaap/dbcapi/aaf/AafServiceImpl.java b/src/main/java/org/onap/dmaap/dbcapi/aaf/AafServiceImpl.java index 49810f3..4848a69 100644 --- a/src/main/java/org/onap/dmaap/dbcapi/aaf/AafServiceImpl.java +++ b/src/main/java/org/onap/dmaap/dbcapi/aaf/AafServiceImpl.java @@ -23,12 +23,17 @@ package org.onap.dmaap.dbcapi.aaf; import org.onap.dmaap.dbcapi.logging.BaseLoggingClass; import org.onap.dmaap.dbcapi.logging.DmaapbcLogMessageEnum; +import static java.lang.String.format; + public class AafServiceImpl extends BaseLoggingClass implements AafService { - private String aafUrl; - private String identity; - private boolean useAAF; - private AafConnection aafConnection; + private static final int CREATED = 201; + private static final int OK = 200; + private static final String FORCE = "?force=true"; + private final String aafUrl; + private final String identity; + private final boolean useAAF; + private final AafConnection aafConnection; AafServiceImpl(boolean useAaf, String aafUrl, String identity, AafConnection aafConnection) { this.useAAF = useAaf; @@ -45,47 +50,53 @@ public class AafServiceImpl extends BaseLoggingClass implements AafService { @Override public int addPerm(DmaapPerm perm) { logger.info("entry: addPerm() "); - return doPost(perm, "authz/perm", 201); + return doPost(perm, "authz/perm", CREATED); } @Override - public int delPerm(DmaapPerm perm) { - return 200; + public int delPerm(DmaapPerm perm, boolean force) { + logger.info("entry: delPerm()"); + return doDelete(new AafEmpty(), format( + "authz/perm/%s/%s/%s%s", + perm.getPermission(), perm.getPtype(), perm.getAction(), force ? FORCE : ""), OK); } @Override public int addGrant(DmaapGrant grant) { logger.info("entry: addGrant() "); - return doPost(grant, "authz/role/perm", 201); + return doPost(grant, "authz/role/perm", CREATED); } @Override public int addUserRole(AafUserRole ur) { logger.info("entry: addUserRole() "); - return doPost(ur, "authz/userRole", 201); + return doPost(ur, "authz/userRole", CREATED); } @Override public int delGrant(DmaapGrant grant) { logger.info("entry: delGrant() "); - return doDelete(grant, "authz/role/:" + grant.getRole() + "/perm", 200); + return doDelete(grant, "authz/role/:" + grant.getRole() + "/perm", OK); } @Override public int addRole(AafRole role) { logger.info("entry: addRole() "); - return doPost(role, "authz/role", 201); + return doPost(role, "authz/role", CREATED); } @Override public int addNamespace(AafNamespace ns) { logger.info("entry: addNamespace() "); - return doPost(ns, "authz/ns", 201); + return doPost(ns, "authz/ns", CREATED); } @Override - public int delNamespace(AafNamespace ns) { - return 200; + public int delNamespace(AafNamespace ns, boolean force) { + logger.info("entry: delNamespace()"); + return doDelete(new AafEmpty(), format( + "authz/ns/%s%s", + ns.getName(), force ? FORCE : ""), OK); } private int doPost(AafObject obj, String uri, int expect) { @@ -136,7 +147,7 @@ public class AafServiceImpl extends BaseLoggingClass implements AafService { case 404: logger.warn("Object not found...ignore"); break; - case 200: + case OK: logger.info("expected response"); break; default: