X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=portal-BE%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Fportal%2Fcontroller%2FTicketEventController.java;fp=portal-BE%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Fportal%2Fcontroller%2FTicketEventController.java;h=8610af230d50f51bc49d49b73a6492096832cecb;hb=f7e300301a4a5f01585677657b96a80338cdf03d;hp=1e8945b06273ecfa1c361e0aa74a62e4592bd720;hpb=cbc896f277fcf24dc52fcd591667e4ede1e9a9ab;p=portal.git diff --git a/portal-BE/src/main/java/org/onap/portal/controller/TicketEventController.java b/portal-BE/src/main/java/org/onap/portal/controller/TicketEventController.java index 1e8945b0..8610af23 100644 --- a/portal-BE/src/main/java/org/onap/portal/controller/TicketEventController.java +++ b/portal-BE/src/main/java/org/onap/portal/controller/TicketEventController.java @@ -64,6 +64,7 @@ import org.onap.portal.service.epNotification.EpNotificationService; import org.onap.portal.service.user.FnUserService; import org.onap.portal.utils.EPCommonSystemProperties; import org.onap.portal.utils.PortalConstants; +import org.onap.portal.validation.DataValidator; import org.onap.portal.validation.SecureString; import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate; import org.onap.portalsdk.core.util.SystemProperties; @@ -86,14 +87,16 @@ public class TicketEventController { private static final String EVENT_DATE = "eventDate"; private final ObjectMapper objectMapper = new ObjectMapper(); - private static final ValidatorFactory VALIDATOR_FACTORY = Validation.buildDefaultValidatorFactory(); + private final DataValidator dataValidator; private final FnUserService fnUserService; private final EpNotificationService epNotificationService; @Autowired - public TicketEventController(final FnUserService fnUserService, + public TicketEventController(final DataValidator dataValidator, + final FnUserService fnUserService, final EpNotificationService epNotificationService) { + this.dataValidator = dataValidator; this.fnUserService = fnUserService; this.epNotificationService = epNotificationService; } @@ -108,16 +111,10 @@ public class TicketEventController { logger.debug(EELFLoggerDelegate.debugLogger, "Ticket Event notification" + ticketEventJson); PortalRestResponse portalResponse = new PortalRestResponse<>(); - if (ticketEventJson != null) { - SecureString secureString = new SecureString(ticketEventJson); - Validator validator = VALIDATOR_FACTORY.getValidator(); - - Set> constraintViolations = validator.validate(secureString); - if (!constraintViolations.isEmpty()) { - portalResponse.setStatus(PortalRestStatusEnum.ERROR); - portalResponse.setMessage("Data is not valid"); - return portalResponse; - } + if(!dataValidator.isValid(ticketEventJson)){ + portalResponse.setStatus(PortalRestStatusEnum.ERROR); + portalResponse.setMessage("Data is not valid"); + return portalResponse; } try {