X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=models-interactions%2Fmodel-impl%2Fsdnr%2Fsrc%2Ftest%2Fjava%2Forg%2Fonap%2Fpolicy%2Fsdnr%2FPciResponseTest.java;h=bd96e8e4c6d2cf089de3f783a72d0ddcf5398c77;hb=248a660d61fa03caa4710cf8cfe144eb245b807b;hp=b9ecec33c17253cde7778f34f163c0e7b27062c4;hpb=2141dc0263940c94bf4265c6ca0072d9130a8ead;p=policy%2Fmodels.git

diff --git a/models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciResponseTest.java b/models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciResponseTest.java
index b9ecec33c..bd96e8e4c 100644
--- a/models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciResponseTest.java
+++ b/models-interactions/model-impl/sdnr/src/test/java/org/onap/policy/sdnr/PciResponseTest.java
@@ -4,13 +4,14 @@
  * ================================================================================
  * Copyright (C) 2018 Wipro Limited Intellectual Property. All rights reserved.
  * Modifications Copyright (C) 2019 Nordix Foundation.
+ * Modifications Copyright (C) 2019-2020 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -21,10 +22,11 @@
 
 package org.onap.policy.sdnr;
 
+import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotEquals;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;
-import static org.junit.Assert.assertTrue;
 
 import org.junit.Test;
 
@@ -39,13 +41,13 @@ public class PciResponseTest {
     @Test
     public void testHashCode() {
         PciResponse response = new PciResponse();
-        assertTrue(response.hashCode() != 0);
+        assertNotEquals(0, response.hashCode());
         response.setCommonHeader(new PciCommonHeader());
-        assertTrue(response.hashCode() != 0);
+        assertNotEquals(0, response.hashCode());
         response.setPayload(responsePayload);
-        assertTrue(response.hashCode() != 0);
+        assertNotEquals(0, response.hashCode());
         response.setStatus(null);
-        assertTrue(response.hashCode() != 0);
+        assertNotEquals(0, response.hashCode());
     }
 
     @Test
@@ -65,43 +67,43 @@ public class PciResponseTest {
     @Test
     public void testEqualsObject() {
         PciResponse response = new PciResponse();
-        assertTrue(response.equals(response));
-        assertFalse(response.equals(null));
-        assertFalse(response.equals(new Object()));
+        assertEquals(response, response);
+        assertNotEquals(response, null);
+        assertNotEquals(response, new Object());
 
         PciResponse response2 = new PciResponse();
-        assertTrue(response.equals(response2));
+        assertEquals(response, response2);
 
         response.setCommonHeader(new PciCommonHeader());
-        assertFalse(response.equals(response2));
+        assertNotEquals(response, response2);
         response2.setCommonHeader(response.getCommonHeader());
-        assertTrue(response.equals(response2));
+        assertEquals(response, response2);
 
         response.setPayload(responsePayload);
-        assertFalse(response.equals(response2));
+        assertNotEquals(response, response2);
         response2.setPayload(response.getPayload());
-        assertTrue(response.equals(response2));
+        assertEquals(response, response2);
 
         response.setCommonHeader(null);
-        assertFalse(response.equals(response2));
+        assertNotEquals(response, response2);
         response2.setCommonHeader(null);
-        assertTrue(response.equals(response2));
+        assertEquals(response, response2);
 
         response.setPayload(null);
-        assertFalse(response.equals(response2));
+        assertNotEquals(response, response2);
         response2.setPayload(response.getPayload());
-        assertTrue(response.equals(response2));
+        assertEquals(response, response2);
 
         response.setStatus(null);
-        assertFalse(response.equals(response2));
+        assertNotEquals(response, response2);
         response2.setStatus(response.getStatus());
-        assertTrue(response.equals(response2));
+        assertEquals(response, response2);
 
-        Status status = new Status();
-        status.setCode(5);
-        response.setStatus(status);
+        Status stat = new Status();
+        stat.setCode(5);
+        response.setStatus(stat);
         response2.setStatus(new Status());
-        assertFalse(response.equals(response2));
+        assertNotEquals(response, response2);
     }
 
     @Test
@@ -112,7 +114,7 @@ public class PciResponseTest {
 
         PciResponse response = new PciResponse(request);
 
-        assertTrue(response.getCommonHeader().equals(request.getCommonHeader()));
+        assertEquals(response.getCommonHeader(), request.getCommonHeader());
     }
 
 }