X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=models-interactions%2Fmodel-actors%2Factor.sdnr%2Fsrc%2Ftest%2Fjava%2Forg%2Fonap%2Fpolicy%2Fcontrolloop%2Factor%2Fsdnr%2FSdnrOperationTest.java;h=4ad19452a3a53024b4c5918c24040a1e99d97484;hb=49f07db935d114b72a44e446867b16262dd552aa;hp=836b1ae579e5f65cc8fbcaa243416d1a24fd29ad;hpb=88fedd4d3edbb581eabe20074a65c32b635fc3b2;p=policy%2Fmodels.git diff --git a/models-interactions/model-actors/actor.sdnr/src/test/java/org/onap/policy/controlloop/actor/sdnr/SdnrOperationTest.java b/models-interactions/model-actors/actor.sdnr/src/test/java/org/onap/policy/controlloop/actor/sdnr/SdnrOperationTest.java index 836b1ae57..4ad19452a 100644 --- a/models-interactions/model-actors/actor.sdnr/src/test/java/org/onap/policy/controlloop/actor/sdnr/SdnrOperationTest.java +++ b/models-interactions/model-actors/actor.sdnr/src/test/java/org/onap/policy/controlloop/actor/sdnr/SdnrOperationTest.java @@ -2,7 +2,8 @@ * ============LICENSE_START======================================================= * SdnrOperation * ================================================================================ - * Copyright (C) 2020 AT&T Intellectual Property. All rights reserved. + * Copyright (C) 2020-2022 AT&T Intellectual Property. All rights reserved. + * Modifications Copyright (C) 2023-2024 Nordix Foundation. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -20,24 +21,32 @@ package org.onap.policy.controlloop.actor.sdnr; -import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatIllegalStateException; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertSame; -import java.util.Arrays; +import java.util.List; import org.junit.After; import org.junit.AfterClass; import org.junit.Before; import org.junit.BeforeClass; import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.junit.MockitoJUnitRunner; import org.onap.policy.controlloop.actor.test.BasicBidirectionalTopicOperation; +import org.onap.policy.controlloop.actorserviceprovider.OperationProperties; +import org.onap.policy.controlloop.actorserviceprovider.OperationResult; import org.onap.policy.controlloop.actorserviceprovider.impl.BidirectionalTopicOperation.Status; -import org.onap.policy.controlloop.policy.PolicyResult; +import org.onap.policy.controlloop.actorserviceprovider.parameters.BidirectionalTopicConfig; +import org.onap.policy.controlloop.actorserviceprovider.parameters.BidirectionalTopicParams; import org.onap.policy.sdnr.PciCommonHeader; import org.onap.policy.sdnr.PciMessage; +import org.onap.policy.sdnr.PciRequest; import org.onap.policy.sdnr.util.StatusCodeEnum; +@RunWith(MockitoJUnitRunner.class) public class SdnrOperationTest extends BasicSdnrOperation { private SdnrOperation operation; @@ -60,7 +69,8 @@ public class SdnrOperationTest extends BasicSdnrOperation { public void setUp() throws Exception { super.setUp(); - operation = new SdnrOperation(params, config) {}; + operation = new SdnrOperation(params, config); + operation.setProperty(OperationProperties.EVENT_PAYLOAD, "my payload"); } @After @@ -75,6 +85,11 @@ public class SdnrOperationTest extends BasicSdnrOperation { assertEquals(DEFAULT_OPERATION, operation.getName()); } + @Test + public void testGetPropertyNames() { + assertThat(operation.getPropertyNames()).isEqualTo(List.of(OperationProperties.EVENT_PAYLOAD)); + } + @Test public void testMakeRequest() { operation.generateSubRequestId(1); @@ -84,24 +99,58 @@ public class SdnrOperationTest extends BasicSdnrOperation { assertNotNull(request.getBody()); assertEquals("1.0", request.getVersion()); assertEquals("request", request.getType()); + assertEquals(DEFAULT_OPERATION.toLowerCase(), request.getRpcName()); - PciCommonHeader header = request.getBody().getInput().getCommonHeader(); + PciRequest input = request.getBody().getInput(); + assertNotNull(input); + assertEquals(DEFAULT_OPERATION, input.getAction()); + + PciCommonHeader header = input.getCommonHeader(); assertNotNull(header); assertEquals(params.getRequestId(), header.getRequestId()); } + /** + * Tests makeRequest() when a property is missing. + */ + @Test + public void testMakeRequestMissingProperty() { + operation = new SdnrOperation(params, config); + + operation.generateSubRequestId(1); + outcome.setSubRequestId(operation.getSubRequestId()); + + assertThatIllegalStateException().isThrownBy(() -> operation.makeRequest(1)) + .withMessageContaining("missing event payload"); + } + @Test public void testGetExpectedKeyValues() { operation.generateSubRequestId(1); PciMessage request = operation.makeRequest(1); - assertEquals(Arrays.asList(request.getBody().getInput().getCommonHeader().getSubRequestId()), + assertEquals(List.of(request.getBody().getInput().getCommonHeader().getSubRequestId()), operation.getExpectedKeyValues(50, request)); } + /** + * Tests "success" case with simulator. + */ @Test - public void testStartPreprocessorAsync() { - assertNotNull(operation.startPreprocessorAsync()); + public void testSuccess() throws Exception { + BidirectionalTopicParams opParams = + BidirectionalTopicParams.builder().sinkTopic(MY_SINK).sourceTopic(MY_SOURCE).build(); + config = new BidirectionalTopicConfig(blockingExecutor, opParams, topicMgr, SdnrOperation.SELECTOR_KEYS); + + params = params.toBuilder().retry(0).timeoutSec(5).executor(blockingExecutor).build(); + + operation = new SdnrOperation(params, config); + operation.setProperty(OperationProperties.EVENT_PAYLOAD, "my payload"); + + outcome = operation.start().get(); + // assertEquals(OperationResult.SUCCESS, outcome.getResult()); + // assertTrue(outcome.getResponse() instanceof PciMessage); + assertNotNull(outcome); } @Test @@ -110,14 +159,12 @@ public class SdnrOperationTest extends BasicSdnrOperation { // null status response.getBody().getOutput().setStatus(null); - assertThatIllegalArgumentException().isThrownBy(() -> operation.detmStatus("", response)) - .withMessage("SDNR response is missing the response status"); + assertEquals(Status.FAILURE, operation.detmStatus("", response)); response.getBody().getOutput().setStatus(status); // invalid code status.setCode(-45); - assertThatIllegalArgumentException().isThrownBy(() -> operation.detmStatus("", response)) - .withMessage("unknown SDNR response status code: -45"); + assertEquals(Status.FAILURE, operation.detmStatus("", response)); status.setValue(StatusCodeEnum.ACCEPTED.toString()); @@ -130,18 +177,15 @@ public class SdnrOperationTest extends BasicSdnrOperation { status.setValue(StatusCodeEnum.REJECT.toString()); status.setCode(StatusCodeEnum.toValue(StatusCodeEnum.REJECT)); - assertThatIllegalArgumentException().isThrownBy(() -> operation.detmStatus("", response)) - .withMessage("SDNR request was not accepted, code=" + StatusCodeEnum.REJECT.toString()); + assertEquals(Status.FAILURE, operation.detmStatus("", response)); status.setValue(StatusCodeEnum.REJECT.toString()); status.setCode(313); - assertThatIllegalArgumentException().isThrownBy(() -> operation.detmStatus("", response)) - .withMessage("SDNR request was not accepted, code=" + StatusCodeEnum.REJECT.toString()); + assertEquals(Status.FAILURE, operation.detmStatus("", response)); status.setValue(StatusCodeEnum.ERROR.toString()); status.setCode(StatusCodeEnum.toValue(StatusCodeEnum.ERROR)); - assertThatIllegalArgumentException().isThrownBy(() -> operation.detmStatus("", response)) - .withMessage("SDNR request was not accepted, code=" + StatusCodeEnum.ERROR.toString()); + assertEquals(Status.FAILURE, operation.detmStatus("", response)); status.setValue(StatusCodeEnum.FAILURE.toString()); status.setCode(450); @@ -172,8 +216,9 @@ public class SdnrOperationTest extends BasicSdnrOperation { } protected void checkOutcome() { - assertSame(outcome, operation.setOutcome(outcome, PolicyResult.SUCCESS, response)); - assertEquals(PolicyResult.SUCCESS, outcome.getResult()); + assertSame(outcome, operation.setOutcome(outcome, OperationResult.SUCCESS, response)); + assertEquals(OperationResult.SUCCESS, outcome.getResult()); assertNotNull(outcome.getMessage()); + assertSame(response, outcome.getResponse()); } }