X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=models-interactions%2Fmodel-actors%2Factor.appc%2Fsrc%2Ftest%2Fjava%2Forg%2Fonap%2Fpolicy%2Fcontrolloop%2Factor%2Fappc%2FAppcActorTest.java;h=5d9ce0d7a2590d513db0565ed107c08f59c3772b;hb=49f07db935d114b72a44e446867b16262dd552aa;hp=47773f23f7aa28ed2f2b5846e1282ff99c72ea83;hpb=c6012167b9692eb38bcb479f233543e93c51c998;p=policy%2Fmodels.git diff --git a/models-interactions/model-actors/actor.appc/src/test/java/org/onap/policy/controlloop/actor/appc/AppcActorTest.java b/models-interactions/model-actors/actor.appc/src/test/java/org/onap/policy/controlloop/actor/appc/AppcActorTest.java index 47773f23f..5d9ce0d7a 100644 --- a/models-interactions/model-actors/actor.appc/src/test/java/org/onap/policy/controlloop/actor/appc/AppcActorTest.java +++ b/models-interactions/model-actors/actor.appc/src/test/java/org/onap/policy/controlloop/actor/appc/AppcActorTest.java @@ -3,7 +3,7 @@ * ONAP * ================================================================================ * Copyright (C) 2017-2020 AT&T Intellectual Property. All rights reserved. - * Modifications Copyright (C) 2019 Nordix Foundation. + * Modifications Copyright (C) 2019, 2023-2024 Nordix Foundation. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -22,123 +22,24 @@ package org.onap.policy.controlloop.actor.appc; import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertTrue; -import java.time.Instant; -import java.util.Arrays; -import java.util.HashMap; -import java.util.UUID; -import java.util.stream.Collectors; -import org.junit.AfterClass; -import org.junit.BeforeClass; +import java.util.stream.Stream; import org.junit.Test; -import org.onap.policy.appc.Request; -import org.onap.policy.appc.Response; -import org.onap.policy.appc.ResponseCode; -import org.onap.policy.appc.ResponseStatus; -import org.onap.policy.appc.util.Serialization; -import org.onap.policy.common.endpoints.http.server.HttpServletServerFactoryInstance; -import org.onap.policy.controlloop.ControlLoopEventStatus; -import org.onap.policy.controlloop.ControlLoopOperation; -import org.onap.policy.controlloop.ControlLoopTargetType; -import org.onap.policy.controlloop.VirtualControlLoopEvent; +import org.junit.runner.RunWith; +import org.mockito.junit.MockitoJUnitRunner; import org.onap.policy.controlloop.actor.test.BasicActor; -import org.onap.policy.controlloop.policy.Policy; -import org.onap.policy.controlloop.policy.Target; -import org.onap.policy.controlloop.policy.TargetType; -import org.onap.policy.simulators.Util; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; +@RunWith(MockitoJUnitRunner.class) public class AppcActorTest extends BasicActor { - private static final String GENERIC_VNF_ID = "generic-vnf.vnf-id"; - - private static final String MODIFY_CONFIG = "ModifyConfig"; - - private static final String JSON_OUTPUT = "JSON Output: \n"; - - private static final Logger logger = LoggerFactory.getLogger(AppcActorTest.class); - - private static final VirtualControlLoopEvent onsetEvent; - private static final ControlLoopOperation operation; - private static final Policy policy; - - private static final String KEY1 = "my-keyA"; - private static final String KEY2 = "my-keyB"; - private static final String SUBKEY = "sub-key"; - - private static final String VALUE1 = "'my-value'".replace('\'', '"'); - private static final String VALUE2 = "{'sub-key':20}".replace('\'', '"'); - private static final String SUBVALUE = "20"; - - static { - /* - * Construct an onset with an AAI subtag containing generic-vnf.vnf-id and a - * target type of VM. - */ - onsetEvent = new VirtualControlLoopEvent(); - onsetEvent.setClosedLoopControlName("closedLoopControlName-Test"); - onsetEvent.setRequestId(UUID.randomUUID()); - onsetEvent.setClosedLoopEventClient("tca.instance00001"); - onsetEvent.setTargetType(ControlLoopTargetType.VNF); - onsetEvent.setTarget("generic-vnf.vnf-name"); - onsetEvent.setFrom("DCAE"); - onsetEvent.setClosedLoopAlarmStart(Instant.now()); - onsetEvent.setAai(new HashMap<>()); - onsetEvent.getAai().put("generic-vnf.vnf-name", "fw0001vm001fw001"); - onsetEvent.setClosedLoopEventStatus(ControlLoopEventStatus.ONSET); - - /* Construct an operation with an APPC actor and ModifyConfig operation. */ - operation = new ControlLoopOperation(); - operation.setActor("APPC"); - operation.setOperation(MODIFY_CONFIG); - operation.setTarget("VNF"); - operation.setEnd(Instant.now()); - operation.setSubRequestId("1"); - - /* Construct a policy specifying to modify configuration. */ - policy = new Policy(); - policy.setName("Modify Packet Generation Config"); - policy.setDescription("Upon getting the trigger event, modify packet gen config"); - policy.setActor("APPC"); - policy.setTarget(new Target(TargetType.VNF)); - policy.getTarget().setResourceID("Eace933104d443b496b8.nodes.heat.vpg"); - policy.setRecipe(MODIFY_CONFIG); - policy.setPayload(null); - policy.setRetry(2); - policy.setTimeout(300); - - } - - /** - * Set up before test class. - * - * @throws Exception if the A&AI simulator cannot be started - */ - @BeforeClass - public static void setUpSimulator() throws Exception { - Util.buildAaiSim(); - } - - /** - * Tear down after test class. - */ - @AfterClass - public static void tearDownSimulator() { - HttpServletServerFactoryInstance.getServerFactory().destroy(); - } - @Test public void testConstructor() { AppcActor prov = new AppcActor(); assertEquals(0, prov.getSequenceNumber()); // verify that it has the operators we expect - var expected = Arrays.asList(ModifyConfigOperation.NAME).stream().sorted().collect(Collectors.toList()); - var actual = prov.getOperationNames().stream().sorted().collect(Collectors.toList()); + var expected = Stream.of(ModifyConfigOperation.NAME).toList(); + var actual = prov.getOperationNames().stream().sorted().toList(); assertEquals(expected.toString(), actual.toString()); } @@ -148,112 +49,4 @@ public class AppcActorTest extends BasicActor { // verify that it all plugs into the ActorService verifyActorService(AppcActor.NAME, "service.yaml"); } - - @Test - public void testConstructModifyConfigRequest() { - policy.setPayload(new HashMap<>()); - policy.getPayload().put(KEY1, VALUE1); - policy.getPayload().put(KEY2, VALUE2); - - Request appcRequest; - appcRequest = AppcActor.constructRequest(onsetEvent, operation, policy, "vnf01"); - - /* The service provider must return a non null APPC request */ - assertNotNull(appcRequest); - - /* A common header is required and cannot be null */ - assertNotNull(appcRequest.getCommonHeader()); - assertEquals(appcRequest.getCommonHeader().getRequestId(), onsetEvent.getRequestId()); - - /* An action is required and cannot be null */ - assertNotNull(appcRequest.getAction()); - assertEquals(MODIFY_CONFIG, appcRequest.getAction()); - - /* A payload is required and cannot be null */ - assertNotNull(appcRequest.getPayload()); - assertTrue(appcRequest.getPayload().containsKey(GENERIC_VNF_ID)); - assertNotNull(appcRequest.getPayload().get(GENERIC_VNF_ID)); - assertTrue(appcRequest.getPayload().containsKey(KEY1)); - assertTrue(appcRequest.getPayload().containsKey(KEY2)); - - logger.debug("APPC Request: \n" + appcRequest.toString()); - - /* Print out request as json to make sure serialization works */ - String jsonRequest = Serialization.gsonPretty.toJson(appcRequest); - logger.debug(JSON_OUTPUT + jsonRequest); - - /* The JSON string must contain the following fields */ - assertTrue(jsonRequest.contains("CommonHeader")); - assertTrue(jsonRequest.contains("Action")); - assertTrue(jsonRequest.contains(MODIFY_CONFIG)); - assertTrue(jsonRequest.contains("Payload")); - assertTrue(jsonRequest.contains(GENERIC_VNF_ID)); - assertTrue(jsonRequest.contains(KEY1)); - assertTrue(jsonRequest.contains(KEY2)); - assertTrue(jsonRequest.contains(SUBKEY)); - assertTrue(jsonRequest.contains(SUBVALUE)); - assertFalse(jsonRequest.contains(SUBVALUE + ".0")); - - Response appcResponse = new Response(appcRequest); - appcResponse.setStatus(new ResponseStatus()); - appcResponse.getStatus().setCode(ResponseCode.SUCCESS.getValue()); - appcResponse.getStatus().setDescription("AppC success"); - /* Print out request as json to make sure serialization works */ - String jsonResponse = Serialization.gsonPretty.toJson(appcResponse); - logger.debug(JSON_OUTPUT + jsonResponse); - } - - @Test - public void testConstructModifyConfigRequest_NullPayload() { - - Request appcRequest; - appcRequest = AppcActor.constructRequest(onsetEvent, operation, policy, "vnf01"); - - /* The service provider must return a non null APPC request */ - assertNotNull(appcRequest); - - /* A common header is required and cannot be null */ - assertNotNull(appcRequest.getCommonHeader()); - assertEquals(appcRequest.getCommonHeader().getRequestId(), onsetEvent.getRequestId()); - - /* An action is required and cannot be null */ - assertNotNull(appcRequest.getAction()); - assertEquals(MODIFY_CONFIG, appcRequest.getAction()); - - /* A payload is required and cannot be null */ - assertNotNull(appcRequest.getPayload()); - assertTrue(appcRequest.getPayload().containsKey(GENERIC_VNF_ID)); - assertNotNull(appcRequest.getPayload().get(GENERIC_VNF_ID)); - - logger.debug("APPC Request: \n" + appcRequest.toString()); - - /* Print out request as json to make sure serialization works */ - String jsonRequest = Serialization.gsonPretty.toJson(appcRequest); - logger.debug(JSON_OUTPUT + jsonRequest); - - /* The JSON string must contain the following fields */ - assertTrue(jsonRequest.contains("CommonHeader")); - assertTrue(jsonRequest.contains("Action")); - assertTrue(jsonRequest.contains(MODIFY_CONFIG)); - assertTrue(jsonRequest.contains("Payload")); - assertTrue(jsonRequest.contains(GENERIC_VNF_ID)); - - Response appcResponse = new Response(appcRequest); - appcResponse.setStatus(new ResponseStatus()); - appcResponse.getStatus().setCode(ResponseCode.SUCCESS.getValue()); - appcResponse.getStatus().setDescription("AppC success"); - /* Print out request as json to make sure serialization works */ - String jsonResponse = Serialization.gsonPretty.toJson(appcResponse); - logger.debug(JSON_OUTPUT + jsonResponse); - } - - @Test - public void testMethods() { - AppcActor sp = new AppcActor(); - - assertEquals("APPC", sp.actor()); - assertEquals(4, sp.recipes().size()); - assertEquals("VM", sp.recipeTargets("Restart").get(0)); - assertEquals(0, sp.recipePayloads("Restart").size()); - } }