X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=models-interactions%2Fmodel-actors%2Factor.aai%2Fsrc%2Ftest%2Fjava%2Forg%2Fonap%2Fpolicy%2Fcontrolloop%2Factor%2Faai%2FAaiCustomQueryOperationTest.java;h=61155ce07be598dd4cc605a6ed6bf78a94b5d83e;hb=19ef8b24a98c09a349e6ae7309f535a0135463f6;hp=c95425e7abdffaa7cd41f4ac1816641bafeea417;hpb=85a2fee4074903012e77f78e26328b9a03a8bdfc;p=policy%2Fmodels.git diff --git a/models-interactions/model-actors/actor.aai/src/test/java/org/onap/policy/controlloop/actor/aai/AaiCustomQueryOperationTest.java b/models-interactions/model-actors/actor.aai/src/test/java/org/onap/policy/controlloop/actor/aai/AaiCustomQueryOperationTest.java index c95425e7a..61155ce07 100644 --- a/models-interactions/model-actors/actor.aai/src/test/java/org/onap/policy/controlloop/actor/aai/AaiCustomQueryOperationTest.java +++ b/models-interactions/model-actors/actor.aai/src/test/java/org/onap/policy/controlloop/actor/aai/AaiCustomQueryOperationTest.java @@ -20,130 +20,158 @@ package org.onap.policy.controlloop.actor.aai; +import static org.assertj.core.api.Assertions.assertThat; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertSame; +import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; import java.util.Arrays; import java.util.List; import java.util.Map; +import java.util.TreeMap; import java.util.concurrent.CompletableFuture; import java.util.concurrent.ExecutionException; import java.util.concurrent.TimeoutException; +import javax.ws.rs.client.InvocationCallback; +import org.junit.AfterClass; import org.junit.Before; +import org.junit.BeforeClass; import org.junit.Test; -import org.mockito.Mock; import org.onap.policy.aai.AaiConstants; import org.onap.policy.aai.AaiCqResponse; -import org.onap.policy.common.endpoints.http.client.HttpClientFactory; +import org.onap.policy.common.endpoints.http.client.HttpClientFactoryInstance; import org.onap.policy.common.utils.coder.StandardCoder; -import org.onap.policy.common.utils.coder.StandardCoderObject; -import org.onap.policy.controlloop.actorserviceprovider.Operation; import org.onap.policy.controlloop.actorserviceprovider.OperationOutcome; -import org.onap.policy.controlloop.actorserviceprovider.Util; -import org.onap.policy.controlloop.actorserviceprovider.impl.HttpOperator; -import org.onap.policy.controlloop.actorserviceprovider.parameters.ControlLoopOperationParams; +import org.onap.policy.controlloop.actorserviceprovider.OperationProperties; +import org.onap.policy.controlloop.actorserviceprovider.OperationResult; +import org.onap.policy.controlloop.actorserviceprovider.parameters.HttpConfig; import org.onap.policy.controlloop.actorserviceprovider.parameters.HttpParams; -import org.onap.policy.controlloop.actorserviceprovider.spi.Actor; -import org.onap.policy.controlloop.policy.PolicyResult; -public class AaiCustomQueryOperationTest extends BasicAaiOperator> { +public class AaiCustomQueryOperationTest extends BasicAaiOperation { private static final StandardCoder coder = new StandardCoder(); private static final String MY_LINK = "my-link"; - @Mock - private Actor tenantActor; - private AaiCustomQueryOperation oper; public AaiCustomQueryOperationTest() { super(AaiConstants.ACTOR_NAME, AaiCustomQueryOperation.NAME); } + @BeforeClass + public static void setUpBeforeClass() throws Exception { + initBeforeClass(); + } + + @AfterClass + public static void tearDownAfterClass() { + destroyAfterClass(); + } + /** * Sets up. */ @Before public void setUp() throws Exception { - super.setUp(); + super.setUpBasic(); + + oper = new AaiCustomQueryOperation(params, config); + oper.setProperty(OperationProperties.AAI_VSERVER_LINK, MY_LINK); + } + + /** + * Tests "success" case with simulator. + */ + @Test + public void testSuccess() throws Exception { + HttpParams opParams = HttpParams.builder().clientName(MY_CLIENT).path("v16/query").build(); + config = new HttpConfig(blockingExecutor, opParams, HttpClientFactoryInstance.getClientFactory()); - MyTenantOperator tenantOperator = new MyTenantOperator(); + params = params.toBuilder().retry(0).timeoutSec(5).executor(blockingExecutor).preprocessed(true).build(); + oper = new AaiCustomQueryOperation(params, config); - when(service.getActor(AaiConstants.ACTOR_NAME)).thenReturn(tenantActor); - when(tenantActor.getOperator(AaiGetOperation.TENANT)).thenReturn(tenantOperator); + oper.setProperty(OperationProperties.AAI_VSERVER_LINK, MY_LINK); - oper = new AaiCustomQueryOperation(params, operator); + outcome = oper.start().get(); + assertEquals(OperationResult.SUCCESS, outcome.getResult()); + + assertNotNull(outcome.getResponse()); } @Test - public void testAaiCustomQueryOperation() { + public void testConstructor() { assertEquals(AaiConstants.ACTOR_NAME, oper.getActorName()); assertEquals(AaiCustomQueryOperation.NAME, oper.getName()); } @Test - public void testStartOperationAsync_testStartPreprocessorAsync_testMakeRequest_testPostProcess() throws Exception { + public void testGetPropertyNames() { + assertThat(oper.getPropertyNames()).isEqualTo(List.of(OperationProperties.AAI_VSERVER_LINK)); + } + + @Test + public void testGenerateSubRequestId() { + oper.generateSubRequestId(3); + assertEquals("3", oper.getSubRequestId()); + } + + @Test + @SuppressWarnings("unchecked") + public void testStartOperationAsync_testMakeRequest() throws Exception { // need two responses when(rawResponse.readEntity(String.class)).thenReturn(makeTenantReply()).thenReturn(makeCqReply()); - when(client.get(any(), any(), any())).thenAnswer(provideResponse(rawResponse)); - when(client.put(any(), any(), any(), any())).thenAnswer(provideResponse(rawResponse)); + when(webAsync.get(any(InvocationCallback.class))).thenAnswer(provideResponse(rawResponse)); + when(webAsync.put(any(), any(InvocationCallback.class))).thenAnswer(provideResponse(rawResponse, 1)); CompletableFuture future2 = oper.start(); - assertEquals(PolicyResult.SUCCESS, getResult(future2)); - - // tenant response should have been cached within the context - assertNotNull(context.getProperty(AaiGetOperation.getTenantKey(TARGET_ENTITY))); + assertEquals(OperationResult.SUCCESS, getResult(future2)); - // custom query response should have been cached within the context - AaiCqResponse cqData = context.getProperty(AaiCqResponse.CONTEXT_KEY); - assertNotNull(cqData); + assertEquals("1", future2.get().getSubRequestId()); } - /** - * Tests when preprocessor step is not needed. - */ @Test - public void testStartOperationAsync_testStartPreprocessorAsyncNotNeeded() throws Exception { - // pre-load the tenant data - final StandardCoderObject data = preloadTenantData(); + public void testMakeHeaders() { + verifyHeaders(oper.makeHeaders()); + } - // only need one response + @Test + @SuppressWarnings("unchecked") + public void testMakeRequest_testGetVserverLink() throws Exception { when(rawResponse.readEntity(String.class)).thenReturn(makeCqReply()); - when(client.put(any(), any(), any(), any())).thenAnswer(provideResponse(rawResponse)); + when(webAsync.put(any(), any(InvocationCallback.class))).thenAnswer(provideResponse(rawResponse, 1)); - CompletableFuture future2 = oper.start(); + oper.start(); + executor.runAll(100); + + verify(webAsync).put(requestCaptor.capture(), any(InvocationCallback.class)); - assertEquals(PolicyResult.SUCCESS, getResult(future2)); + String reqText = requestCaptor.getValue().getEntity(); + Map reqMap = coder.decode(reqText, Map.class); - // should not have replaced tenant response - assertSame(data, context.getProperty(AaiGetOperation.getTenantKey(TARGET_ENTITY))); + // sort the request fields so they match the order in cq.json + Map request = new TreeMap<>(reqMap); - // custom query response should have been cached within the context - AaiCqResponse cqData = context.getProperty(AaiCqResponse.CONTEXT_KEY); - assertNotNull(cqData); + verifyRequest("cq.json", request); } @Test - public void testMakeHeaders() { - verifyHeaders(oper.makeHeaders()); + public void testGetVserverLink() throws Exception { + oper.setProperty(OperationProperties.AAI_VSERVER_LINK, MY_LINK); + assertEquals(MY_LINK, oper.getVserverLink()); } @Test - public void testMakeRequestNoResourceLink() throws Exception { - // pre-load EMPTY tenant data - preloadTenantData(new StandardCoderObject()); + public void testSetOutcome() { + outcome = oper.setOutcome(params.makeOutcome(null), OperationResult.SUCCESS, null, null); + assertNull(outcome.getResponse()); - when(rawResponse.readEntity(String.class)).thenReturn(makeCqReply()); - when(client.put(any(), any(), any(), any())).thenAnswer(provideResponse(rawResponse)); - - CompletableFuture future2 = oper.start(); - - assertEquals(PolicyResult.FAILURE_EXCEPTION, getResult(future2)); + outcome = oper.setOutcome(params.makeOutcome(null), OperationResult.SUCCESS, null, "{}"); + assertTrue(outcome.getResponse() instanceof AaiCqResponse); } private String makeTenantReply() throws Exception { @@ -158,17 +186,8 @@ public class AaiCustomQueryOperationTest extends BasicAaiOperator future2) + private OperationResult getResult(CompletableFuture future2) throws InterruptedException, ExecutionException, TimeoutException { executor.runAll(100); @@ -176,25 +195,4 @@ public class AaiCustomQueryOperationTest extends BasicAaiOperator