X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=ice_validator%2Ftests%2Ftest_network_format_use_get_param_or_get_resource.py;fp=ice_validator%2Ftests%2Ftest_network_format_use_get_param_or_get_resource.py;h=e30b34481da0894fdb481c7e3e8f34dd5a8745f8;hb=cc21b8b08b6dbcec577bfb26ff397ac899da8002;hp=0000000000000000000000000000000000000000;hpb=6755f61e44870ff65de0630a403f7b4ddfea4071;p=vvp%2Fvalidation-scripts.git diff --git a/ice_validator/tests/test_network_format_use_get_param_or_get_resource.py b/ice_validator/tests/test_network_format_use_get_param_or_get_resource.py new file mode 100644 index 0000000..e30b344 --- /dev/null +++ b/ice_validator/tests/test_network_format_use_get_param_or_get_resource.py @@ -0,0 +1,80 @@ +# -*- coding: utf8 -*- +# ============LICENSE_START======================================================= +# org.onap.vvp/validation-scripts +# =================================================================== +# Copyright © 2017 AT&T Intellectual Property. All rights reserved. +# =================================================================== +# +# Unless otherwise specified, all software contained herein is licensed +# under the Apache License, Version 2.0 (the “License”); +# you may not use this software except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# +# +# Unless otherwise specified, all documentation contained herein is licensed +# under the Creative Commons License, Attribution 4.0 Intl. (the “License”); +# you may not use this documentation except in compliance with the License. +# You may obtain a copy of the License at +# +# https://creativecommons.org/licenses/by/4.0/ +# +# Unless required by applicable law or agreed to in writing, documentation +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# ============LICENSE_END============================================ +# +# ECOMP is a trademark and service mark of AT&T Intellectual Property. +# + +import pytest +import yaml + + +def test_network_format_use_get_param_or_get_resource(heat_template): + ''' + Make sure all network properties only use get_param + or get_resource of an internal network + ''' + + with open(heat_template) as fh: + yml = yaml.load(fh) + + # skip if resources are not defined + if "resources" not in yml: + pytest.skip("No resources specified in the heat template") + + invalid_ports = [] + for k1, v1 in yml["resources"].items(): + if not isinstance(v1, dict): + continue + if "properties" not in v1: + continue + if v1.get("type") != "OS::Neutron::Port": + continue + + valid_network = True + for k2, v2 in v1["properties"].items(): + if k2 != "network": + continue + if "get_resource" in v2: + if not v2["get_resource"].startswith('int_'): + valid_network = False + elif "get_param" not in v2: + valid_network = False + + if not valid_network: + invalid_ports.append(k1) + + assert not set(invalid_ports)