X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=ecomp-portal-BE-common%2Fsrc%2Ftest%2Fjava%2Forg%2Fonap%2Fportalapp%2Fportal%2Fcontroller%2FExternalAppsRestfulControllerTest.java;h=890319dc67176439cf5fb184d98bd68738e29b7f;hb=HEAD;hp=d8f98bb98c0a5ed3622f37fa24c54742a10ef553;hpb=0f32f237134aa2c455f30ad0d3ecb6ddfcea4d21;p=portal.git

diff --git a/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/controller/ExternalAppsRestfulControllerTest.java b/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/controller/ExternalAppsRestfulControllerTest.java
index d8f98bb9..890319dc 100644
--- a/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/controller/ExternalAppsRestfulControllerTest.java
+++ b/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/controller/ExternalAppsRestfulControllerTest.java
@@ -66,6 +66,7 @@ import org.onap.portalapp.portal.core.MockEPUser;
 import org.onap.portalapp.portal.domain.EPApp;
 import org.onap.portalapp.portal.domain.EPRole;
 import org.onap.portalapp.portal.domain.EPUser;
+import org.onap.portalapp.portal.domain.EpAppType;
 import org.onap.portalapp.portal.framework.MockitoTestSuite;
 import org.onap.portalapp.portal.service.AdminRolesService;
 import org.onap.portalapp.portal.service.AdminRolesServiceImpl;
@@ -135,24 +136,24 @@ public class ExternalAppsRestfulControllerTest {
 		app.setName("Test");
 		app.setImageUrl("test");
 		app.setNameSpace("com.test.app");
-		app.setCentralAuth(true);
-		app.setDescription("test");
-		app.setNotes("test");
-		app.setUrl("test");
+		app.setRolesInAAF(true);
+		app.setAppDescription("test");
+		app.setAppNotes("test");
+		app.setLandingPage("test");
 		app.setId((long) 10);
 		app.setAppRestEndpoint("test");
-		app.setAlternateUrl("test");
+		app.setAlternateLandingPage("test");
 		app.setName("test");
 		app.setMlAppName("test");
 		app.setMlAppAdminId("test");
-		app.setUsername("test");
-		app.setAppPassword("test");
+		app.setAppBasicAuthUsername("test");
+		app.setAppBasicAuthPassword("test");
 		app.setOpen(false);
 		app.setEnabled(true);
 		app.setUebKey("test");
 		app.setUebSecret("test");
 		app.setUebTopicName("test");
-		app.setAppType(1);
+		app.setAppType(EpAppType.GUI);
 		return app;
 	}
 
@@ -296,6 +297,47 @@ public class ExternalAppsRestfulControllerTest {
         assertEquals(543L, createdNofification.getRoleIds().get(0).longValue());
     }
 
+	@Test
+	public void publishNotificationXSSTest() throws Exception {
+		// input
+		EpNotificationItem notificationItem = new EpNotificationItem();
+		List<Long> roleList = new ArrayList<Long>();
+		Long role1 = 1L;
+		roleList.add(role1);
+		notificationItem.setRoleIds(roleList);
+		notificationItem.setPriority(1L);
+		notificationItem.setMsgHeader("<script>alert(‘XSS’)</script>");
+		notificationItem.setMsgDescription("Test Description");
+		Date currentDate = new Date();
+		Calendar c = Calendar.getInstance();
+		c.setTime(currentDate);
+		c.add(Calendar.DATE, 1);
+		Date currentDatePlusOne = c.getTime();
+		notificationItem.setStartTime(currentDate);
+		notificationItem.setEndTime(currentDatePlusOne);
+
+		// mock calls
+		Mockito.when(mockedRequest.getHeader("uebkey")).thenReturn("RxH3983AHiyBOQmj");
+		Map<String, String> params = new HashMap<>();
+		params.put("appKey", "RxH3983AHiyBOQmj");
+		List<EPApp> apps = new ArrayList<>();
+		EPApp app = new EPApp();
+		app.setId(123L);
+		apps.add(app);
+		Mockito.when(DataAccessService.executeNamedQuery("getMyAppDetailsByUebKey", params, null)).thenReturn(apps);
+		EPRole role = new EPRole();
+		role.setId(543L);
+		Mockito.when(epRoleService.getRole(123L, 1L)).thenReturn(role);
+
+		// run
+		Mockito.when(userNotificationService.saveNotification(notificationItem)).thenReturn("Test");
+		PortalAPIResponse response = externalAppsRestfulController.publishNotification(mockedRequest, notificationItem);
+		// verify answer
+		assertNotNull(response);
+		assertEquals("error", response.getStatus());
+		assertEquals("failed", response.getMessage());
+	}
+
     @Test
     public void publishNotificationTest_EmptyAppHeader() throws Exception {
         // input