X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=ecomp-portal-BE-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Fportalapp%2Fportal%2Fservice%2FUserRolesCommonServiceImpl.java;h=7a7f9ee4c92513d5a6beb3f2e8011a4cb652b6c9;hb=fca38e174e85b66c67ab9e8b754a9b53d70fbfd9;hp=a97dc58b98cc7a36021e168695c4de74c7ec7903;hpb=885648993b3b2a9e7d36ebfeb96c196674c32e78;p=portal.git

diff --git a/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/service/UserRolesCommonServiceImpl.java b/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/service/UserRolesCommonServiceImpl.java
index a97dc58b..7a7f9ee4 100644
--- a/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/service/UserRolesCommonServiceImpl.java
+++ b/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/service/UserRolesCommonServiceImpl.java
@@ -1127,8 +1127,7 @@ public class UserRolesCommonServiceImpl  {
 							userRolesInLocalApp);
 					List<RoleInAppForUser> roleAppUserList = rolesInAppForUser.roles;
 					if (EcompPortalUtils.checkIfRemoteCentralAccessAllowed()) {
-
-					// Apply changes in external Access system
+						// Apply changes in external Access system
 						updateUserRolesInExternalSystem(app, rolesInAppForUser.orgUserId, roleAppUserList,
 								epRequestValue,false,rolesGotDeletedFromApprover,checkIfUserisOnlyRoleAdmin);
 					}
@@ -1147,7 +1146,7 @@ public class UserRolesCommonServiceImpl  {
 					if(!app.getRolesInAAF() && !app.getId().equals(PortalConstants.PORTAL_APP_ID)){
 						
 						remoteAppUser = checkIfRemoteUserExits(userId, app, applicationsRestClientService);
-		
+
 						if (remoteAppUser == null) {
 							remoteAppUser = addRemoteUser(roleInAppForUserList, userId, app, mapper, searchService, applicationsRestClientService);
 						}
@@ -1655,6 +1654,7 @@ public class UserRolesCommonServiceImpl  {
 						// If adding just account admin role dont make remote application user call or
 						// if request has only single non admin role then make remote call
 						if (!(app.getId().equals(PortalConstants.PORTAL_APP_ID) && reqType.equals("DELETE"))
+								&& (app.getAppAck() != null && app.getAppAck())
 								&& ((checkIfAdminRoleExists && roleInAppForUserList.size() > 1)
 										|| (!checkIfAdminRoleExists && roleInAppForUserList.size() >= 1))) {
 							// check if admin role exist then delete
@@ -1664,6 +1664,7 @@ public class UserRolesCommonServiceImpl  {
 								return (role.getRoleId().equals(PortalConstants.ACCOUNT_ADMIN_ROLE_ID));
 							});
 							String orgUserIdNewOrExist = (userInfo.size() != 0 || !userInfo.isEmpty()) ? user.getOrgUserId() : orgUserId;
+								
 							pushRemoteUser(remoteUserRoles, orgUserIdNewOrExist , app, mapper, searchService,
 									applicationsRestClientService,true);
 						}