X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=ecomp-portal-BE-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Fportalapp%2Fportal%2Flogging%2Faop%2FEPEELFLoggerAdvice.java;h=43ea4c3fd4cbe8743bc52220f69e2a8449e558e9;hb=7ee79c657d68a412e36363aa782881f0edb10115;hp=4c67429bfad9d7dff4b3e3de67ea9fff869cf257;hpb=54c5ed82662ef681375675e58abc8058e3203466;p=portal.git

diff --git a/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/logging/aop/EPEELFLoggerAdvice.java b/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/logging/aop/EPEELFLoggerAdvice.java
index 4c67429b..43ea4c3f 100644
--- a/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/logging/aop/EPEELFLoggerAdvice.java
+++ b/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/logging/aop/EPEELFLoggerAdvice.java
@@ -54,6 +54,7 @@ import org.onap.portalsdk.core.exception.SessionExpiredException;
 import org.onap.portalsdk.core.logging.format.AlarmSeverityEnum;
 import org.onap.portalsdk.core.logging.format.AuditLogFormatter;
 import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
+import org.onap.portalsdk.core.logging.logic.LoggerProperties;
 import org.onap.portalsdk.core.util.SystemProperties;
 import org.onap.portalsdk.core.util.SystemProperties.SecurityEventTypeEnum;
 import org.onap.portalsdk.core.web.support.UserUtils;
@@ -108,6 +109,7 @@ public class EPEELFLoggerAdvice {
 	 * @return Object array
 	 */
 	public Object[] before(SecurityEventTypeEnum securityEventType, Object[] args, Object[] passOnArgs) {
+		try {
 		String className = "";
 		if (passOnArgs.length > 0 && passOnArgs[0] != null)
 			className = passOnArgs[0].toString();
@@ -117,6 +119,7 @@ public class EPEELFLoggerAdvice {
 
 		// Initialize Request defaults only for controller methods.
 		MDC.put(className + methodName + EPCommonSystemProperties.METRICSLOG_BEGIN_TIMESTAMP, getCurrentDateTimeUTC());
+		MDC.put(EPCommonSystemProperties.METRICSLOG_BEGIN_TIMESTAMP, getCurrentDateTimeUTC());
 		MDC.put(EPCommonSystemProperties.TARGET_ENTITY, EPCommonSystemProperties.ECOMP_PORTAL_BE);
 		MDC.put(EPCommonSystemProperties.TARGET_SERVICE_NAME, methodName);
 		if (MDC.get(Configuration.MDC_KEY_REQUEST_ID) == null||MDC.get(Configuration.MDC_KEY_REQUEST_ID).isEmpty()){
@@ -124,37 +127,30 @@ public class EPEELFLoggerAdvice {
 			MDC.put(Configuration.MDC_KEY_REQUEST_ID, requestId);
 		}
 		MDC.put(EPCommonSystemProperties.PARTNER_NAME, "Unknown");
-		MDC.put(Configuration.MDC_SERVICE_NAME, EPCommonSystemProperties.ECOMP_PORTAL_BE);
 
+		EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(className);
+		MDC.put(EPCommonSystemProperties.STATUS_CODE, "INPROGRESS");
+
+		// Log security message, if necessary
 		if (securityEventType != null) {
 			MDC.put(className + methodName + EPCommonSystemProperties.AUDITLOG_BEGIN_TIMESTAMP,
 					getCurrentDateTimeUTC());
+			MDC.put(EPCommonSystemProperties.AUDITLOG_BEGIN_TIMESTAMP,getCurrentDateTimeUTC());
+			MDC.put(EPCommonSystemProperties.AUDITLOG_END_TIMESTAMP, getCurrentDateTimeUTC());
+			this.calculateDateTimeDifference(MDC.get(EPCommonSystemProperties.AUDITLOG_BEGIN_TIMESTAMP),MDC.get(EPCommonSystemProperties.AUDITLOG_END_TIMESTAMP));
 			HttpServletRequest req = null;
 			if (args.length > 0 && args[0] != null && args[0] instanceof HttpServletRequest) {
 				req = (HttpServletRequest) args[0];
 				this.setHttpRequestBasedDefaultsIntoGlobalLoggingContext(req, securityEventType, methodName);
 			}
-		}
-
-		EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(className);
-		logger.debug(EELFLoggerDelegate.debugLogger, "EPEELFLoggerAdvice#after: finished {}", methodName);
-		// add the metrics log
-		logger.info(EELFLoggerDelegate.metricsLogger,  methodName + " operation is completed.");
-
-		// Log security message, if necessary
-		if (securityEventType != null) {
-			MDC.put(EPCommonSystemProperties.AUDITLOG_BEGIN_TIMESTAMP,getCurrentDateTimeUTC());
-			MDC.put(EPCommonSystemProperties.AUDITLOG_END_TIMESTAMP, getCurrentDateTimeUTC());
-			this.calculateDateTimeDifference(MDC.get(EPCommonSystemProperties.AUDITLOG_BEGIN_TIMESTAMP),MDC.get(EPCommonSystemProperties.AUDITLOG_END_TIMESTAMP));
-			MDC.put(EPCommonSystemProperties.STATUS_CODE, "INPROGRESS");
-			MDC.put("CustomField1", "ENTRY");
-			MDC.put("CustomField2", "InvocationID="+MDC.get(Configuration.MDC_KEY_REQUEST_ID));
 			try {
 				MDC.put(Configuration.MDC_SERVER_FQDN, InetAddress.getLocalHost().getCanonicalHostName());
 			} catch (Exception e) {
 				adviceLogger.error(EELFLoggerDelegate.errorLogger,
 						" while setting the IP address ", e);
 			}
+			MDC.put(SystemProperties.CUSTOM_FIELD1, "ENTRY");
+			MDC.put(SystemProperties.CUSTOM_FIELD2, "InvocationID="+MDC.get(Configuration.MDC_KEY_REQUEST_ID));
 			this.logSecurityMessage(logger, securityEventType, methodName);
 
 			// Outgoing & LDAP messages are part of Incoming requests so,
@@ -173,10 +169,20 @@ public class EPEELFLoggerAdvice {
 				MDC.remove(EPCommonSystemProperties.PARTNER_NAME);
 				MDC.remove(Configuration.MDC_SERVICE_NAME);
 			}
+			logger.debug(EELFLoggerDelegate.debugLogger, "{} was invoked.", methodName);
 			
 			MDC.remove(Configuration.MDC_SERVER_FQDN);
+		} else {
+			MDC.put(SystemProperties.METRICSLOG_END_TIMESTAMP, getCurrentDateTimeUTC());
+			this.calculateDateTimeDifference(MDC.get(SystemProperties.METRICSLOG_BEGIN_TIMESTAMP),MDC.get(SystemProperties.METRICSLOG_END_TIMESTAMP));
+			MDC.put(SystemProperties.CUSTOM_FIELD1, "INVOKE");
+			MDC.put(SystemProperties.CUSTOM_FIELD2, " InvocationID="+MDC.get(Configuration.MDC_KEY_REQUEST_ID));
+			logger.info(EELFLoggerDelegate.metricsLogger, methodName + " operation is started.");		
 		}
 		logger.debug(EELFLoggerDelegate.debugLogger, "EPEELFLoggerAdvice#before: entering {}", methodName);
+		} catch (Exception e) {
+			adviceLogger.error(EELFLoggerDelegate.errorLogger, "before failed", e);
+		}
 		return new Object[] { "" };
 	}
 
@@ -191,6 +197,7 @@ public class EPEELFLoggerAdvice {
 	 */
 	public void after(SecurityEventTypeEnum securityEventType, String statusCode, String responseCode, Object[] args,
 			Object[] returnArgs, Object[] passOnArgs) {
+		try {
 		String className = "";
 		if (passOnArgs.length > 0 && passOnArgs[0] != null)
 			className = passOnArgs[0].toString();
@@ -216,8 +223,6 @@ public class EPEELFLoggerAdvice {
 			MDC.put(EPCommonSystemProperties.PARTNER_NAME, "Unknown");
 		}
 		
-		MDC.put(Configuration.MDC_SERVICE_NAME, EPCommonSystemProperties.ECOMP_PORTAL_BE);
-
 
 		MDC.put(EPCommonSystemProperties.METRICSLOG_BEGIN_TIMESTAMP,
 				MDC.get(className + methodName + EPCommonSystemProperties.METRICSLOG_BEGIN_TIMESTAMP));
@@ -246,12 +251,9 @@ public class EPEELFLoggerAdvice {
 			MDC.put(EPCommonSystemProperties.RESPONSE_CODE, externalAPIResponseCode);
 			MDC.put(EPCommonSystemProperties.STATUS_CODE, "ERROR");
 		}
-
+		MDC.put(EPCommonSystemProperties.STATUS_CODE, "COMPLETE");
 		EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(className);
-		logger.debug(EELFLoggerDelegate.debugLogger, "EPEELFLoggerAdvice#after: finished {}", methodName);
-		// add the metrics log
-		logger.info(EELFLoggerDelegate.metricsLogger,  methodName + " operation is completed.");
-
+		
 		// Log security message, if necessary
 		if (securityEventType != null) {
 			MDC.put(EPCommonSystemProperties.AUDITLOG_BEGIN_TIMESTAMP,
@@ -259,8 +261,8 @@ public class EPEELFLoggerAdvice {
 			MDC.put(EPCommonSystemProperties.AUDITLOG_END_TIMESTAMP, getCurrentDateTimeUTC());
 			this.calculateDateTimeDifference(MDC.get(EPCommonSystemProperties.AUDITLOG_BEGIN_TIMESTAMP),
 					MDC.get(EPCommonSystemProperties.AUDITLOG_END_TIMESTAMP));
-			MDC.put("CustomField1", "EXIT");
-			MDC.put("CustomField2", "InvocationID="+MDC.get(Configuration.MDC_KEY_REQUEST_ID));
+			MDC.put(SystemProperties.CUSTOM_FIELD1, "EXIT");
+			MDC.put(SystemProperties.CUSTOM_FIELD2, "InvocationID="+MDC.get(Configuration.MDC_KEY_REQUEST_ID));
 			try {
 				MDC.put(Configuration.MDC_SERVER_FQDN, InetAddress.getLocalHost().getCanonicalHostName());
 			} catch (Exception e) {
@@ -296,15 +298,24 @@ public class EPEELFLoggerAdvice {
 			MDC.remove(EPCommonSystemProperties.AUDITLOG_END_TIMESTAMP);
 			MDC.remove(EPCommonSystemProperties.RESPONSE_CODE);
 			
+		} else {
+			MDC.put(SystemProperties.CUSTOM_FIELD1, "INVOKE-RETURN");
+			MDC.put(SystemProperties.CUSTOM_FIELD2, " InvocationID="+MDC.get(Configuration.MDC_KEY_REQUEST_ID));
+			// add the metrics log
+			logger.info(EELFLoggerDelegate.metricsLogger,  methodName + " operation is completed.");
 		}
-		MDC.remove("CustomField1");
-		MDC.remove("CustomField2");
+		logger.debug(EELFLoggerDelegate.debugLogger, "EPEELFLoggerAdvice#after: finished {}", methodName);
+		MDC.remove(SystemProperties.CUSTOM_FIELD1);
+		MDC.remove(SystemProperties.CUSTOM_FIELD2);
 		MDC.remove(className + methodName + EPCommonSystemProperties.METRICSLOG_BEGIN_TIMESTAMP);
 		MDC.remove(EPCommonSystemProperties.METRICSLOG_BEGIN_TIMESTAMP);
 		MDC.remove(EPCommonSystemProperties.METRICSLOG_END_TIMESTAMP);
 		MDC.remove(EPCommonSystemProperties.MDC_TIMER);
 		MDC.remove(EPCommonSystemProperties.TARGET_ENTITY);
 		MDC.remove(EPCommonSystemProperties.TARGET_SERVICE_NAME);
+		} catch (Exception e) {
+			adviceLogger.error(EELFLoggerDelegate.errorLogger, "after failed", e);
+		}
 	
 	}