X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=datarouter-prov%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Fdmaap%2Fdatarouter%2Fprovisioning%2Fbeans%2FGroup.java;h=91d6c1b4ff2940645fd7a2f20fef1eabb5f97083;hb=refs%2Fchanges%2F39%2F66539%2F1;hp=a460d647e76285ddc6eff5433d2234f3aee01e0c;hpb=d6c28ce28b8c66fe9784af894cf9385f6d2c8e76;p=dmaap%2Fdatarouter.git

diff --git a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/Group.java b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/Group.java
index a460d647..91d6c1b4 100644
--- a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/Group.java
+++ b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/Group.java
@@ -133,14 +133,15 @@ public class Group extends Syncable {
     }
 
     public static Collection<String> getGroupsByClassfication(String classfication) {
-        List<String> list = new ArrayList<String>();
-        String sql = "select * from GROUPS where classification = '" + classfication + "'";
+        List<String> list = new ArrayList<>();
+        String sql = "select * from GROUPS where classification = ?";
         try {
             DB db = new DB();
             @SuppressWarnings("resource")
             Connection conn = db.getConnection();
-            try(Statement stmt = conn.createStatement()) {
-                try(ResultSet rs = stmt.executeQuery(sql)) {
+            try(PreparedStatement stmt = conn.prepareStatement(sql)) {
+                stmt.setString(1, classfication);
+                try(ResultSet rs = stmt.executeQuery()) {
                     while (rs.next()) {
                         int groupid = rs.getInt("groupid");