X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=cps-rest%2Fsrc%2Ftest%2Fgroovy%2Forg%2Fonap%2Fcps%2Frest%2Fexceptions%2FCpsRestExceptionHandlerSpec.groovy;h=05bd41d30512b2de755ba1f0ef04e23a398688cf;hb=0d6bbae9baa4531f5b5c3009fa72e691cf30fe41;hp=89b6b893645f54ace52b256555e91b4041b9c6e0;hpb=99f0f0be7cc540dd32aacc770468d73444bcfb18;p=cps.git

diff --git a/cps-rest/src/test/groovy/org/onap/cps/rest/exceptions/CpsRestExceptionHandlerSpec.groovy b/cps-rest/src/test/groovy/org/onap/cps/rest/exceptions/CpsRestExceptionHandlerSpec.groovy
index 89b6b8936..05bd41d30 100644
--- a/cps-rest/src/test/groovy/org/onap/cps/rest/exceptions/CpsRestExceptionHandlerSpec.groovy
+++ b/cps-rest/src/test/groovy/org/onap/cps/rest/exceptions/CpsRestExceptionHandlerSpec.groovy
@@ -21,13 +21,18 @@
 
 package org.onap.cps.rest.exceptions
 
+import static org.springframework.http.HttpStatus.BAD_REQUEST
+import static org.springframework.http.HttpStatus.CONFLICT
+import static org.springframework.http.HttpStatus.INTERNAL_SERVER_ERROR
+import static org.springframework.http.HttpStatus.NOT_FOUND
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get
+
 import groovy.json.JsonSlurper
 import org.modelmapper.ModelMapper
 import org.onap.cps.api.CpsAdminService
 import org.onap.cps.api.CpsDataService
 import org.onap.cps.api.CpsModuleService
 import org.onap.cps.api.CpsQueryService
-import org.onap.cps.rest.controller.RestControllerSpecification
 import org.onap.cps.spi.exceptions.AnchorAlreadyDefinedException
 import org.onap.cps.spi.exceptions.CpsException
 import org.onap.cps.spi.exceptions.CpsPathException
@@ -43,17 +48,11 @@ import org.springframework.beans.factory.annotation.Value
 import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest
 import org.springframework.test.web.servlet.MockMvc
 import spock.lang.Shared
+import spock.lang.Specification
 import spock.lang.Unroll
 
-import static org.springframework.http.HttpStatus.BAD_REQUEST
-import static org.springframework.http.HttpStatus.CONFLICT
-import static org.springframework.http.HttpStatus.INTERNAL_SERVER_ERROR
-import static org.springframework.http.HttpStatus.NOT_FOUND
-import static org.springframework.http.HttpStatus.UNAUTHORIZED
-import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get
-
 @WebMvcTest
-class CpsRestExceptionHandlerSpec extends RestControllerSpecification {
+class CpsRestExceptionHandlerSpec extends Specification {
 
     @SpringBean
     CpsAdminService mockCpsAdminService = Mock()
@@ -150,7 +149,7 @@ class CpsRestExceptionHandlerSpec extends RestControllerSpecification {
         where: 'the following exceptions are thrown'
             exceptionThrown << [new ModelValidationException(errorMessage, errorDetails, null),
                                 new DataValidationException(errorMessage, errorDetails, null),
-                                new CpsPathException(errorMessage,errorDetails)]
+                                new CpsPathException(errorMessage, errorDetails)]
     }
 
     @Unroll
@@ -168,38 +167,18 @@ class CpsRestExceptionHandlerSpec extends RestControllerSpecification {
                                 new SchemaSetInUseException(dataspaceName, existingObjectName)]
     }
 
-    def 'Get request without authentication is not authorized'() {
-        when: 'request is sent without authentication'
-            def response =
-                    mvc.perform(get("$basePath/v1/dataspaces/dataspace-name/anchors")).andReturn().response
-        then: 'HTTP Unauthorized status code is returned'
-            assert UNAUTHORIZED.value() == response.status
-    }
-
-    def 'Get request with invalid authentication is not authorized'() {
-        when: 'request is sent with invalid authentication'
-            def response =
-                    mvc.perform(
-                            get("$basePath/v1/dataspaces/dataspace-name/anchors")
-                                    .header("Authorization", 'Basic invalid auth'))
-                            .andReturn().response
-        then: 'HTTP Unauthorized status code is returned'
-            assert UNAUTHORIZED.value() == response.status
-    }
-
     /*
      * NB. The test uses 'get JSON by id' endpoint and associated service method invocation
      * to test the exception handling. The endpoint chosen is not a subject of test.
      */
 
     def setupTestException(exception) {
-        mockCpsAdminService.getAnchors(_) >> { throw exception}
+        mockCpsAdminService.getAnchors(_) >> { throw exception }
     }
 
     def performTestRequest() {
         return mvc.perform(
-                get("$basePath/v1/dataspaces/dataspace-name/anchors")
-                        .header("Authorization", getAuthorizationHeader()))
+                get("$basePath/v1/dataspaces/dataspace-name/anchors"))
                 .andReturn().response
     }