X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=auth%2Fauth-locate%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Faaf%2Fauth%2Flocate%2Fservice%2FLocateServiceImpl.java;h=e080e7ee9cfa7f2997443e833632697eceb9f7df;hb=3d1706fcbe7f95830ff6fd23cf679ee55c6d0595;hp=b2cdfab616559fbad57dba7372f875ac19040eed;hpb=047edb5a4312cc7dfb3172b7e11ab1a9e2315ba2;p=aaf%2Fauthz.git

diff --git a/auth/auth-locate/src/main/java/org/onap/aaf/auth/locate/service/LocateServiceImpl.java b/auth/auth-locate/src/main/java/org/onap/aaf/auth/locate/service/LocateServiceImpl.java
index b2cdfab6..e080e7ee 100644
--- a/auth/auth-locate/src/main/java/org/onap/aaf/auth/locate/service/LocateServiceImpl.java
+++ b/auth/auth-locate/src/main/java/org/onap/aaf/auth/locate/service/LocateServiceImpl.java
@@ -22,7 +22,6 @@
 package org.onap.aaf.auth.locate.service;
 
 import java.util.List;
-import java.util.UUID;
 
 import org.onap.aaf.auth.dao.cass.ConfigDAO;
 import org.onap.aaf.auth.dao.cass.ConfigDAO.Data;
@@ -42,111 +41,125 @@ import locate.v1_1.Configuration;
 import locate.v1_1.Configuration.Props;
 
 public class LocateServiceImpl<IN,OUT,ERROR> 
-	  implements LocateService<IN,OUT,Endpoints,MgmtEndpoints,Configuration,ERROR> {
-		private Mapper<IN,OUT,Endpoints,MgmtEndpoints,Configuration,ERROR> mapper;
-		protected LocateDAO locateDAO;
-		private ConfigDAO configDAO;
-		private boolean permToRegister;
-	
-		public LocateServiceImpl(AuthzTrans trans, AAF_Locate locate, Mapper<IN,OUT,Endpoints,MgmtEndpoints,Configuration,ERROR> mapper) throws APIException {
-			this.mapper = mapper;
-			this.locateDAO = locate.locateDAO;
-			this.configDAO = locate.configDAO;
-			permToRegister = false; //TODO Setup a Configuration for this
-		}
-		
-		public Mapper<IN,OUT,Endpoints,MgmtEndpoints,Configuration,ERROR> mapper() {return mapper;}
+      implements LocateService<IN,OUT,Endpoints,MgmtEndpoints,Configuration,ERROR> {
+        private Mapper<IN,OUT,Endpoints,MgmtEndpoints,Configuration,ERROR> mapper;
+        protected LocateDAO locateDAO;
+        private ConfigDAO configDAO;
+        private boolean permToRegister;
+    
+        public LocateServiceImpl(AuthzTrans trans, AAF_Locate locate, Mapper<IN,OUT,Endpoints,MgmtEndpoints,Configuration,ERROR> mapper) throws APIException {
+            this.mapper = mapper;
+            this.locateDAO = locate.locateDAO;
+            this.configDAO = locate.configDAO;
+            permToRegister = false; //TODO Setup a Configuration for this
+        }
+        
+        public Mapper<IN,OUT,Endpoints,MgmtEndpoints,Configuration,ERROR> mapper() {return mapper;}
 
-		@Override
-		public Result<Endpoints> getEndPoints(AuthzTrans trans, String service, String version, String other) {
-			return mapper.endpoints(locateDAO.readByName(trans, service), version, other);
-		}
+        @Override
+        public Result<Endpoints> getEndPoints(AuthzTrans trans, String service, String version, String other) {
+            return mapper.endpoints(locateDAO.readByName(trans, service), version, other);
+        }
 
-		/* (non-Javadoc)
-		 * @see org.onap.aaf.auth.locate.service.GwService#putMgmtEndPoints(org.onap.aaf.auth.env.test.AuthzTrans, java.lang.Object)
-		 */
-		@Override
-		public Result<Void> putMgmtEndPoints(AuthzTrans trans, MgmtEndpoints meps) {
-			LocateValidator v = new LocateValidator().mgmt_endpoints(meps, false);
-			if(v.err()) {
-				return Result.err(Result.ERR_BadData,v.errs());
-			}
-			int count = 0;
-			for(MgmtEndpoint me : meps.getMgmtEndpoint()) {
-				if(permToRegister) { 
-					int dot = me.getName().lastIndexOf('.'); // Note: Validator checks for NS for getName()
-					AAFPermission p = new AAFPermission(me.getName().substring(0,dot),"locator",me.getName(),"write"); 
-					if(trans.fish(p)) {
-						LocateDAO.Data data = mapper.locateData(me);
-						locateDAO.update(trans, data, true);
-						++count;
-					} else {
-						return Result.err(Result.ERR_Denied,"May not register service (needs " + p.getKey() + ')');
-					}
-				} else { //TODO if(MechID is part of Namespace) { 
-					LocateDAO.Data data = mapper.locateData(me);
-					locateDAO.update(trans, data, true);
-					++count;
-				}
-			}
-			if(count>0) {
-				return Result.ok();
-			} else {
-				return Result.err(Result.ERR_NotFound, "No endpoints found");
-			}
-		}
+        /* (non-Javadoc)
+         * @see org.onap.aaf.auth.locate.service.GwService#putMgmtEndPoints(org.onap.aaf.auth.env.test.AuthzTrans, java.lang.Object)
+         */
+        @Override
+        public Result<Void> putMgmtEndPoints(AuthzTrans trans, MgmtEndpoints meps) {
+            LocateValidator v = new LocateValidator().mgmt_endpoints(meps, false);
+            if (v.err()) {
+                return Result.err(Result.ERR_BadData,v.errs());
+            }
+            int count = 0;
+            StringBuilder denied = null;
+            for (MgmtEndpoint me : meps.getMgmtEndpoint()) {
+                if (permToRegister) { 
+                    int dot = me.getName().lastIndexOf('.'); // Note: Validator checks for NS for getName()
+                    AAFPermission p = new AAFPermission(me.getName().substring(0,dot),"locator",me.getHostname(),"write"); 
+                    if (!trans.fish(p)) {
+                        if(denied==null) {
+                            denied = new StringBuilder("May not register service(s):");
+                        }
+                        
+                        denied.append("\n\t");
+                        denied.append(p.getKey());
+                        denied.append(')');
+                        continue;
+                    }
+                }
+                LocateDAO.Data data = mapper.locateData(me);
+                locateDAO.update(trans, data, true);
+                ++count;
+            }
+            if (count>0) {
+                return Result.ok();
+            } else {
+                return denied==null?Result.err(Result.ERR_NotFound, "No endpoints found")
+                        :Result.err(Result.ERR_Security,denied.toString());
+            }
+        }
 
-		/* (non-Javadoc)
-		 * @see org.onap.aaf.auth.locate.service.GwService#removeMgmtEndPoints(org.onap.aaf.auth.env.test.AuthzTrans, java.lang.Object)
-		 */
-		@Override
-		public Result<Void> removeMgmtEndPoints(AuthzTrans trans, MgmtEndpoints meps) {
-			LocateValidator v = new LocateValidator().mgmt_endpoint_key(meps);
-			if(v.err()) {
-				return Result.err(Result.ERR_BadData,v.errs());
-			}
-			int count = 0;
-			for(MgmtEndpoint me : meps.getMgmtEndpoint()) {
-				int dot = me.getName().lastIndexOf('.'); // Note: Validator checks for NS for getName()
-				AAFPermission p = new AAFPermission(me.getName().substring(0,dot),"locator",me.getHostname(),"write"); 
-				if(trans.fish(p)) {
-					LocateDAO.Data data = mapper.locateData(me);
-					data.port_key = UUID.randomUUID();
-					locateDAO.delete(trans, data, false);
-					++count;
-				} else {
-					return Result.err(Result.ERR_Denied,"May not register service (needs " + p.getKey() + ')');
-				}
-			}
-			if(count>0) {
-				return Result.ok();
-			} else {
-				return Result.err(Result.ERR_NotFound, "No endpoints found");
-			}
-		}
+        /* (non-Javadoc)
+         * @see org.onap.aaf.auth.locate.service.GwService#removeMgmtEndPoints(org.onap.aaf.auth.env.test.AuthzTrans, java.lang.Object)
+         */
+        @Override
+        public Result<Void> removeMgmtEndPoints(AuthzTrans trans, MgmtEndpoints meps) {
+            LocateValidator v = new LocateValidator().mgmt_endpoint_key(meps);
+            if (v.err()) {
+                return Result.err(Result.ERR_BadData,v.errs());
+            }
+            int count = 0;
+            StringBuilder denied = null;
+            for (MgmtEndpoint me : meps.getMgmtEndpoint()) {
+                 if (permToRegister) { 
+                     int dot = me.getName().lastIndexOf('.'); // Note: Validator checks for NS for getName()
+                     AAFPermission p = new AAFPermission(me.getName().substring(0,dot),"locator",me.getHostname(),"write"); 
+                     if (!trans.fish(p)) {
+                         if(denied==null) {
+                             denied = new StringBuilder("May not deregister service(s):");
+                         }
+                         
+                         denied.append("\n\t");
+                         denied.append(p.getKey());
+                         denied.append(')');
+                         continue;
+                     }
+                 }
+                 LocateDAO.Data data = mapper.locateData(me);
+                 locateDAO.delete(trans, data, true);
+                 ++count;
+            }
+            if (count>0) {
+                return Result.ok();
+            } else {
+                return denied==null?Result.err(Result.ERR_NotFound, "No endpoints found")
+                        :Result.err(Result.ERR_Security,denied.toString());
+            }
+        }
 
-		/////   ADDED v1_1
-		/* (non-Javadoc)
-		 * @see org.onap.aaf.auth.locate.service.LocateService#getConfig(org.onap.aaf.auth.env.AuthzTrans, java.lang.String, java.lang.String)
-		 */
-		@Override
-		public Result<Configuration> getConfig(AuthzTrans trans, String id, String type) {
-			Result<List<Data>> dr = configDAO.readName(trans, type);
-			Configuration c = new Configuration();
-			c.setName(type);
-			Props p;
-			
-			if(dr.isOKhasData()) {
-				for(ConfigDAO.Data data : dr.value) {
-					p = new Props();
-					p.setTag(data.tag);
-					p.setValue(data.value);
-					c.getProps().add(p);
-				}
-			}
-			return Result.ok(c);
-			//return Result.err(Result.ERR_NotImplemented,"not done yet");
-		}
+        /////   ADDED v1_1
+        /* (non-Javadoc)
+         * @see org.onap.aaf.auth.locate.service.LocateService#getConfig(org.onap.aaf.auth.env.AuthzTrans, java.lang.String, java.lang.String)
+         * 
+         * Note: "id" is put in, in case we need to filter, or direct data change in the future by Permission
+         */
+        @Override
+        public Result<Configuration> getConfig(AuthzTrans trans, String id, String type) {
+            Result<List<Data>> dr = configDAO.readName(trans, type);
+            Configuration c = new Configuration();
+            c.setName(type);
+            Props p;
+            
+            if (dr.isOKhasData()) {
+                for (ConfigDAO.Data data : dr.value) {
+                    p = new Props();
+                    p.setTag(data.tag);
+                    p.setValue(data.value);
+                    c.getProps().add(p);
+                }
+            }
+            return Result.ok(c);
+        }
 
 
 //////////////// APIs ///////////////////