X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=auth%2Fauth-batch%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Faaf%2Fauth%2Fbatch%2Fhelpers%2FMiscID.java;h=4d46c20bef7381c2b13d4fad747bb6bd0af3f2e5;hb=4b6435c97dc1e05ee6a1e06190e3c431f9d1a8fe;hp=e30336fb96113071537123610adcce72fc033d1a;hpb=9a83564f360cd25eea0b7016356fc41145f5d559;p=aaf%2Fauthz.git

diff --git a/auth/auth-batch/src/main/java/org/onap/aaf/auth/batch/helpers/MiscID.java b/auth/auth-batch/src/main/java/org/onap/aaf/auth/batch/helpers/MiscID.java
index e30336fb..4d46c20b 100644
--- a/auth/auth-batch/src/main/java/org/onap/aaf/auth/batch/helpers/MiscID.java
+++ b/auth/auth-batch/src/main/java/org/onap/aaf/auth/batch/helpers/MiscID.java
@@ -4,7 +4,7 @@
  * ===========================================================================
  * Copyright (c) 2018 AT&T Intellectual Property. All rights reserved.
  * ===========================================================================
- * Modifications Copyright (C) 2018 IBM.
+ * Modifications Copyright (C) 2019 IBM.
  * ===========================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -53,6 +53,7 @@ public class MiscID  {
     public String sponsor;
     public String created;
     public String renewal;
+    public static String SELECT_QUERY = "SELECT ";
 
     private static final String FIELD_STRING = "id,created,sponsor,renewal";
     
@@ -64,9 +65,7 @@ public class MiscID  {
      * 2) DB "suits.cql"
      * 3) Alter existing Tables
      * @param row
-     * @throws BatchException 
-     * @throws IllegalAccessException 
-     * @throws IllegalArgumentException 
+     * @throws BatchException
      */
     public void set(String[] row ) throws BatchException {
         if (row.length<4) {
@@ -87,15 +86,15 @@ public class MiscID  {
     
 
     public static void load(Trans trans, Session session ) {
-        load(trans, session,"SELECT " + FIELD_STRING + " FROM authz.miscid;",data);
+        load(trans, session,SELECT_QUERY + FIELD_STRING + " FROM authz.miscid;",data);
     }
 
     public static void load(Trans trans, Session session, Map<String,MiscID> map ) {
-        load(trans, session,"SELECT " + FIELD_STRING + " FROM authz.miscid;",map);
+        load(trans, session,SELECT_QUERY + FIELD_STRING + " FROM authz.miscid;",map);
     }
 
     public static void loadOne(Trans trans, Session session, String id ) {
-        load(trans, session,"SELECT " + FIELD_STRING + " FROM authz.miscid WHERE id ='" + id + "';", data);
+        load(trans, session,SELECT_QUERY + FIELD_STRING + " FROM authz.miscid WHERE id ='" + id + "';", data);
     }
 
     public static void load(Trans trans, Session session, String query, Map<String,MiscID> map) {
@@ -140,13 +139,13 @@ public class MiscID  {
      */
     @Override
     public boolean equals(Object obj) {
-        if (obj!=null && obj instanceof MiscID) {
+        if (null!=obj && obj instanceof MiscID) {
             return id.equals(((MiscID)obj).id);
         }
         return false;
     }
 
-    public StringBuilder insertStmt() throws IllegalArgumentException, IllegalAccessException {
+    public StringBuilder insertStmt() {
         StringBuilder sb = new StringBuilder("INSERT INTO authz.miscid (");
         sb.append(FIELD_STRING);
         sb.append(") VALUES ('");