X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=asdc-controller%2Fsrc%2Ftest%2Fjava%2Forg%2Fonap%2Fso%2Fasdc%2Fclient%2Ftests%2FASDCConfigurationTest.java;h=5b8637d1edc3dd2bec257b225d6c8b5822925a39;hb=825e00a29f1ebd4f28cdd4f4fd1ace0a47e2292c;hp=992d495369325d80463dca1c53b64df97891a33f;hpb=aa3a520e7b85bbebf8b1f603bd1979154204f718;p=so.git

diff --git a/asdc-controller/src/test/java/org/onap/so/asdc/client/tests/ASDCConfigurationTest.java b/asdc-controller/src/test/java/org/onap/so/asdc/client/tests/ASDCConfigurationTest.java
index 992d495369..5b8637d1ed 100644
--- a/asdc-controller/src/test/java/org/onap/so/asdc/client/tests/ASDCConfigurationTest.java
+++ b/asdc-controller/src/test/java/org/onap/so/asdc/client/tests/ASDCConfigurationTest.java
@@ -43,18 +43,13 @@ public class ASDCConfigurationTest extends BaseTest {
     @Autowired
     private ASDCConfiguration config;
 
-    private List<String> msgBusAddressList = new ArrayList<String>();
+    private final List<String> msgBusAddressList = new ArrayList<>();
 
     private static final String MSO_PRE_IST = "msopreist";
     private static final String MSO_ASDC_ID_LOCAL = "msoasdc-id-local";
     private static final String PRE_IST = "Pre-IST";
     private static final String ASDC_ADDRESS = "localhost:8443";
 
-    @Test
-    public void isUseHttpsWithDmaapTest() {
-        assertTrue(config.isUseHttpsWithDmaap());
-    }
-
     @Test
     public void isConsumeProduceStatusTopicTest() {
         assertTrue(config.isConsumeProduceStatusTopic());
@@ -62,52 +57,52 @@ public class ASDCConfigurationTest extends BaseTest {
 
     @Test
     public void getUserTest() {
-        assertTrue(MSO_PRE_IST.equals(config.getUser()));
+        assertEquals(MSO_PRE_IST, config.getUser());
     }
 
     @Test
     public void getConsumerGroupTest() {
-        assertTrue(MSO_ASDC_ID_LOCAL.equals(config.getConsumerGroup()));
+        assertEquals(MSO_ASDC_ID_LOCAL, config.getConsumerGroup());
     }
 
     @Test
     public void getConsumerIDTest() {
-        assertTrue(MSO_ASDC_ID_LOCAL.equals(config.getConsumerID()));
+        assertEquals(MSO_ASDC_ID_LOCAL, config.getConsumerID());
     }
 
     @Test
     public void getEnvironmentNameTest() {
-        assertTrue(PRE_IST.equals(config.getEnvironmentName()));
+        assertEquals(PRE_IST, config.getEnvironmentName());
     }
 
     @Test
     public void getAsdcAddress() {
-        assertTrue(ASDC_ADDRESS.equals(config.getAsdcAddress()));
+        assertEquals(ASDC_ADDRESS, config.getSdcAddress());
     }
 
     @Test
     public void getPasswordTest() {
-        assertTrue(MSO_PRE_IST.equals(config.getPassword()));
+        assertEquals(MSO_PRE_IST, config.getPassword());
     }
 
     @Test
     public void getPollingIntervalTest() {
-        assertTrue(config.getPollingInterval() == 30);
+        assertEquals(30, config.getPollingInterval());
     }
 
     @Test
     public void getPollingTimeoutTest() {
-        assertTrue(config.getPollingTimeout() == 30);
+        assertEquals(30, config.getPollingTimeout());
     }
 
     @Test
     public void getRelevantArtifactTypesTest() {
-        assertTrue(config.getRelevantArtifactTypes().size() == ASDCConfiguration.SUPPORTED_ARTIFACT_TYPES_LIST.size());
+        assertEquals(config.getRelevantArtifactTypes().size(), ASDCConfiguration.SUPPORTED_ARTIFACT_TYPES_LIST.size());
     }
 
     @Test
     public void getWatchDogTimeoutTest() {
-        assertTrue(config.getWatchDogTimeout() == 1);
+        assertEquals(1, config.getWatchDogTimeout());
     }
 
     @Test
@@ -137,13 +132,4 @@ public class ASDCConfigurationTest extends BaseTest {
         String actualAsdcControllerName = config.getAsdcControllerName();
         assertEquals(asdcControllerName, actualAsdcControllerName);
     }
-
-    @Test
-    public void getMsgBusAddressTest() {
-        msgBusAddressList.add("localhost");
-        msgBusAddressList.add("localhost");
-
-        List<String> actualMsgBusAddress = config.getMsgBusAddress();
-        assertEquals(msgBusAddressList, actualMsgBusAddress);
-    }
 }