X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=PolicyEngineAPI%2Fsrc%2Ftest%2Fjava%2Forg%2Fonap%2Fpolicy%2Fstd%2Ftest%2FManualClientEndTest.java;h=42df545d2e40175bc859c97d48b05fa0fabdfd0b;hb=28238bc0c12a10239564cd1d58fd07345fe1cde4;hp=7d31c24b5682ba38ab8717b52886b67602cd8a9f;hpb=681b47487c22be6dda452501ead10b4c7d7e9c56;p=policy%2Fengine.git

diff --git a/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/ManualClientEndTest.java b/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/ManualClientEndTest.java
index 7d31c24b5..42df545d2 100644
--- a/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/ManualClientEndTest.java
+++ b/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/ManualClientEndTest.java
@@ -1,8 +1,8 @@
-/*-
+/*
  * ============LICENSE_START=======================================================
  * PolicyEngineAPI
  * ================================================================================
- * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,8 +21,9 @@
 package org.onap.policy.std.test;
 
 import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
+
 import java.io.IOException;
 import java.net.InetSocketAddress;
 import java.util.concurrent.CountDownLatch;
@@ -35,18 +36,18 @@ import org.junit.BeforeClass;
 import org.junit.Test;
 import org.onap.policy.api.NotificationScheme;
 import org.onap.policy.std.ManualClientEnd;
-import org.springframework.util.SocketUtils;
 
 /**
- * The class <code>ManualClientEndTest</code> contains tests for the class <code>{@link ManualClientEnd}</code>.
+ * The class <code>ManualClientEndTest</code> contains tests for the class
+ * <code>{@link ManualClientEnd}</code>.
  *
  */
 public class ManualClientEndTest {
     private static WebSocketServer ws;
 
-    private static int port = SocketUtils.findAvailableTcpPort();
-    private static CountDownLatch countServerDownLatch = null;
-    private static String recvMsg = null;
+    private static int port;
+    private static volatile String recvMsg = null;
+    private static volatile Exception webEx = null;
 
     /**
      * Start server.
@@ -55,50 +56,59 @@ public class ManualClientEndTest {
      */
     @BeforeClass
     public static void startServer() throws Exception {
-        ws = new WebSocketServer(new InetSocketAddress(port), 1) {
-            @Override
-            public void onOpen(WebSocket conn, ClientHandshake handshake) {
 
-            }
+        CountDownLatch latch = new CountDownLatch(1);
 
+        ws = new WebSocketServer(new InetSocketAddress(0), 1) {
             @Override
-            public void onClose(WebSocket conn, int code, String reason, boolean remote) {
-                countServerDownLatch.countDown();
-            }
+            public void onOpen(WebSocket conn, ClientHandshake handshake) {}
+
+            @Override
+            public void onClose(WebSocket conn, int code, String reason, boolean remote) {}
 
             @Override
             public void onMessage(WebSocket conn, String message) {
+
+                // NOTE: must copy to recvMsg BEFORE invoking conn.send()
                 recvMsg = message;
+
                 conn.send("{\"removedPolicies\": [],\"loadedPolicies\":"
-                        + "[{\"policyName\": \"Test.Config_BRMS_Param_BrmsParamTestPa.1.xml\","
-                        + "\"versionNo\": \"1\",\"matches\": {\"ECOMPName\": \"DROOLS\","
-                        + "\"ONAPName\": \"DROOLS\",\"ConfigName\": \"BRMS_PARAM_RULE\","
-                        + "\"guard\": \"false\",\"TTLDate\": \"NA\",\"RiskLevel\": \"5\","
-                        + "\"RiskType\": \"default\"},\"updateType\": \"NEW\"}],\"notificationType\": \"UPDATE\"}");
+                                + "[{\"policyName\": \"Test.Config_BRMS_Param_BrmsParamTestPa.1.xml\","
+                                + "\"versionNo\": \"1\",\"matches\": {\"ECOMPName\": \"DROOLS\","
+                                + "\"ONAPName\": \"DROOLS\",\"ConfigName\": \"BRMS_PARAM_RULE\","
+                                + "\"guard\": \"false\",\"TTLDate\": \"NA\",\"RiskLevel\": \"5\","
+                                + "\"RiskType\": \"default\"},\"updateType\": \"NEW\"}],\"notificationType\": \"UPDATE\"}");
             }
 
             @Override
             public void onError(WebSocket conn, Exception ex) {
-
+                webEx = ex;
                 ex.printStackTrace();
-                fail("There should be no exception!");
+                latch.countDown();
             }
 
             @Override
-            public void onStart() {}
+            public void onStart() {
+                latch.countDown();
+            }
         };
 
         ws.setConnectionLostTimeout(0);
         ws.setReuseAddr(true);
         ws.start();
+
+        // ensure port connected (or error) before running the actual test
+        latch.await(20, TimeUnit.SECONDS);
+
+        // ensure no error during start-up
+        assertNull(webEx);
+
+        port = ws.getPort();
     }
 
     @Test
     public void testManualClient() throws Exception {
-        countServerDownLatch = new CountDownLatch(1);
-
         ManualClientEnd.start("http://localhost:" + port + "/");
-        countServerDownLatch.await(45, TimeUnit.SECONDS);
 
         assertNotNull(ManualClientEnd.result(NotificationScheme.MANUAL_ALL_NOTIFICATIONS));
         assertTrue("Manual".equalsIgnoreCase(recvMsg));
@@ -106,6 +116,6 @@ public class ManualClientEndTest {
 
     @AfterClass
     public static void successTests() throws InterruptedException, IOException {
-        ws.stop(30000);
+        ws.stop(5000);
     }
 }