X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=POLICY-SDK-APP%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Fpolicy%2Fcontroller%2FDashboardController.java;h=adb91ec2729f58637e14bfcb23a7565e55bcf13d;hb=b65e96826d7339ce29ddb73e3ed6775bd4f54753;hp=901b5929f3bcf47092ef10ecb04b97ec723c1118;hpb=a6b8bc8875402ab721a8529926d01b2565d0f595;p=policy%2Fengine.git

diff --git a/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DashboardController.java b/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DashboardController.java
index 901b5929f..adb91ec27 100644
--- a/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DashboardController.java
+++ b/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DashboardController.java
@@ -194,7 +194,6 @@ public class DashboardController  extends RestrictedBaseController{
 			PolicyController controller = getPolicyControllerInstance();
 			Set<OnapPDPGroup> groups = controller.getPapEngine().getOnapPDPGroups();
 			if (groups == null) {
-				papStatus = "UNKNOWN";
 				throw new PAPException("PAP not running");
 			}else {
 				papStatus = "IS_OK";
@@ -281,14 +280,10 @@ public class DashboardController  extends RestrictedBaseController{
 	private long getRequestCounts(String host, int port, String jmxAttribute) {
 
 		policyLogger.debug("Create an RMI connector client and connect it to the JMX connector server");
-		HashMap map = new HashMap();
-		map = null;
-		JMXConnector jmxConnection;
-		try {
-			jmxConnection = JMXConnectorFactory.newJMXConnector(createConnectionURL(host, port), map);
+		HashMap map = null;
+		try (JMXConnector jmxConnection = JMXConnectorFactory.newJMXConnector(createConnectionURL(host, port), map)){
 			jmxConnection.connect();
 			Object o = jmxConnection.getMBeanServerConnection().getAttribute(new ObjectName("PdpRest:type=PdpRestMonitor"), jmxAttribute);
-			jmxConnection.close();
 			policyLogger.debug("pdpEvaluationNA value retreived: " + o);
 			return (long) o;
 		} catch (MalformedURLException e) {
@@ -321,10 +316,10 @@ public class DashboardController  extends RestrictedBaseController{
 	 */
 	private void addPolicyToTable() {
 		policyActivityData = new ArrayList<>();
-		String policyID = null;
-		int policyFireCount = 0;
+		String policyID;
+		int policyFireCount;
 		Map<String, String> policyMap = new HashMap<>();
-		Object policyList = null;
+		Object policyList;
 		//get list of policy
 
 		for (PDPGroup group : this.pdpConatiner.getGroups()){
@@ -348,14 +343,12 @@ public class DashboardController  extends RestrictedBaseController{
 					for (String policyKeyValue : splitPolicy){
 						policyID = urnPolicyID(policyKeyValue);
 						policyFireCount = countPolicyID(policyKeyValue);
-						if (policyID != null ){
-							if (policyMap.containsKey(policyID)){
-								JSONObject object = new JSONObject();
-								object.put("policyId", policyMap.get(policyID));
-								object.put("fireCount", policyFireCount);
-								object.put("system", pdp.getId());
-								policyActivityData.add(object);
-							}
+						if (policyID != null && policyMap.containsKey(policyID)){
+							JSONObject object = new JSONObject();
+							object.put("policyId", policyMap.get(policyID));
+							object.put("fireCount", policyFireCount);
+							object.put("system", pdp.getId());
+							policyActivityData.add(object);
 						}
 					}
 				}else {
@@ -383,14 +376,10 @@ public class DashboardController  extends RestrictedBaseController{
 	@SuppressWarnings({ "rawtypes", "unchecked" })
 	private Object getPolicy(String host, int port, String jmxAttribute){
 		policyLogger.debug("Create an RMI connector client and connect it to the JMX connector server for Policy: " + host);
-		HashMap map = new HashMap();
-		map = null;
-		JMXConnector jmxConnection;
-		try {
-			jmxConnection = JMXConnectorFactory.newJMXConnector(createConnectionURL(host, port), map);
+		HashMap map = null;
+		try (JMXConnector jmxConnection = JMXConnectorFactory.newJMXConnector(createConnectionURL(host, port), map)) {
 			jmxConnection.connect();
 			Object o = jmxConnection.getMBeanServerConnection().getAttribute(new ObjectName("PdpRest:type=PdpRestMonitor"), "policyMap");
-			jmxConnection.close();
 			policyLogger.debug("policyMap value retreived: " + o);
 			return  o;
 		} catch (MalformedURLException e) {