X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=POLICY-SDK-APP%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Fpolicy%2Fcontroller%2FCreateBRMSParamController.java;h=df1ca6a9ff23209755adac7b91062b1e77349c45;hb=881074dbf97b3a2d52d28fdd404e083b8e974d0d;hp=4dc45425ac71ade8bc87275e93d5713be6693f70;hpb=6200a3b57dcce7890df56c80ec388608c8ea391d;p=policy%2Fengine.git

diff --git a/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateBRMSParamController.java b/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateBRMSParamController.java
index 4dc45425a..df1ca6a9f 100644
--- a/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateBRMSParamController.java
+++ b/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateBRMSParamController.java
@@ -44,7 +44,7 @@ import org.onap.policy.rest.dao.CommonClassDao;
 import org.onap.policy.rest.jpa.BRMSParamTemplate;
 import org.onap.policy.rest.jpa.PolicyEntity;
 import org.onap.policy.xacml.api.XACMLErrorConstants;
-import org.openecomp.portalsdk.core.controller.RestrictedBaseController;
+import org.onap.portalsdk.core.controller.RestrictedBaseController;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Controller;
 import org.springframework.web.bind.annotation.RequestMapping;
@@ -85,7 +85,9 @@ public class CreateBRMSParamController extends RestrictedBaseController {
 		CreateBRMSParamController.commonClassDao = commonClassDao;
 	}
 
-	public CreateBRMSParamController(){}
+	public CreateBRMSParamController(){
+		// Empty constructor
+	}
 	protected PolicyRestAdapter policyAdapter = null; 
 
 	private HashMap<String, String> dynamicLayoutMap;
@@ -131,7 +133,7 @@ public class CreateBRMSParamController extends RestrictedBaseController {
 				StringBuilder params = new StringBuilder("");
 				Boolean flag = false;
 				Boolean comment = false;
-				String lines[] = rule.split("\n");
+				String[] lines = rule.split("\n");
 				for(String line : lines){
 					if (line.isEmpty() || line.startsWith("//")) {
 						continue;
@@ -185,7 +187,7 @@ public class CreateBRMSParamController extends RestrictedBaseController {
 				String[] components = params.toString().split(":");
 				String caption = "";
 				for (int i = 0; i < components.length; i++) {
-					String type = "";
+					String type;
 					if (i == 0) {
 						caption = components[i];
 					}
@@ -415,7 +417,7 @@ public class CreateBRMSParamController extends RestrictedBaseController {
 				String[] components = params.toString().split("\\);");
 				if(components!= null && components.length > 0){
 					for (int i = 0; i < components.length; i++) {
-						String value = null;
+						String value;
 						components[i] = components[i]+")";
 						String caption = components[i].substring(0,
 								components[i].indexOf('('));
@@ -456,7 +458,7 @@ public class CreateBRMSParamController extends RestrictedBaseController {
 				policyData.setEditPolicy(true);
 			}
 
-			String body = "";
+			String body;
 
 			body = "/* Autogenerated Code Please Don't change/remove this comment section. This is for the UI purpose. \n\t " +
 					brmsTemplateVlaue + policyData.getRuleName() + "%$> \n */ \n";