X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=POLICY-SDK-APP%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Fpolicy%2Fadmin%2FPolicyManagerServlet.java;h=30414221d94f8bfcb07fd3ee263fd5f44396fa5f;hb=7414584e40572c7854db959052c56f3cc8849488;hp=2492ab0242ece99ebf0e00d43a95afaefb361d10;hpb=64d3d5f9d4fb225fde55598e5b7462978642c417;p=policy%2Fengine.git diff --git a/POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyManagerServlet.java b/POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyManagerServlet.java index 2492ab024..30414221d 100644 --- a/POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyManagerServlet.java +++ b/POLICY-SDK-APP/src/main/java/org/onap/policy/admin/PolicyManagerServlet.java @@ -36,13 +36,7 @@ import java.nio.charset.StandardCharsets; import java.nio.file.Files; import java.nio.file.Path; import java.nio.file.Paths; -import java.util.ArrayList; -import java.util.Date; -import java.util.HashMap; -import java.util.HashSet; -import java.util.List; -import java.util.Map; -import java.util.Set; +import java.util.*; import javax.json.Json; import javax.json.JsonArray; @@ -93,20 +87,52 @@ import com.fasterxml.jackson.databind.ObjectMapper; public class PolicyManagerServlet extends HttpServlet { private static final Logger LOGGER = FlexLogger.getLogger(PolicyManagerServlet.class); private static final long serialVersionUID = -8453502699403909016L; - private static final String VERSION = "version";; + private static final String VERSION = "version"; private static final String NAME = "name"; private static final String DATE = "date"; private static final String SIZE = "size"; private static final String TYPE = "type"; private static final String CREATED_BY = "createdBy"; private static final String MODIFIED_BY = "modifiedBy"; + private static final String CONTENTTYPE = "application/json"; + private static final String SUPERADMIN = "super-admin"; + private static final String SUPEREDITOR = "super-editor"; + private static final String SUPERGUEST = "super-guest"; + private static final String ADMIN = "admin"; + private static final String EDITOR = "editor"; + private static final String GUEST = "guest"; + private static final String RESULT = "result"; + private static final String EXCEPTION_OCCURED = "Exception Occured"; + private static final String CONFIG = ".Config_"; + private static final String CONFIG1 = ":Config_"; + private static final String ACTION = ".Action_"; + private static final String ACTION1 = ":Action_"; + private static final String DECISION = ".Decision_"; + private static final String DECISION1 = ":Decision_"; + private static final String CONFIG2 = "Config_"; + private static final String ACTION2 = "Action_"; + private static final String DECISION2 = "Decision_"; + private static final String FORWARD_SLASH = "/"; + private static final String BACKSLASH = "\\"; + private static final String ESCAPE_BACKSLASH = "\\\\"; + private static final String BACKSLASH_8TIMES = "\\\\\\\\"; + private static final String UPDATE_POLICY_VERSION_SET_ACTIVE_VERSION = "update PolicyVersion set active_version='"; + private static final String SPLIT_1 = "split_1"; + private static final String SPLIT_0 = "split_0"; + private static final String FROM_POLICY_EDITOR_SCOPES_WHERE_SCOPENAME_LIKE_SCOPE_NAME = "from PolicyEditorScopes where SCOPENAME like :scopeName"; + private static final String SCOPE_NAME = "scopeName"; + private static final String SUCCESS = "success"; + private static final String SUB_SCOPENAME = "subScopename"; + private static List serviceTypeNamesList = new ArrayList<>(); + private static JsonArray policyNames; + private static String testUserId = null; private enum Mode { LIST, RENAME, COPY, DELETE, EDITFILE, ADDFOLDER, DESCRIBEPOLICYFILE, VIEWPOLICY, ADDSUBSCOPE, SWITCHVERSION, EXPORT, SEARCHLIST } private static PolicyController policyController; - public synchronized PolicyController getPolicyController() { + private synchronized PolicyController getPolicyController() { return policyController; } @@ -114,19 +140,6 @@ public class PolicyManagerServlet extends HttpServlet { PolicyManagerServlet.policyController = policyController; } - private static String CONTENTTYPE = "application/json"; - private static String SUPERADMIN = "super-admin"; - private static String SUPEREDITOR = "super-editor"; - private static String SUPERGUEST = "super-guest"; - private static String ADMIN = "admin"; - private static String EDITOR = "editor"; - private static String GUEST = "guest"; - private static String RESULT = "result"; - - private static Path closedLoopJsonLocation; - private static JsonArray policyNames; - private static String testUserId = null; - public static JsonArray getPolicyNames() { return policyNames; } @@ -135,8 +148,6 @@ public class PolicyManagerServlet extends HttpServlet { PolicyManagerServlet.policyNames = policyNames; } - private static List serviceTypeNamesList = new ArrayList<>(); - public static List getServiceTypeNamesList() { return serviceTypeNamesList; } @@ -154,8 +165,8 @@ public class PolicyManagerServlet extends HttpServlet { PolicyManagerServlet.initializeJSONLoad(); } - protected static void initializeJSONLoad() { - closedLoopJsonLocation = Paths.get(XACMLProperties + private static void initializeJSONLoad() { + Path closedLoopJsonLocation = Paths.get(XACMLProperties .getProperty(XACMLRestProperties.PROP_ADMIN_CLOSEDLOOP)); String location = closedLoopJsonLocation.toString(); if (! location.endsWith("json")) { @@ -177,7 +188,7 @@ public class PolicyManagerServlet extends HttpServlet { } @Override - protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { + protected void doPost(HttpServletRequest request, HttpServletResponse response) { LOGGER.debug("doPost"); try { // if request contains multipart-form-data @@ -192,7 +203,7 @@ public class PolicyManagerServlet extends HttpServlet { try { setError(e, response); }catch(Exception e1){ - LOGGER.error("Exception Occured"+e1); + LOGGER.error(EXCEPTION_OCCURED +e1); } } } @@ -206,7 +217,7 @@ public class PolicyManagerServlet extends HttpServlet { out.print(responseJsonObject); out.flush(); } catch (Exception x) { - LOGGER.error("Exception Occured"+x); + LOGGER.error(EXCEPTION_OCCURED +x); response.sendError(HttpStatus.SC_INTERNAL_SERVER_ERROR, x.getMessage()); } } @@ -241,7 +252,7 @@ public class PolicyManagerServlet extends HttpServlet { String newFile; if(item.getName().endsWith(".xls") && item.getSize() <= PolicyController.getFileSizeLimit()){ File file = new File(item.getName()); - try (OutputStream outputStream = new FileOutputStream(file);) + try (OutputStream outputStream = new FileOutputStream(file)) { IOUtils.copy(item.getInputStream(), outputStream); newFile = file.toString(); @@ -260,16 +271,21 @@ public class PolicyManagerServlet extends HttpServlet { } //File Operation Functionality - private void fileOperation(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { - JSONObject responseJsonObject = null; - try { - StringBuilder sb = new StringBuilder(); - BufferedReader br = request.getReader(); + private void fileOperation(HttpServletRequest request, HttpServletResponse response) throws ServletException { + JSONObject responseJsonObject; + StringBuilder sb = new StringBuilder(); + try (BufferedReader br = request.getReader()) { String str; while ((str = br.readLine()) != null) { sb.append(str); } - br.close(); + } catch (Exception e) { + LOGGER.error(XACMLErrorConstants.ERROR_DATA_ISSUE + "Exception Occured While doing File Operation" + e); + responseJsonObject = error(e.getMessage()); + setResponse(response, responseJsonObject); + return; + } + try { JSONObject jObj = new JSONObject(sb.toString()); JSONObject params = jObj.getJSONObject("params"); Mode mode = Mode.valueOf(params.getString("mode")); @@ -278,53 +294,67 @@ public class PolicyManagerServlet extends HttpServlet { LOGGER.info("****************************************Logging UserID while doing actions on Editor tab*******************************************"); LOGGER.info("UserId: " + userId + "Action Mode: "+ mode.toString() + "Action Params: "+params.toString()); LOGGER.info("***********************************************************************************************************************************"); - - switch (mode) { - case ADDFOLDER: - case ADDSUBSCOPE: - responseJsonObject = addFolder(params, request); - break; - case COPY: - responseJsonObject = copy(params, request); - break; - case DELETE: - responseJsonObject = delete(params, request); - break; - case EDITFILE: - case VIEWPOLICY: - responseJsonObject = editFile(params); - break; - case LIST: - responseJsonObject = list(params, request); - break; - case RENAME: - responseJsonObject = rename(params, request); - break; - case DESCRIBEPOLICYFILE: - responseJsonObject = describePolicy(params); - break; - case SWITCHVERSION: - responseJsonObject = switchVersion(params, request); - break; - case SEARCHLIST: - responseJsonObject = searchPolicyList(params, request); - break; - default: - throw new ServletException("not implemented"); - } - if (responseJsonObject == null) { - responseJsonObject = error("generic error : responseJsonObject is null"); - } + responseJsonObject = operateBasedOnMode(mode, params, request); } catch (Exception e) { - LOGGER.error(XACMLErrorConstants.ERROR_DATA_ISSUE + "Exception Occured While doing File Operation" + e); + LOGGER.error(XACMLErrorConstants.ERROR_DATA_ISSUE + "Exception Occured While Processing Json" + e); responseJsonObject = error(e.getMessage()); } + setResponse(response, responseJsonObject); + } + + private void setResponse(HttpServletResponse response, JSONObject responseJsonObject) { response.setContentType(CONTENTTYPE); - PrintWriter out = response.getWriter(); - out.print(responseJsonObject); - out.flush(); + try (PrintWriter out = response.getWriter()) { + out.print(responseJsonObject); + out.flush(); + } catch (IOException e) { + LOGGER.error(XACMLErrorConstants.ERROR_DATA_ISSUE + "Exception occured while writing response" + e); + } + } + + + private JSONObject operateBasedOnMode(Mode mode, JSONObject params, HttpServletRequest request) throws ServletException{ + JSONObject responseJsonObject; + switch (mode) { + case ADDFOLDER: + case ADDSUBSCOPE: + responseJsonObject = addFolder(params, request); + break; + case COPY: + responseJsonObject = copy(params, request); + break; + case DELETE: + responseJsonObject = delete(params, request); + break; + case EDITFILE: + case VIEWPOLICY: + responseJsonObject = editFile(params); + break; + case LIST: + responseJsonObject = list(params, request); + break; + case RENAME: + responseJsonObject = rename(params, request); + break; + case DESCRIBEPOLICYFILE: + responseJsonObject = describePolicy(params); + break; + case SWITCHVERSION: + responseJsonObject = switchVersion(params, request); + break; + case SEARCHLIST: + responseJsonObject = searchPolicyList(params, request); + break; + default: + throw new ServletException("not implemented"); + } + if (responseJsonObject == null) { + responseJsonObject = error("generic error : responseJsonObject is null"); + } + return responseJsonObject; } + private JSONObject searchPolicyList(JSONObject params, HttpServletRequest request) { List policyData = new ArrayList<>(); JSONArray policyList = null; @@ -344,7 +374,7 @@ public class PolicyManagerServlet extends HttpServlet { return new JSONObject().put(RESULT, resultList); } - private boolean lookupPolicyData(HttpServletRequest request, List policyData, JSONArray policyList, PolicyController controller, List resultList) throws ServletException { + private boolean lookupPolicyData(HttpServletRequest request, List policyData, JSONArray policyList, PolicyController controller, List resultList){ List roles; Set scopes;//Get the Login Id of the User from Request String userId = UserUtils.getUserSession(request).getOrgUserId(); @@ -368,21 +398,25 @@ public class PolicyManagerServlet extends HttpServlet { policyName = policyName.substring(0, policyName.lastIndexOf('.')).replace(".", File.separator); parsePolicyList(resultList, controller, policyName, version); } + }else { + getPolicyDataForSUPERRoles(policyData, controller, resultList, roles, scopes); + } + return true; + } + + private void getPolicyDataForSUPERRoles(List policyData, PolicyController controller, List resultList, List roles, Set scopes) { + if (roles.contains(SUPERADMIN) || roles.contains(SUPEREDITOR) || roles.contains(SUPERGUEST) ){ + policyData = controller.getData(PolicyVersion.class); }else{ - if (roles.contains(SUPERADMIN) || roles.contains(SUPEREDITOR) || roles.contains(SUPERGUEST) ){ - policyData = controller.getData(PolicyVersion.class); - }else{ - List filterdatas = controller.getData(PolicyVersion.class); - for(Object filter : filterdatas) { - addFilterData(policyData, scopes, (PolicyVersion) filter); - } + List filterdatas = controller.getData(PolicyVersion.class); + for(Object filter : filterdatas) { + addFilterData(policyData, scopes, (PolicyVersion) filter); } + } - if(!policyData.isEmpty()){ - updateResultList(policyData, resultList); - } + if(!policyData.isEmpty()){ + updateResultList(policyData, resultList); } - return true; } private void addFilterData(List policyData, Set scopes, PolicyVersion filter) { @@ -397,10 +431,10 @@ public class PolicyManagerServlet extends HttpServlet { } private void updateResultList(List policyData, List resultList) { - for(int i =0; i < policyData.size(); i++){ - PolicyVersion policy = (PolicyVersion) policyData.get(i); + for (Object aPolicyData : policyData) { + PolicyVersion policy = (PolicyVersion) aPolicyData; JSONObject el = new JSONObject(); - el.put(NAME, policy.getPolicyName().replace(File.separator, "/")); + el.put(NAME, policy.getPolicyName().replace(File.separator, FORWARD_SLASH)); el.put(DATE, policy.getModifiedDate()); el.put(VERSION, policy.getActiveVersion()); el.put(SIZE, ""); @@ -412,8 +446,8 @@ public class PolicyManagerServlet extends HttpServlet { } private void parsePolicyList(List resultList, PolicyController controller, String policyName, String version) { - if(policyName.contains("\\")){ - policyName = policyName.replace("\\", "\\\\"); + if(policyName.contains(BACKSLASH)){ + policyName = policyName.replace(BACKSLASH, ESCAPE_BACKSLASH); } String policyVersionQuery = "From PolicyVersion where policy_name = :policyName and active_version = :version and id >0"; SimpleBindings pvParams = new SimpleBindings(); @@ -423,7 +457,7 @@ public class PolicyManagerServlet extends HttpServlet { if(!activeData.isEmpty()){ PolicyVersion policy = (PolicyVersion) activeData.get(0); JSONObject el = new JSONObject(); - el.put(NAME, policy.getPolicyName().replace(File.separator, "/")); + el.put(NAME, policy.getPolicyName().replace(File.separator, FORWARD_SLASH)); el.put(DATE, policy.getModifiedDate()); el.put(VERSION, policy.getActiveVersion()); el.put(SIZE, ""); @@ -437,8 +471,8 @@ public class PolicyManagerServlet extends HttpServlet { private void addScope(Set scopes, String scope) { List scopesList = queryPolicyEditorScopes(scope); if(!scopesList.isEmpty()){ - for(int i = 0; i < scopesList.size(); i++){ - PolicyEditorScopes tempScope = (PolicyEditorScopes) scopesList.get(i); + for (Object aScopesList : scopesList) { + PolicyEditorScopes tempScope = (PolicyEditorScopes) aScopesList; scopes.add(tempScope.getScopeName()); } } @@ -455,7 +489,7 @@ public class PolicyManagerServlet extends HttpServlet { } String policyName; String removeExtension = path.replace(".xml", ""); - if(path.startsWith("/")){ + if(path.startsWith(FORWARD_SLASH)){ policyName = removeExtension.substring(1, removeExtension.lastIndexOf('.')); }else{ policyName = removeExtension.substring(0, removeExtension.lastIndexOf('.')); @@ -472,15 +506,7 @@ public class PolicyManagerServlet extends HttpServlet { return error("The Version shouldn't be greater than Highest Value"); } activePolicy = policyName + "." + activeVersion + ".xml"; - String dbCheckName = activePolicy.replace("/", "."); - if(dbCheckName.contains("Config_")){ - dbCheckName = dbCheckName.replace(".Config_", ":Config_"); - }else if(dbCheckName.contains("Action_")){ - dbCheckName = dbCheckName.replace(".Action_", ":Action_"); - }else if(dbCheckName.contains("Decision_")){ - dbCheckName = dbCheckName.replace(".Decision_", ":Decision_"); - } - String[] splitDBCheckName = dbCheckName.split(":"); + String[] splitDBCheckName = modifyPolicyName(activePolicy); String peQuery = "FROM PolicyEntity where policyName = :splitDBCheckName_1 and scope = :splitDBCheckName_0"; SimpleBindings policyParams = new SimpleBindings(); policyParams.put("splitDBCheckName_1", splitDBCheckName[1]); @@ -490,22 +516,22 @@ public class PolicyManagerServlet extends HttpServlet { if(pentity.isDeleted()){ return error("The Policy is Not Existing in Workspace"); } - if(policyName.contains("/")){ - policyName = policyName.replace("/", File.separator); + if(policyName.contains(FORWARD_SLASH)){ + policyName = policyName.replace(FORWARD_SLASH, File.separator); } policyName = policyName.substring(policyName.indexOf(File.separator)+1); - if(policyName.contains("\\")){ - policyName = policyName.replace(File.separator, "\\"); + if(policyName.contains(BACKSLASH)){ + policyName = policyName.replace(File.separator, BACKSLASH); } policyName = splitDBCheckName[0].replace(".", File.separator)+File.separator+policyName; String watchPolicyName = policyName; - if(policyName.contains("/")){ - policyName = policyName.replace("/", File.separator); + if(policyName.contains(FORWARD_SLASH)){ + policyName = policyName.replace(FORWARD_SLASH, File.separator); } - if(policyName.contains("\\")){ - policyName = policyName.replace("\\", "\\\\"); + if(policyName.contains(BACKSLASH)){ + policyName = policyName.replace(BACKSLASH, ESCAPE_BACKSLASH); } - String query = "update PolicyVersion set active_version='"+activeVersion+"' where policy_name ='"+policyName+"' and id >0"; + String query = UPDATE_POLICY_VERSION_SET_ACTIVE_VERSION +activeVersion+"' where policy_name ='"+policyName+"' and id >0"; //query the database controller.executeQuery(query); //Policy Notification @@ -519,31 +545,31 @@ public class PolicyManagerServlet extends HttpServlet { //Describe Policy private JSONObject describePolicy(JSONObject params) throws ServletException{ - JSONObject object = null; + JSONObject object; String path = params.getString("path"); - String policyName = null; - if(path.startsWith("/")){ + String policyName; + if(path.startsWith(FORWARD_SLASH)){ path = path.substring(1); policyName = path.substring(path.lastIndexOf('/') +1); - path = path.replace("/", "."); + path = path.replace(FORWARD_SLASH, "."); }else{ - path = path.replace("/", "."); + path = path.replace(FORWARD_SLASH, "."); policyName = path; } - if(path.contains("Config_")){ - path = path.replace(".Config_", ":Config_"); - }else if(path.contains("Action_")){ - path = path.replace(".Action_", ":Action_"); - }else if(path.contains("Decision_")){ - path = path.replace(".Decision_", ":Decision_"); + if(path.contains(CONFIG2)){ + path = path.replace(CONFIG, CONFIG1); + }else if(path.contains(ACTION2)){ + path = path.replace(ACTION, ACTION1); + }else if(path.contains(DECISION2)){ + path = path.replace(DECISION, DECISION1); } PolicyController controller = getPolicyControllerInstance(); String[] split = path.split(":"); String query = "FROM PolicyEntity where policyName = :split_1 and scope = :split_0"; SimpleBindings peParams = new SimpleBindings(); - peParams.put("split_1", split[1]); - peParams.put("split_0", split[0]); - List queryData = null; + peParams.put(SPLIT_1, split[1]); + peParams.put(SPLIT_0, split[0]); + List queryData; if(PolicyController.isjUnit()){ queryData = controller.getDataByQuery(query, null); }else{ @@ -553,7 +579,7 @@ public class PolicyManagerServlet extends HttpServlet { return error("Error Occured while Describing the Policy - query is empty"); } PolicyEntity entity = (PolicyEntity) queryData.get(0); - File temp = null; + File temp; try { temp = File.createTempFile(policyName, ".tmp"); } catch (IOException e) { @@ -567,12 +593,10 @@ public class PolicyManagerServlet extends HttpServlet { LOGGER.error("Exception Occured while Describing the Policy"+e); } object = HumanPolicyComponent.DescribePolicy(temp); - if(temp != null){ - try { - Files.delete(temp.toPath()); - } catch (IOException e) { - LOGGER.warn("Failed to delete " + temp.getName() + e); - } + try { + Files.delete(temp.toPath()); + } catch (IOException e) { + LOGGER.warn("Failed to delete " + temp.getName() + e); } return object; } @@ -588,15 +612,14 @@ public class PolicyManagerServlet extends HttpServlet { } private JSONObject processPolicyList(JSONObject params, HttpServletRequest request) throws ServletException { - List roles; - Set scopes;PolicyController controller = getPolicyControllerInstance(); + PolicyController controller = getPolicyControllerInstance(); //Get the Login Id of the User from Request String testUserID = getTestUserId(); String userId = testUserID != null ? testUserID : UserUtils.getUserSession(request).getOrgUserId(); List userRoles = controller.getRoles(userId); Pair, List> pair = org.onap.policy.utils.UserUtils.checkRoleAndScope(userRoles); - roles = pair.u; - scopes = pair.t; + List roles = pair.u; + Set scopes = pair.t; List resultList = new ArrayList<>(); boolean onlyFolders = params.getBoolean("onlyFolders"); @@ -609,15 +632,15 @@ public class PolicyManagerServlet extends HttpServlet { if(scopes.isEmpty()){ return error("No Scopes has been Assigned to the User. Please, Contact Super-Admin"); }else{ - if(!"/".equals(path)){ + if(!FORWARD_SLASH.equals(path)){ String tempScope = path.substring(1, path.length()); - tempScope = tempScope.replace("/", File.separator); + tempScope = tempScope.replace(FORWARD_SLASH, File.separator); scopes.add(tempScope); } } } - if (!"/".equals(path)) { + if (!FORWARD_SLASH.equals(path)) { try{ String scopeName = path.substring(path.indexOf('/') +1); activePolicyList(scopeName, resultList, roles, scopes, onlyFolders); @@ -672,8 +695,8 @@ public class PolicyManagerServlet extends HttpServlet { if(scopeName == null){ scopeNamequery = "from PolicyEditorScopes"; }else{ - scopeNamequery = "from PolicyEditorScopes where SCOPENAME like :scopeName"; - params.put("scopeName", scopeName + "%"); + scopeNamequery = FROM_POLICY_EDITOR_SCOPES_WHERE_SCOPENAME_LIKE_SCOPE_NAME; + params.put(SCOPE_NAME, scopeName + "%"); } PolicyController controller = getPolicyControllerInstance(); List scopesList; @@ -689,17 +712,17 @@ public class PolicyManagerServlet extends HttpServlet { private void activePolicyList(String inScopeName, List resultList, List roles, Set scopes, boolean onlyFolders){ PolicyController controller = getPolicyControllerInstance(); String scopeName = inScopeName; - if(scopeName.contains("/")){ - scopeName = scopeName.replace("/", File.separator); + if(scopeName.contains(FORWARD_SLASH)){ + scopeName = scopeName.replace(FORWARD_SLASH, File.separator); } - if(scopeName.contains("\\")){ - scopeName = scopeName.replace("\\", "\\\\"); + if(scopeName.contains(BACKSLASH)){ + scopeName = scopeName.replace(BACKSLASH, ESCAPE_BACKSLASH); } String query = "from PolicyVersion where POLICY_NAME like :scopeName"; - String scopeNamequery = "from PolicyEditorScopes where SCOPENAME like :scopeName"; + String scopeNamequery = FROM_POLICY_EDITOR_SCOPES_WHERE_SCOPENAME_LIKE_SCOPE_NAME; SimpleBindings params = new SimpleBindings(); - params.put("scopeName", scopeName + "%"); + params.put(SCOPE_NAME, scopeName + "%"); List activePolicies; List scopesList; @@ -718,8 +741,8 @@ public class PolicyManagerServlet extends HttpServlet { PolicyVersion policy = (PolicyVersion) list; String scopeNameValue = policy.getPolicyName().substring(0, policy.getPolicyName().lastIndexOf(File.separator)); if(roles.contains(SUPERADMIN) || roles.contains(SUPEREDITOR) || roles.contains(SUPERGUEST)){ - if(scopeName.contains("\\\\")){ - scopeNameCheck = scopeName.replace("\\\\", File.separator); + if(scopeName.contains(ESCAPE_BACKSLASH)){ + scopeNameCheck = scopeName.replace(ESCAPE_BACKSLASH, File.separator); }else{ scopeNameCheck = scopeName; } @@ -752,8 +775,8 @@ public class PolicyManagerServlet extends HttpServlet { String scope = scopeById.getScopeName(); if(scope.contains(File.separator)){ String targetScope = scope.substring(0, scope.lastIndexOf(File.separator)); - if(scopeName.contains("\\\\")){ - scopeName = scopeName.replace("\\\\", File.separator); + if(scopeName.contains(ESCAPE_BACKSLASH)){ + scopeName = scopeName.replace(ESCAPE_BACKSLASH, File.separator); } if(scope.contains(File.separator)){ scope = scope.substring(targetScope.length()+1); @@ -803,50 +826,50 @@ public class PolicyManagerServlet extends HttpServlet { String newPath = params.getString("newPath"); oldPath = oldPath.substring(oldPath.indexOf('/')+1); newPath = newPath.substring(newPath.indexOf('/')+1); - String checkValidation = null; + String checkValidation; if(oldPath.endsWith(".xml")){ checkValidation = newPath.replace(".xml", ""); checkValidation = checkValidation.substring(checkValidation.indexOf('_') + 1, checkValidation.lastIndexOf(".")); - checkValidation = checkValidation.substring(checkValidation.lastIndexOf("/")+1); - if(!PolicyUtils.policySpecialCharValidator(checkValidation).contains("success")){ + checkValidation = checkValidation.substring(checkValidation.lastIndexOf(FORWARD_SLASH)+1); + if(!PolicyUtils.policySpecialCharValidator(checkValidation).contains(SUCCESS)){ return error("Policy Rename Failed. The Name contains special characters."); } JSONObject result = policyRename(oldPath, newPath, userId); - if(!(Boolean)(result.getJSONObject("result").get("success"))){ + if(!(Boolean)(result.getJSONObject("result").get(SUCCESS))){ return result; } }else{ String scopeName = oldPath; String newScopeName = newPath; - if(scopeName.contains("/")){ - scopeName = scopeName.replace("/", File.separator); - newScopeName = newScopeName.replace("/", File.separator); + if(scopeName.contains(FORWARD_SLASH)){ + scopeName = scopeName.replace(FORWARD_SLASH, File.separator); + newScopeName = newScopeName.replace(FORWARD_SLASH, File.separator); } checkValidation = newScopeName.substring(newScopeName.lastIndexOf(File.separator)+1); - if(scopeName.contains("\\")){ - scopeName = scopeName.replace("\\", "\\\\\\\\"); - newScopeName = newScopeName.replace("\\", "\\\\\\\\"); + if(scopeName.contains(BACKSLASH)){ + scopeName = scopeName.replace(BACKSLASH, BACKSLASH_8TIMES); + newScopeName = newScopeName.replace(BACKSLASH, BACKSLASH_8TIMES); } - if(!PolicyUtils.policySpecialCharValidator(checkValidation).contains("success")){ + if(!PolicyUtils.policySpecialCharValidator(checkValidation).contains(SUCCESS)){ return error("Scope Rename Failed. The Name contains special characters."); } PolicyController controller = getPolicyControllerInstance(); String query = "from PolicyVersion where POLICY_NAME like :scopeName"; - String scopeNamequery = "from PolicyEditorScopes where SCOPENAME like :scopeName"; + String scopeNamequery = FROM_POLICY_EDITOR_SCOPES_WHERE_SCOPENAME_LIKE_SCOPE_NAME; SimpleBindings pvParams = new SimpleBindings(); - pvParams.put("scopeName", scopeName + "%"); + pvParams.put(SCOPE_NAME, scopeName + "%"); List activePolicies = controller.getDataByQuery(query, pvParams); List scopesList = controller.getDataByQuery(scopeNamequery, pvParams); for(Object object : activePolicies){ PolicyVersion activeVersion = (PolicyVersion) object; - String policyOldPath = activeVersion.getPolicyName().replace(File.separator, "/") + "." + activeVersion.getActiveVersion() + ".xml"; + String policyOldPath = activeVersion.getPolicyName().replace(File.separator, FORWARD_SLASH) + "." + activeVersion.getActiveVersion() + ".xml"; String policyNewPath = policyOldPath.replace(oldPath, newPath); JSONObject result = policyRename(policyOldPath, policyNewPath, userId); - if(!(Boolean)(result.getJSONObject("result").get("success"))){ + if(!(Boolean)(result.getJSONObject("result").get(SUCCESS))){ isActive = true; policyActiveInPDP.add(policyOldPath); String scope = policyOldPath.substring(0, policyOldPath.lastIndexOf('/')); - scopeOfPolicyActiveInPDP.add(scope.replace("/", File.separator)); + scopeOfPolicyActiveInPDP.add(scope.replace(FORWARD_SLASH, File.separator)); } } boolean rename = false; @@ -862,7 +885,7 @@ public class PolicyManagerServlet extends HttpServlet { renameScope(scopesList, scopeName, newScopeName, controller); for(String scope : scopeOfPolicyActiveInPDP){ PolicyEditorScopes editorScopeEntity = new PolicyEditorScopes(); - editorScopeEntity.setScopeName(scope.replace("\\", "\\\\\\\\")); + editorScopeEntity.setScopeName(scope.replace(BACKSLASH, BACKSLASH_8TIMES)); editorScopeEntity.setUserCreatedBy(userInfo); editorScopeEntity.setUserModifiedBy(userInfo); controller.saveData(editorScopeEntity); @@ -879,9 +902,9 @@ public class PolicyManagerServlet extends HttpServlet { for(Object object : scopesList){ PolicyEditorScopes editorScopeEntity = (PolicyEditorScopes) object; String scopeName = inScopeName; - if(scopeName.contains("\\\\\\\\")){ - scopeName = scopeName.replace("\\\\\\\\", File.separator); - newScopeName = newScopeName.replace("\\\\\\\\", File.separator); + if(scopeName.contains(BACKSLASH_8TIMES)){ + scopeName = scopeName.replace(BACKSLASH_8TIMES, File.separator); + newScopeName = newScopeName.replace(BACKSLASH_8TIMES, File.separator); } String scope = editorScopeEntity.getScopeName().replace(scopeName, newScopeName); editorScopeEntity.setScopeName(scope); @@ -895,32 +918,14 @@ public class PolicyManagerServlet extends HttpServlet { PolicyController controller = getPolicyControllerInstance(); String policyVersionName = newPath.replace(".xml", ""); - String policyName = policyVersionName.substring(0, policyVersionName.lastIndexOf('.')).replace("/", File.separator); + String policyName = policyVersionName.substring(0, policyVersionName.lastIndexOf('.')).replace(FORWARD_SLASH, File.separator); String oldpolicyVersionName = oldPath.replace(".xml", ""); - String oldpolicyName = oldpolicyVersionName.substring(0, oldpolicyVersionName.lastIndexOf('.')).replace("/", File.separator); - + String oldpolicyName = oldpolicyVersionName.substring(0, oldpolicyVersionName.lastIndexOf('.')).replace(FORWARD_SLASH, File.separator); String newpolicyName = newPath.replace("/", "."); - String newPolicyCheck = newpolicyName; - if(newPolicyCheck.contains("Config_")){ - newPolicyCheck = newPolicyCheck.replace(".Config_", ":Config_"); - }else if(newPolicyCheck.contains("Action_")){ - newPolicyCheck = newPolicyCheck.replace(".Action_", ":Action_"); - }else if(newPolicyCheck.contains("Decision_")){ - newPolicyCheck = newPolicyCheck.replace(".Decision_", ":Decision_"); - } - String[] newPolicySplit = newPolicyCheck.split(":"); + String[] newPolicySplit = modifyPolicyName(newPath); - String orignalPolicyName = oldPath.replace("/", "."); - String oldPolicyCheck = orignalPolicyName; - if(oldPolicyCheck.contains("Config_")){ - oldPolicyCheck = oldPolicyCheck.replace(".Config_", ":Config_"); - }else if(oldPolicyCheck.contains("Action_")){ - oldPolicyCheck = oldPolicyCheck.replace(".Action_", ":Action_"); - }else if(oldPolicyCheck.contains("Decision_")){ - oldPolicyCheck = oldPolicyCheck.replace(".Decision_", ":Decision_"); - } - String[] oldPolicySplit = oldPolicyCheck.split(":"); + String[] oldPolicySplit = modifyPolicyName(oldPath); //Check PolicyEntity table with newPolicy Name String policyEntityquery = "FROM PolicyEntity where policyName = :newPolicySplit_1 and scope = :newPolicySplit_0"; @@ -939,36 +944,36 @@ public class PolicyManagerServlet extends HttpServlet { params.put("policyEntityCheck", policyEntityCheck + "%"); params.put("oldPolicySplit_0", oldPolicySplit[0]); List oldEntityData = controller.getDataByQuery(oldpolicyEntityquery, params); - if(!oldEntityData.isEmpty()){ - StringBuilder groupQuery = new StringBuilder(); - groupQuery.append("FROM PolicyGroupEntity where ("); - SimpleBindings geParams = new SimpleBindings(); - for(int i=0; i groupEntityData = controller.getDataByQuery(groupQuery.toString(), geParams); - if(! groupEntityData.isEmpty()){ - return error("Policy rename failed. Since the policy or its version is active in PDP Groups."); + if(oldEntityData.isEmpty()){ + return error("Policy rename failed due to policy not able to retrieve from database. Please, contact super-admin."); + } + + StringBuilder groupQuery = new StringBuilder(); + groupQuery.append("FROM PolicyGroupEntity where ("); + SimpleBindings geParams = new SimpleBindings(); + for(int i=0; i groupEntityData = controller.getDataByQuery(groupQuery.toString(), geParams); + if(! groupEntityData.isEmpty()){ + return error("Policy rename failed. Since the policy or its version is active in PDP Groups."); + } + for (Object anOldEntityData : oldEntityData) { + entity = (PolicyEntity) anOldEntityData; + String checkEntityName = entity.getPolicyName().replace(".xml", ""); + checkEntityName = checkEntityName.substring(0, checkEntityName.lastIndexOf('.')); + String originalPolicyName = oldpolicyName.substring(oldpolicyName.lastIndexOf(File.separator) + 1); + if (checkEntityName.equals(originalPolicyName)) { + checkOldPolicyEntryAndUpdate(entity, newPolicySplit[0], newPolicySplit[1], oldPolicySplit[0], oldPolicySplit[1], policyName, newpolicyName, oldpolicyName, userId); } - }else{ - return error("Policy rename failed due to policy not able to retrieve from database. Please, contact super-admin."); } return success(); @@ -978,8 +983,24 @@ public class PolicyManagerServlet extends HttpServlet { } } - private JSONObject checkOldPolicyEntryAndUpdate(PolicyEntity entity, String newScope, String removenewPolicyExtension, String oldScope, String removeoldPolicyExtension, - String policyName, String newpolicyName, String oldpolicyName, String userId) throws ServletException{ + private String[] modifyPolicyName(String pathName) { + return modifyPolicyName(FORWARD_SLASH, pathName); + } + + private String[] modifyPolicyName(String separator, String pathName) { + String policyName = pathName.replace(separator, "."); + if(policyName.contains(CONFIG2)){ + policyName = policyName.replace(CONFIG, CONFIG1); + }else if(policyName.contains(ACTION2)){ + policyName = policyName.replace(ACTION, ACTION1); + }else if(policyName.contains(DECISION2)){ + policyName = policyName.replace(DECISION, DECISION1); + } + return policyName.split(":"); + } + + private void checkOldPolicyEntryAndUpdate(PolicyEntity entity, String newScope, String removenewPolicyExtension, String oldScope, String removeoldPolicyExtension, + String policyName, String newpolicyName, String oldpolicyName, String userId) { try { ConfigurationDataEntity configEntity = entity.getConfigurationData(); ActionBodyEntity actionEntity = entity.getActionBodyEntity(); @@ -998,7 +1019,7 @@ public class PolicyManagerServlet extends HttpServlet { String oldConfigurationName = null; String newConfigurationName = null; - if(newpolicyName.contains("Config_")){ + if(newpolicyName.contains(CONFIG2)){ oldConfigurationName = configEntity.getConfigurationName(); configEntity.setConfigurationName(configEntity.getConfigurationName().replace(oldScope +"."+oldPolicyNameWithoutExtension, newScope+"."+newPolicyNameWithoutExtension)); controller.updateData(configEntity); @@ -1008,7 +1029,7 @@ public class PolicyManagerServlet extends HttpServlet { File renamefile = new File(PolicyController.getConfigHome() + File.separator + newConfigurationName); file.renameTo(renamefile); } - }else if(newpolicyName.contains("Action_")){ + }else if(newpolicyName.contains(ACTION2)){ oldConfigurationName = actionEntity.getActionBodyName(); actionEntity.setActionBody(actionEntity.getActionBody().replace(oldScope +"."+oldPolicyNameWithoutExtension, newScope+"."+newPolicyNameWithoutExtension)); controller.updateData(actionEntity); @@ -1034,14 +1055,14 @@ public class PolicyManagerServlet extends HttpServlet { }else{ controller.watchPolicyFunction(versionEntity, oldpolicyName, "Rename"); } - return success(); } catch (Exception e) { - LOGGER.error("Exception Occured"+e); - return error(e.getMessage()); + LOGGER.error(EXCEPTION_OCCURED +e); + throw e; } } - private JSONObject cloneRecord(String newpolicyName, String oldScope, String inRemoveoldPolicyExtension, String newScope, String inRemovenewPolicyExtension, PolicyEntity entity, String userId) throws ServletException{ + private void cloneRecord(String newpolicyName, String oldScope, String inRemoveoldPolicyExtension, String newScope, + String inRemovenewPolicyExtension, PolicyEntity entity, String userId) throws IOException{ String queryEntityName; PolicyController controller = getPolicyControllerInstance(); PolicyEntity cloneEntity = new PolicyEntity(); @@ -1055,7 +1076,7 @@ public class PolicyManagerServlet extends HttpServlet { String oldConfigRemoveExtension = removeoldPolicyExtension.replace(".xml", ""); String newConfigRemoveExtension = removenewPolicyExtension.replace(".xml", ""); String newConfigurationName = null; - if(newpolicyName.contains("Config_")){ + if(newpolicyName.contains(CONFIG2)){ ConfigurationDataEntity configurationDataEntity = new ConfigurationDataEntity(); configurationDataEntity.setConfigurationName(entity.getConfigurationData().getConfigurationName().replace(oldScope+"."+oldConfigRemoveExtension, newScope+"."+newConfigRemoveExtension)); queryEntityName = configurationDataEntity.getConfigurationName(); @@ -1073,8 +1094,9 @@ public class PolicyManagerServlet extends HttpServlet { bw.write(configEntiy.getConfigBody()); } catch (IOException e) { LOGGER.error("Exception Occured While cloning the configuration file"+e); + throw e; } - }else if(newpolicyName.contains("Action_")){ + }else if(newpolicyName.contains(ACTION2)){ ActionBodyEntity actionBodyEntity = new ActionBodyEntity(); actionBodyEntity.setActionBodyName(entity.getActionBodyEntity().getActionBodyName().replace(oldScope+"."+oldConfigRemoveExtension, newScope+"."+newConfigRemoveExtension)); queryEntityName = actionBodyEntity.getActionBodyName(); @@ -1091,6 +1113,7 @@ public class PolicyManagerServlet extends HttpServlet { bw.write(actionEntiy.getActionBody()); } catch (IOException e) { LOGGER.error("Exception Occured While cloning the configuration file"+e); + throw e; } } @@ -1102,7 +1125,6 @@ public class PolicyManagerServlet extends HttpServlet { //Notify others paps regarding clone policy. PolicyRestController restController = new PolicyRestController(); restController.notifyOtherPAPSToUpdateConfigurations("clonePolicy", newConfigurationName, null); - return success(); } //Clone the Policy @@ -1116,19 +1138,19 @@ public class PolicyManagerServlet extends HttpServlet { String policyVersionName = newPath.replace(".xml", ""); String version = policyVersionName.substring(policyVersionName.indexOf('.')+1); - String policyName = policyVersionName.substring(0, policyVersionName.lastIndexOf('.')).replace("/", File.separator); + String policyName = policyVersionName.substring(0, policyVersionName.lastIndexOf('.')).replace(FORWARD_SLASH, File.separator); - String newpolicyName = newPath.replace("/", "."); + String newpolicyName = newPath.replace(FORWARD_SLASH, "."); - String orignalPolicyName = oldPath.replace("/", "."); + String orignalPolicyName = oldPath.replace(FORWARD_SLASH, "."); String newPolicyCheck = newpolicyName; - if(newPolicyCheck.contains("Config_")){ - newPolicyCheck = newPolicyCheck.replace(".Config_", ":Config_"); - }else if(newPolicyCheck.contains("Action_")){ - newPolicyCheck = newPolicyCheck.replace(".Action_", ":Action_"); - }else if(newPolicyCheck.contains("Decision_")){ - newPolicyCheck = newPolicyCheck.replace(".Decision_", ":Decision_"); + if(newPolicyCheck.contains(CONFIG2)){ + newPolicyCheck = newPolicyCheck.replace(CONFIG, CONFIG1); + }else if(newPolicyCheck.contains(ACTION2)){ + newPolicyCheck = newPolicyCheck.replace(ACTION, ACTION1); + }else if(newPolicyCheck.contains(DECISION2)){ + newPolicyCheck = newPolicyCheck.replace(DECISION, DECISION1); } if(!newPolicyCheck.contains(":")){ return error("Policy Clone Failed. The Name contains special characters."); @@ -1137,19 +1159,11 @@ public class PolicyManagerServlet extends HttpServlet { String checkValidation = newPolicySplit[1].replace(".xml", ""); checkValidation = checkValidation.substring(checkValidation.indexOf('_') + 1, checkValidation.lastIndexOf(".")); - if(!PolicyUtils.policySpecialCharValidator(checkValidation).contains("success")){ + if(!PolicyUtils.policySpecialCharValidator(checkValidation).contains(SUCCESS)){ return error("Policy Clone Failed. The Name contains special characters."); } - String oldPolicyCheck = orignalPolicyName; - if(oldPolicyCheck.contains("Config_")){ - oldPolicyCheck = oldPolicyCheck.replace(".Config_", ":Config_"); - }else if(oldPolicyCheck.contains("Action_")){ - oldPolicyCheck = oldPolicyCheck.replace(".Action_", ":Action_"); - }else if(oldPolicyCheck.contains("Decision_")){ - oldPolicyCheck = oldPolicyCheck.replace(".Decision_", ":Decision_"); - } - String[] oldPolicySplit = oldPolicyCheck.split(":"); + String[] oldPolicySplit = modifyPolicyName(orignalPolicyName); PolicyController controller = getPolicyControllerInstance(); @@ -1219,26 +1233,16 @@ public class PolicyManagerServlet extends HttpServlet { deleteVersion = params.getString("deleteVersion"); } path = path.substring(path.indexOf('/')+1); - String policyNamewithExtension = path.replace("/", File.separator); + String policyNamewithExtension = path.replace(FORWARD_SLASH, File.separator); String policyVersionName = policyNamewithExtension.replace(".xml", ""); String query; SimpleBindings policyParams = new SimpleBindings(); if(path.endsWith(".xml")){ policyNamewithoutExtension = policyVersionName.substring(0, policyVersionName.lastIndexOf('.')); - policyNamewithoutExtension = policyNamewithoutExtension.replace(File.separator, "."); - String splitPolicyName = null; - if(policyNamewithoutExtension.contains("Config_")){ - splitPolicyName = policyNamewithoutExtension.replace(".Config_", ":Config_"); - }else if(policyNamewithoutExtension.contains("Action_")){ - splitPolicyName = policyNamewithoutExtension.replace(".Action_", ":Action_"); - }else if(policyNamewithoutExtension.contains("Decision_")){ - splitPolicyName = policyNamewithoutExtension.replace(".Decision_", ":Decision_"); - } - String[] split = splitPolicyName.split(":"); - + String[] split = modifyPolicyName(File.separator, policyNamewithoutExtension); query = "FROM PolicyEntity where policyName like :split_1 and scope = :split_0"; - policyParams.put("split_1", split[1] + "%"); - policyParams.put("split_0", split[0]); + policyParams.put(SPLIT_1, split[1] + "%"); + policyParams.put(SPLIT_0, split[0]); }else{ policyNamewithoutExtension = path.replace(File.separator, "."); query = "FROM PolicyEntity where scope like :policyNamewithoutExtension"; @@ -1267,11 +1271,11 @@ public class PolicyManagerServlet extends HttpServlet { restController.deleteElasticData(searchFileName); //Delete the entity from Policy Entity table controller.deleteData(policyEntity); - if(policyNamewithoutExtension.contains("Config_")){ + if(policyNamewithoutExtension.contains(CONFIG2)){ Files.deleteIfExists(Paths.get(PolicyController.getConfigHome() + File.separator + policyEntity.getConfigurationData().getConfigurationName())); controller.deleteData(policyEntity.getConfigurationData()); restController.notifyOtherPAPSToUpdateConfigurations("delete", null, policyEntity.getConfigurationData().getConfigurationName()); - }else if(policyNamewithoutExtension.contains("Action_")){ + }else if(policyNamewithoutExtension.contains(ACTION2)){ Files.deleteIfExists(Paths.get(PolicyController.getActionHome() + File.separator + policyEntity.getActionBodyEntity().getActionBodyName())); controller.deleteData(policyEntity.getActionBodyEntity()); restController.notifyOtherPAPSToUpdateConfigurations("delete", null, policyEntity.getActionBodyEntity().getActionBodyName()); @@ -1288,17 +1292,13 @@ public class PolicyManagerServlet extends HttpServlet { //Delete from policyVersion table String getActivePDPPolicyVersion = activePolicyName.replace(".xml", ""); getActivePDPPolicyVersion = getActivePDPPolicyVersion.substring(getActivePDPPolicyVersion.lastIndexOf('.')+1); - String policyVersionQuery = "update PolicyVersion set active_version='"+getActivePDPPolicyVersion+"' , highest_version='"+getActivePDPPolicyVersion+"' where policy_name ='" +policyNamewithoutExtension.replace("\\", "\\\\")+"' and id >0"; - if(policyVersionQuery != null){ - controller.executeQuery(policyVersionQuery); - } + String policyVersionQuery = UPDATE_POLICY_VERSION_SET_ACTIVE_VERSION +getActivePDPPolicyVersion+"' , highest_version='"+getActivePDPPolicyVersion+"' where policy_name ='" +policyNamewithoutExtension.replace(BACKSLASH, ESCAPE_BACKSLASH)+"' and id >0"; + controller.executeQuery(policyVersionQuery); return error("Policies with Same name has been deleted. Except the Active Policy in PDP. PolicyName: "+activePolicyName); }else{ //No Active Policy in PDP. So, deleting all entries from policyVersion table - String policyVersionQuery = "delete from PolicyVersion where policy_name ='" +policyNamewithoutExtension.replace("\\", "\\\\")+"' and id >0"; - if(policyVersionQuery != null){ - controller.executeQuery(policyVersionQuery); - } + String policyVersionQuery = "delete from PolicyVersion where policy_name ='" +policyNamewithoutExtension.replace(BACKSLASH, ESCAPE_BACKSLASH)+"' and id >0"; + controller.executeQuery(policyVersionQuery); } }else if("CURRENT".equals(deleteVersion)){ String currentVersionPolicyName = policyNamewithExtension.substring(policyNamewithExtension.lastIndexOf(File.separator)+1); @@ -1313,128 +1313,129 @@ public class PolicyManagerServlet extends HttpServlet { if(!policyEntitys.isEmpty()){ policyEntity = (PolicyEntity) policyEntitys.get(0); } - if(policyEntity != null){ - String groupEntityquery = "from PolicyGroupEntity where policyid = :policyEntityId and policyid > 0"; - SimpleBindings geParams = new SimpleBindings(); - geParams.put("policyEntityId", policyEntity.getPolicyId()); - List groupobject = controller.getDataByQuery(groupEntityquery, geParams); - if(groupobject.isEmpty()){ - //Delete the entity from Elastic Search Database - String searchFileName = policyEntity.getScope() + "." + policyEntity.getPolicyName(); - restController.deleteElasticData(searchFileName); - //Delete the entity from Policy Entity table - controller.deleteData(policyEntity); - if(policyNamewithoutExtension.contains("Config_")){ - Files.deleteIfExists(Paths.get(PolicyController.getConfigHome() + File.separator + policyEntity.getConfigurationData().getConfigurationName())); - controller.deleteData(policyEntity.getConfigurationData()); - restController.notifyOtherPAPSToUpdateConfigurations("delete", null, policyEntity.getConfigurationData().getConfigurationName()); - }else if(policyNamewithoutExtension.contains("Action_")){ - Files.deleteIfExists(Paths.get(PolicyController.getActionHome() + File.separator + policyEntity.getActionBodyEntity().getActionBodyName())); - controller.deleteData(policyEntity.getActionBodyEntity()); - restController.notifyOtherPAPSToUpdateConfigurations("delete", null, policyEntity.getActionBodyEntity().getActionBodyName()); - } + if(policyEntity == null){ + return success(); + } - if(version > 1){ - int highestVersion = 0; - if(!policyEntityobjects.isEmpty()){ - for(Object object : policyEntityobjects){ - policyEntity = (PolicyEntity) object; - String policyEntityName = policyEntity.getPolicyName().replace(".xml", ""); - int policyEntityVersion = Integer.parseInt(policyEntityName.substring(policyEntityName.lastIndexOf('.')+1)); - if(policyEntityVersion > highestVersion && policyEntityVersion != version){ - highestVersion = policyEntityVersion; - } - } - } + String groupEntityquery = "from PolicyGroupEntity where policyid = :policyEntityId and policyid > 0"; + SimpleBindings geParams = new SimpleBindings(); + geParams.put("policyEntityId", policyEntity.getPolicyId()); + List groupobject = controller.getDataByQuery(groupEntityquery, geParams); + if(!groupobject.isEmpty()){ + return error("Policy can't be deleted, it is active in PDP Groups. PolicyName: '"+policyEntity.getScope() + "." +policyEntity.getPolicyName()+"'"); + } - //Policy Notification - PolicyVersion entity = new PolicyVersion(); - entity.setPolicyName(policyNamewithoutExtension); - entity.setActiveVersion(highestVersion); - entity.setModifiedBy(userId); - controller.watchPolicyFunction(entity, policyNamewithExtension, "DeleteOne"); - - String updatequery = ""; - if(highestVersion != 0){ - updatequery = "update PolicyVersion set active_version='"+highestVersion+"' , highest_version='"+highestVersion+"' where policy_name ='" +policyNamewithoutExtension.replace("\\", "\\\\")+"'"; - }else{ - updatequery = "delete from PolicyVersion where policy_name ='" +policyNamewithoutExtension.replace("\\", "\\\\")+"' and id >0"; - } - controller.executeQuery(updatequery); - }else{ - String policyVersionQuery = "delete from PolicyVersion where policy_name ='" +policyNamewithoutExtension.replace("\\", "\\\\")+"' and id >0"; - if(policyVersionQuery != null){ - controller.executeQuery(policyVersionQuery); + //Delete the entity from Elastic Search Database + String searchFileName = policyEntity.getScope() + "." + policyEntity.getPolicyName(); + restController.deleteElasticData(searchFileName); + //Delete the entity from Policy Entity table + controller.deleteData(policyEntity); + if(policyNamewithoutExtension.contains(CONFIG2)){ + Files.deleteIfExists(Paths.get(PolicyController.getConfigHome() + File.separator + policyEntity.getConfigurationData().getConfigurationName())); + controller.deleteData(policyEntity.getConfigurationData()); + restController.notifyOtherPAPSToUpdateConfigurations("delete", null, policyEntity.getConfigurationData().getConfigurationName()); + }else if(policyNamewithoutExtension.contains(ACTION2)){ + Files.deleteIfExists(Paths.get(PolicyController.getActionHome() + File.separator + policyEntity.getActionBodyEntity().getActionBodyName())); + controller.deleteData(policyEntity.getActionBodyEntity()); + restController.notifyOtherPAPSToUpdateConfigurations("delete", null, policyEntity.getActionBodyEntity().getActionBodyName()); + } + + if(version > 1){ + int highestVersion = 0; + if(!policyEntityobjects.isEmpty()){ + for(Object object : policyEntityobjects){ + policyEntity = (PolicyEntity) object; + String policyEntityName = policyEntity.getPolicyName().replace(".xml", ""); + int policyEntityVersion = Integer.parseInt(policyEntityName.substring(policyEntityName.lastIndexOf('.')+1)); + if(policyEntityVersion > highestVersion && policyEntityVersion != version){ + highestVersion = policyEntityVersion; } } + } + + //Policy Notification + PolicyVersion entity = new PolicyVersion(); + entity.setPolicyName(policyNamewithoutExtension); + entity.setActiveVersion(highestVersion); + entity.setModifiedBy(userId); + controller.watchPolicyFunction(entity, policyNamewithExtension, "DeleteOne"); + + String updatequery; + if(highestVersion != 0){ + updatequery = UPDATE_POLICY_VERSION_SET_ACTIVE_VERSION +highestVersion+"' , highest_version='"+highestVersion+"' where policy_name ='" +policyNamewithoutExtension.replace("\\", "\\\\")+"'"; }else{ - return error("Policy can't be deleted, it is active in PDP Groups. PolicyName: '"+policyEntity.getScope() + "." +policyEntity.getPolicyName()+"'"); + updatequery = "delete from PolicyVersion where policy_name ='" +policyNamewithoutExtension.replace("\\", "\\\\")+"' and id >0"; } + controller.executeQuery(updatequery); + }else{ + String policyVersionQuery = "delete from PolicyVersion where policy_name ='" +policyNamewithoutExtension.replace("\\", "\\\\")+"' and id >0"; + controller.executeQuery(policyVersionQuery); } } }else{ List activePoliciesInPDP = new ArrayList<>(); - if(!policyEntityobjects.isEmpty()){ - for(Object object : policyEntityobjects){ - policyEntity = (PolicyEntity) object; - String groupEntityquery = "from PolicyGroupEntity where policyid = :policyEntityId"; - SimpleBindings geParams = new SimpleBindings(); - geParams.put("policyEntityId", policyEntity.getPolicyId()); - List groupobject = controller.getDataByQuery(groupEntityquery, geParams); - if(!groupobject.isEmpty()){ - pdpCheck = true; - activePoliciesInPDP.add(policyEntity.getScope()+"."+policyEntity.getPolicyName()); - }else{ - //Delete the entity from Elastic Search Database - String searchFileName = policyEntity.getScope() + "." + policyEntity.getPolicyName(); - restController.deleteElasticData(searchFileName); - //Delete the entity from Policy Entity table - controller.deleteData(policyEntity); - policyNamewithoutExtension = policyEntity.getPolicyName(); - if(policyNamewithoutExtension.contains("Config_")){ - Files.deleteIfExists(Paths.get(PolicyController.getConfigHome() + File.separator + policyEntity.getConfigurationData().getConfigurationName())); - controller.deleteData(policyEntity.getConfigurationData()); - restController.notifyOtherPAPSToUpdateConfigurations("delete", null, policyEntity.getConfigurationData().getConfigurationName()); - }else if(policyNamewithoutExtension.contains("Action_")){ - Files.deleteIfExists(Paths.get(PolicyController.getActionHome() + File.separator + policyEntity.getActionBodyEntity().getActionBodyName())); - controller.deleteData(policyEntity.getActionBodyEntity()); - restController.notifyOtherPAPSToUpdateConfigurations("delete", null, policyEntity.getActionBodyEntity().getActionBodyName()); - } + if(policyEntityobjects.isEmpty()){ + String policyScopeQuery = "delete PolicyEditorScopes where SCOPENAME like '"+path.replace(BACKSLASH, ESCAPE_BACKSLASH)+"%' and id >0"; + controller.executeQuery(policyScopeQuery); + return success(); + } + for(Object object : policyEntityobjects){ + policyEntity = (PolicyEntity) object; + String groupEntityquery = "from PolicyGroupEntity where policyid = :policyEntityId"; + SimpleBindings geParams = new SimpleBindings(); + geParams.put("policyEntityId", policyEntity.getPolicyId()); + List groupobject = controller.getDataByQuery(groupEntityquery, geParams); + if(!groupobject.isEmpty()){ + pdpCheck = true; + activePoliciesInPDP.add(policyEntity.getScope()+"."+policyEntity.getPolicyName()); + }else{ + //Delete the entity from Elastic Search Database + String searchFileName = policyEntity.getScope() + "." + policyEntity.getPolicyName(); + restController.deleteElasticData(searchFileName); + //Delete the entity from Policy Entity table + controller.deleteData(policyEntity); + policyNamewithoutExtension = policyEntity.getPolicyName(); + if(policyNamewithoutExtension.contains(CONFIG2)){ + Files.deleteIfExists(Paths.get(PolicyController.getConfigHome() + File.separator + policyEntity.getConfigurationData().getConfigurationName())); + controller.deleteData(policyEntity.getConfigurationData()); + restController.notifyOtherPAPSToUpdateConfigurations("delete", null, policyEntity.getConfigurationData().getConfigurationName()); + }else if(policyNamewithoutExtension.contains(ACTION2)){ + Files.deleteIfExists(Paths.get(PolicyController.getActionHome() + File.separator + policyEntity.getActionBodyEntity().getActionBodyName())); + controller.deleteData(policyEntity.getActionBodyEntity()); + restController.notifyOtherPAPSToUpdateConfigurations("delete", null, policyEntity.getActionBodyEntity().getActionBodyName()); } } - //Delete from policyVersion and policyEditor Scope table - String policyVersionQuery = "delete PolicyVersion where POLICY_NAME like '"+path.replace("\\", "\\\\")+"%' and id >0"; - controller.executeQuery(policyVersionQuery); - - //Policy Notification - PolicyVersion entity = new PolicyVersion(); - entity.setPolicyName(path); - entity.setModifiedBy(userId); - controller.watchPolicyFunction(entity, path, "DeleteScope"); - if(pdpCheck){ - //Add Active Policies List to PolicyVersionTable - for(int i =0; i < activePoliciesInPDP.size(); i++){ - String activePDPPolicyName = activePoliciesInPDP.get(i).replace(".xml", ""); - int activePDPPolicyVersion = Integer.parseInt(activePDPPolicyName.substring(activePDPPolicyName.lastIndexOf('.')+1)); - activePDPPolicyName = activePDPPolicyName.substring(0, activePDPPolicyName.lastIndexOf('.')).replace(".", File.separator); - PolicyVersion insertactivePDPVersion = new PolicyVersion(); - insertactivePDPVersion.setPolicyName(activePDPPolicyName); - insertactivePDPVersion.setHigherVersion(activePDPPolicyVersion); - insertactivePDPVersion.setActiveVersion(activePDPPolicyVersion); - insertactivePDPVersion.setCreatedBy(userId); - insertactivePDPVersion.setModifiedBy(userId); - controller.saveData(insertactivePDPVersion); - } - - return error("All the Policies has been deleted in Scope. Except the following list of Policies:"+activePoliciesInPDP); - }else{ - String policyScopeQuery = "delete PolicyEditorScopes where SCOPENAME like '"+path.replace("\\", "\\\\")+"%' and id >0"; - controller.executeQuery(policyScopeQuery); + } + //Delete from policyVersion and policyEditor Scope table + String policyVersionQuery = "delete PolicyVersion where POLICY_NAME like '"+path.replace(BACKSLASH, ESCAPE_BACKSLASH)+"%' and id >0"; + controller.executeQuery(policyVersionQuery); + + //Policy Notification + PolicyVersion entity = new PolicyVersion(); + entity.setPolicyName(path); + entity.setModifiedBy(userId); + controller.watchPolicyFunction(entity, path, "DeleteScope"); + if(pdpCheck){ + //Add Active Policies List to PolicyVersionTable + for (String anActivePoliciesInPDP : activePoliciesInPDP) { + String activePDPPolicyName = anActivePoliciesInPDP.replace(".xml", ""); + int activePDPPolicyVersion = Integer.parseInt(activePDPPolicyName.substring(activePDPPolicyName.lastIndexOf('.') + 1)); + activePDPPolicyName = activePDPPolicyName.substring(0, activePDPPolicyName.lastIndexOf('.')).replace(".", File.separator); + PolicyVersion insertactivePDPVersion = new PolicyVersion(); + insertactivePDPVersion.setPolicyName(activePDPPolicyName); + insertactivePDPVersion.setHigherVersion(activePDPPolicyVersion); + insertactivePDPVersion.setActiveVersion(activePDPPolicyVersion); + insertactivePDPVersion.setCreatedBy(userId); + insertactivePDPVersion.setModifiedBy(userId); + controller.saveData(insertactivePDPVersion); } + + return error("All the Policies has been deleted in Scope. Except the following list of Policies:"+activePoliciesInPDP); }else{ - String policyScopeQuery = "delete PolicyEditorScopes where SCOPENAME like '"+path.replace("\\", "\\\\")+"%' and id >0"; + String policyScopeQuery = "delete PolicyEditorScopes where SCOPENAME like '"+path.replace(BACKSLASH, ESCAPE_BACKSLASH)+"%' and id >0"; controller.executeQuery(policyScopeQuery); } + } return success(); } catch (Exception e) { @@ -1453,24 +1454,17 @@ public class PolicyManagerServlet extends HttpServlet { LOGGER.debug("editFile path: {}"+ path); String domain = path.substring(1, path.lastIndexOf('/')); - domain = domain.replace("/", "."); + domain = domain.replace(FORWARD_SLASH, "."); path = path.substring(1); - path = path.replace("/", "."); - String dbCheckName = path; - if(dbCheckName.contains("Config_")){ - dbCheckName = dbCheckName.replace(".Config_", ":Config_"); - }else if(dbCheckName.contains("Action_")){ - dbCheckName = dbCheckName.replace(".Action_", ":Action_"); - }else if(dbCheckName.contains("Decision_")){ - dbCheckName = dbCheckName.replace(".Decision_", ":Decision_"); - } + path = path.replace(FORWARD_SLASH, "."); + + String[] split = modifyPolicyName(path); - String[] split = dbCheckName.split(":"); String query = "FROM PolicyEntity where policyName = :split_1 and scope = :split_0"; SimpleBindings peParams = new SimpleBindings(); - peParams.put("split_1", split[1]); - peParams.put("split_0", split[0]); + peParams.put(SPLIT_1, split[1]); + peParams.put(SPLIT_0, split[0]); List queryData; if(PolicyController.isjUnit()){ queryData = controller.getDataByQuery(query, null); @@ -1500,7 +1494,7 @@ public class PolicyManagerServlet extends HttpServlet { policyAdapter.setPolicyName(policyName.substring(policyName.lastIndexOf('.')+1)); PolicyAdapter setpolicyAdapter = PolicyAdapter.getInstance(); - setpolicyAdapter.configure(policyAdapter,entity); + Objects.requireNonNull(setpolicyAdapter).configure(policyAdapter,entity); policyAdapter.setParentPath(null); ObjectMapper mapper = new ObjectMapper(); @@ -1522,9 +1516,9 @@ public class PolicyManagerServlet extends HttpServlet { String userId = UserUtils.getUserSession(request).getOrgUserId(); String path = params.getString("path"); try{ - if(params.has("subScopename")){ - if(! "".equals(params.getString("subScopename"))) { - name = params.getString("path").replace("/", File.separator) + File.separator +params.getString("subScopename"); + if(params.has(SUB_SCOPENAME)){ + if(! "".equals(params.getString(SUB_SCOPENAME))) { + name = params.getString("path").replace(FORWARD_SLASH, File.separator) + File.separator +params.getString(SUB_SCOPENAME); } }else{ name = params.getString(NAME); @@ -1541,7 +1535,7 @@ public class PolicyManagerServlet extends HttpServlet { } if(!name.isEmpty()){ String validate = PolicyUtils.policySpecialCharValidator(validateName); - if(!validate.contains("success")){ + if(!validate.contains(SUCCESS)){ return error(validate); } } @@ -1550,7 +1544,7 @@ public class PolicyManagerServlet extends HttpServlet { if(name.startsWith(File.separator)){ name = name.substring(1); } - PolicyEditorScopes entity = (PolicyEditorScopes) controller.getEntityItem(PolicyEditorScopes.class, "scopeName", name); + PolicyEditorScopes entity = (PolicyEditorScopes) controller.getEntityItem(PolicyEditorScopes.class, SCOPE_NAME, name); if(entity == null){ UserInfo userInfo = new UserInfo(); userInfo.setUserLoginId(userId); @@ -1574,7 +1568,7 @@ public class PolicyManagerServlet extends HttpServlet { private JSONObject error(String msg) throws ServletException { try { JSONObject result = new JSONObject(); - result.put("success", false); + result.put(SUCCESS, false); result.put("error", msg); return new JSONObject().put(RESULT, result); } catch (JSONException e) { @@ -1586,7 +1580,7 @@ public class PolicyManagerServlet extends HttpServlet { private JSONObject success() throws ServletException { try { JSONObject result = new JSONObject(); - result.put("success", true); + result.put(SUCCESS, true); result.put("error", (Object) null); return new JSONObject().put(RESULT, result); } catch (JSONException e) { @@ -1598,7 +1592,7 @@ public class PolicyManagerServlet extends HttpServlet { return policyController != null ? getPolicyController() : new PolicyController(); } - public String getTestUserId() { + private String getTestUserId() { return testUserId; }