X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=ONAP-XACML%2Fsrc%2Ftest%2Fjava%2Forg%2Fonap%2Fpolicy%2Fxacml%2Ftest%2Fstd%2Fpap%2FStdPDPTest.java;h=e62f1fdb13476a3ec4a4cb9894dc7965ceb27d9d;hb=3387ae275aeb64113d48cd67b44db217b67e598e;hp=ab1fb88e7ef759c71bac03e0fc85d3029300567c;hpb=95ba8a85dacd65101f550e2d32dda33780b16dbd;p=policy%2Fengine.git

diff --git a/ONAP-XACML/src/test/java/org/onap/policy/xacml/test/std/pap/StdPDPTest.java b/ONAP-XACML/src/test/java/org/onap/policy/xacml/test/std/pap/StdPDPTest.java
index ab1fb88e7..e62f1fdb1 100644
--- a/ONAP-XACML/src/test/java/org/onap/policy/xacml/test/std/pap/StdPDPTest.java
+++ b/ONAP-XACML/src/test/java/org/onap/policy/xacml/test/std/pap/StdPDPTest.java
@@ -1,9 +1,8 @@
-package org.onap.policy.xacml.test.std.pap;
 /*-
  * ============LICENSE_START=======================================================
  * ONAP-XACML
  * ================================================================================
- * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -18,88 +17,155 @@ package org.onap.policy.xacml.test.std.pap;
  * limitations under the License.
  * ============LICENSE_END=========================================================
  */
-import static org.junit.Assert.assertTrue;
 
+package org.onap.policy.xacml.test.std.pap;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.CoreMatchers.not;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertThat;
+import static org.junit.Assert.assertTrue;
+import java.util.HashSet;
+import java.util.Properties;
+import java.util.Set;
 import org.junit.Before;
 import org.junit.Test;
 import org.onap.policy.common.logging.flexlogger.FlexLogger;
 import org.onap.policy.common.logging.flexlogger.Logger;
 import org.onap.policy.xacml.std.pap.StdPDP;
 import org.onap.policy.xacml.std.pap.StdPDPStatus;
+import com.att.research.xacml.api.pap.PDPPIPConfig;
+import com.att.research.xacml.api.pap.PDPPolicy;
 
 public class StdPDPTest {
 
-	private static Logger logger = FlexLogger.getLogger(StdPDPTest.class);
-	
-	private StdPDP stdPDP;
-	
-	@Before
-	public void setUp(){
-	
-		try {
-			stdPDP = new StdPDP();
-		} catch (Exception e) {
-			logger.error(e);
-		} 
-	}
-
-	@Test
-	public void testGetId() {
-		try {
-			stdPDP.setId("testId");
-			assertTrue(stdPDP.getId() != null);
-		} catch (Exception e) {
-			logger.error(e);
-		}
-	}
-
-	@Test
-	public void testGetName() {
-		try {
-			stdPDP.setName("abc");
-			assertTrue(stdPDP.getName() != null);
-		} catch (Exception e) {
-			logger.error(e);
-		}
-	}
-
-	@Test
-	public void testGetDescription() {
-		try {
-			stdPDP.setDescription("somee here");
-			assertTrue(stdPDP.getDescription() != null);
-		} catch (Exception e) {
-			logger.error(e);
-		}
-	}
-
-	@Test
-	public void testGetStatus() {
-		try {
-			stdPDP.setStatus(new StdPDPStatus());
-			assertTrue(stdPDP.getStatus() != null);
-		} catch (Exception e) {
-			logger.error(e);
-		}
-	}
-
-	@Test
-	public void testGetPipConfigs() {
-		try {
-			assertTrue(stdPDP.getPipConfigs() != null);
-		} catch (Exception e) {
-			logger.error(e);
-		}
-	}
-
-	@Test
-	public void testGetJmxPort() {
-		try {
-			stdPDP.setJmxPort(123);
-			assertTrue(stdPDP.getJmxPort() != null);
-		} catch (Exception e) {
-			logger.error(e);
-		}
-	}
+  private static Logger logger = FlexLogger.getLogger(StdPDPTest.class);
+
+  private StdPDP stdPDP;
+
+  @Before
+  public void setUp() {
+
+    try {
+      stdPDP = new StdPDP();
+    } catch (Exception e) {
+      logger.error(e);
+    }
+  }
+
+  @Test
+  public void testGetId() {
+    try {
+      stdPDP.setId("testId");
+      assertTrue(stdPDP.getId() != null);
+    } catch (Exception e) {
+      logger.error(e);
+    }
+  }
+
+  @Test
+  public void testGetName() {
+    try {
+      stdPDP.setName("abc");
+      assertTrue(stdPDP.getName() != null);
+    } catch (Exception e) {
+      logger.error(e);
+    }
+  }
+
+  @Test
+  public void testGetDescription() {
+    try {
+      stdPDP.setDescription("somee here");
+      assertTrue(stdPDP.getDescription() != null);
+    } catch (Exception e) {
+      logger.error(e);
+    }
+  }
+
+  @Test
+  public void testGetStatus() {
+    try {
+      stdPDP.setStatus(new StdPDPStatus());
+      assertTrue(stdPDP.getStatus() != null);
+    } catch (Exception e) {
+      logger.error(e);
+    }
+  }
+
+  @Test
+  public void testGetPipConfigs() {
+    try {
+      assertTrue(stdPDP.getPipConfigs() != null);
+    } catch (Exception e) {
+      logger.error(e);
+    }
+  }
+
+  @Test
+  public void testGetJmxPort() {
+    try {
+      stdPDP.setJmxPort(123);
+      assertTrue(stdPDP.getJmxPort() != null);
+    } catch (Exception e) {
+      logger.error(e);
+    }
+  }
+
+  @Test
+  public void testPDP() {
+    // Set up test data
+    String id = "testID";
+    String value = "testVal";
+    Properties props = new Properties();
+    props.setProperty(id + ".name", value);
+    props.setProperty(id + ".description", value);
+    props.setProperty(id + ".jmxport", "0");
+    Set<PDPPIPConfig> pipConfigs = new HashSet<PDPPIPConfig>();
+    Set<PDPPolicy> policies = new HashSet<PDPPolicy>();
+
+    // Test constructors
+    StdPDP pdp = new StdPDP(id, 0);
+    assertNotNull(pdp);
+    StdPDP pdp2 = new StdPDP(id, value, 0);
+    assertNotNull(pdp2);
+    StdPDP pdp3 = new StdPDP(id, value, value, 0);
+    assertNotNull(pdp3);
+    StdPDP pdp4 = new StdPDP(id, props);
+    assertNotNull(pdp4);
+    StdPDP pdp5 = new StdPDP(id, props);
+    assertNotNull(pdp5);
+
+    // Test set and get
+    pdp.setPipConfigs(pipConfigs);
+    assertEquals(pipConfigs, pdp.getPipConfigs());
+    pdp.setPolicies(policies);
+    assertEquals(policies, pdp.getPolicies());
+
+    // Test equals combinations
+    assertEquals(true, pdp4.equals(pdp5));
+    assertEquals(true, pdp4.equals(pdp4));
+    assertEquals(false, pdp4.equals(null));
+    assertEquals(false, pdp4.equals(value));
+    pdp4.setId(null);
+    assertEquals(false, pdp4.equals(value));
+    pdp5.setId(id);
+    assertEquals(false, pdp4.equals(pdp5));
+    pdp4.setId(value);
+    assertEquals(false, pdp4.equals(pdp5));
+    assertThat(pdp.hashCode(), is(not(0)));
+
+    // Test compare
+    assertEquals(-1, pdp4.compareTo(null));
+    assertEquals(0, pdp4.compareTo(pdp4));
+    pdp5.setName(null);
+    assertEquals(-1, pdp4.compareTo(pdp5));
+    pdp4.setName(null);
+    pdp5.setName(value);
+    assertEquals(1, pdp4.compareTo(pdp5));
 
+    // Test toString
+    assertThat(pdp.toString().length(), is(not(0)));
+  }
 }